Re: [openstack-dev] [All] Disabling Pushes of new Gerrit Draft Patchsets

2014-06-01 Thread Zaro
Just to let you know, there have been requests to run builds/tests on drafts changes in the past[1] so it seems like there's been mixed feelings on running CI on changes that are not ready for human review. You are correct, making WIP sticky would not work because it is a per user vote. If

Re: [openstack-dev] [All] Disabling Pushes of new Gerrit Draft Patchsets

2014-05-31 Thread Eugene Nikanorov
Hi, I might be posting a question to a wrong thread, but what would be the option to push a patch that I would like to share only with certain group of people. In other words, is there still an option to push non-public patches? I wouldn't like such patches to affect gerrit stream or trigger CIs,

Re: [openstack-dev] [All] Disabling Pushes of new Gerrit Draft Patchsets

2014-05-31 Thread Clark Boylan
There isn't an option to push non public patches (and there really wasn't before either, drafts are not properly private and this false expectation is one of the reasons we have disabled them). Currently the recommended alternative is work in progress. The code cannot merge with a work in progress

Re: [openstack-dev] [All] Disabling Pushes of new Gerrit Draft Patchsets

2014-05-31 Thread Morgan Fainberg
: OpenStack Development Mailing List (not for usage questions) openstack-dev@lists.openstack.org Date: May 31, 2014 at 12:33:33 To: OpenStack Development Mailing List (not for usage questions) openstack-dev@lists.openstack.org Subject:  Re: [openstack-dev] [All] Disabling Pushes of new Gerrit Draft

Re: [openstack-dev] [All] Disabling Pushes of new Gerrit Draft Patchsets

2014-05-31 Thread Sean Dague
On 05/31/2014 04:30 PM, Morgan Fainberg wrote: I’ve had this question asked numerous times (by previous coworkers, people interested in contributing to OpenStack, etc). The general feeling has always been that the individual is concerned about 3 things when considering drafts in gerrit. 1.

Re: [openstack-dev] [All] Disabling Pushes of new Gerrit Draft Patchsets

2014-05-31 Thread Morgan Fainberg
2. Since a patch is very much WIP, there is concern about consuming CI  resources with needless testing.  3. The code is “example”, “toy”, or “exploratory” (not planning to  submit to the project, but not private/proprietary)    The general advice I give to people is to post the patches

Re: [openstack-dev] [All] Disabling Pushes of new Gerrit Draft Patchsets

2014-05-30 Thread Clark Boylan
On Wed, May 21, 2014 at 4:24 PM, Clark Boylan clark.boy...@gmail.com wrote: Hello everyone, Gerrit has long supported Draft patchsets, and the infra team has long recommended against using them as they are a source of bugs and confusion (see below for specific details if you are curious). The

Re: [openstack-dev] [All] Disabling Pushes of new Gerrit Draft Patchsets

2014-05-30 Thread Sergey Lukjanov
Yay! No more weird CR chains. On Fri, May 30, 2014 at 9:32 PM, Clark Boylan clark.boy...@gmail.com wrote: On Wed, May 21, 2014 at 4:24 PM, Clark Boylan clark.boy...@gmail.com wrote: Hello everyone, Gerrit has long supported Draft patchsets, and the infra team has long recommended against

Re: [openstack-dev] [All] Disabling Pushes of new Gerrit Draft Patchsets

2014-05-23 Thread ZZelle
Hello, One small remark: Work in Progress can be set only by change owners (defined in All-Projects ACLs) which could be a limitation when multiple people contribute to the same change. Cedric ZZelle@IRC On Thu, May 22, 2014 at 1:43 PM, Sergey Lukjanov slukja...@mirantis.comwrote: Great, I

Re: [openstack-dev] [All] Disabling Pushes of new Gerrit Draft Patchsets

2014-05-23 Thread Anita Kuno
On 05/23/2014 04:56 PM, ZZelle wrote: Hello, One small remark: Work in Progress can be set only by change owners (defined in All-Projects ACLs) which could be a limitation when multiple people contribute to the same change. Cedric ZZelle@IRC Work in Progress can be set by the core

Re: [openstack-dev] [All] Disabling Pushes of new Gerrit Draft Patchsets

2014-05-22 Thread Sergey Lukjanov
Great, I think it'll make CRs more consistent, especially from the reviewers PoV. On Thu, May 22, 2014 at 3:24 AM, Clark Boylan clark.boy...@gmail.com wrote: Hello everyone, Gerrit has long supported Draft patchsets, and the infra team has long recommended against using them as they are a