Re: [openstack-dev] [Horizon] Edit subnet in workflows - ip_version hidden?

2014-03-17 Thread Akihiro Motoki
Hi Abishek, Radomir, I just noticed this mail. It seems better the code discussed will be refactored. UpdateSubnetInfoAction in projects/networks/subnets/workflow.py inherits CreateSubnetInfoAction in projects/networks/workflow.py. IIRC I would like to share most logic between two and tried to

Re: [openstack-dev] [Horizon] Edit subnet in workflows - ip_version hidden?

2014-03-12 Thread Radomir Dopieralski
On 11/03/14 16:57, Abishek Subramanian (absubram) wrote: Althouh - how up to date is this code? This should be easy to check with the git blame command: $ git blame openstack_dashboard/dashboards/project/networks/subnets/workflows.py [...] 31d55e50 (Akihiro MOTOKI 2013-01-04 18:33:03

Re: [openstack-dev] [Horizon] Edit subnet in workflows - ip_version hidden?

2014-03-11 Thread Radomir Dopieralski
On 11/03/14 15:52, Abishek Subramanian (absubram) wrote: Hi, I had a question regarding the dashboards/project/networks/subnets/workflows.py file and in particular the portion of the ip_version field. It is marked as a hidden input field for the update subnet class with this note. #

Re: [openstack-dev] [Horizon] Edit subnet in workflows - ip_version hidden?

2014-03-11 Thread Abishek Subramanian (absubram)
Thanks Radomir. Yes I've changed it to a readonly. But just wanted to double check I didn't end up breaking something elsewhere :) Althouh - how up to date is this code? These are the actual lines of code - # NOTE(amotoki): When 'disabled' attribute is set for the ChoiceField # and