Re: [openstack-dev] [goals][upgrade-checkers] Week R-25 Update

2018-10-24 Thread Ben Nemec
On 10/23/18 9:55 PM, Adrian Turjak wrote: On 24/10/18 2:09 AM, Ben Nemec wrote: On 10/22/18 5:40 PM, Matt Riedemann wrote: On 10/22/2018 4:35 PM, Adrian Turjak wrote: The one other open question I have is about the Adjutant change [2]. I know Adjutant is very new and I'm not sure what

Re: [openstack-dev] [goals][upgrade-checkers] Week R-25 Update

2018-10-24 Thread Jean-Philippe Evrard
On Tue, 2018-10-23 at 16:40 -0500, Matt Riedemann wrote: > On 10/23/2018 1:41 PM, Sean McGinnis wrote: > > > Yeah, but part of the reason for placeholders was consistency > > > across all of > > > the services. I guess if there are never going to be upgrade > > > checks in > > > adjutant then I

Re: [openstack-dev] [goals][upgrade-checkers] Week R-25 Update

2018-10-23 Thread Adrian Turjak
On 24/10/18 2:09 AM, Ben Nemec wrote: > > > On 10/22/18 5:40 PM, Matt Riedemann wrote: >> On 10/22/2018 4:35 PM, Adrian Turjak wrote: The one other open question I have is about the Adjutant change [2]. I know Adjutant is very new and I'm not sure what upgrades look like for that

Re: [openstack-dev] [goals][upgrade-checkers] Week R-25 Update

2018-10-23 Thread Matt Riedemann
On 10/23/2018 1:41 PM, Sean McGinnis wrote: Yeah, but part of the reason for placeholders was consistency across all of the services. I guess if there are never going to be upgrade checks in adjutant then I could see skipping it, but otherwise I would prefer to at least get the framework in

Re: [openstack-dev] [goals][upgrade-checkers] Week R-25 Update

2018-10-23 Thread Sean McGinnis
On Tue, Oct 23, 2018 at 10:30:23AM -0400, Ben Nemec wrote: > > > On 10/23/18 9:58 AM, Matt Riedemann wrote: > > On 10/23/2018 8:09 AM, Ben Nemec wrote: > > > Can't we just add a noop command like we are for the services that > > > don't currently need upgrade checks? > > > > We could, but I was

Re: [openstack-dev] [goals][upgrade-checkers] Week R-25 Update

2018-10-23 Thread Ben Nemec
On 10/23/18 9:58 AM, Matt Riedemann wrote: On 10/23/2018 8:09 AM, Ben Nemec wrote: Can't we just add a noop command like we are for the services that don't currently need upgrade checks? We could, but I was also hoping that for most projects we will actually be able to replace the noop /

Re: [openstack-dev] [goals][upgrade-checkers] Week R-25 Update

2018-10-23 Thread Matt Riedemann
On 10/23/2018 8:09 AM, Ben Nemec wrote: Can't we just add a noop command like we are for the services that don't currently need upgrade checks? We could, but I was also hoping that for most projects we will actually be able to replace the noop / placeholder check with *something* useful in

Re: [openstack-dev] [goals][upgrade-checkers] Week R-25 Update

2018-10-23 Thread Ben Nemec
On 10/22/18 5:40 PM, Matt Riedemann wrote: On 10/22/2018 4:35 PM, Adrian Turjak wrote: The one other open question I have is about the Adjutant change [2]. I know Adjutant is very new and I'm not sure what upgrades look like for that project, so I don't really know how valuable adding the

Re: [openstack-dev] [goals][upgrade-checkers] Week R-25 Update

2018-10-22 Thread Matt Riedemann
On 10/22/2018 4:35 PM, Adrian Turjak wrote: The one other open question I have is about the Adjutant change [2]. I know Adjutant is very new and I'm not sure what upgrades look like for that project, so I don't really know how valuable adding the upgrade check framework is to that project. Is it

Re: [openstack-dev] [goals][upgrade-checkers] Week R-25 Update

2018-10-22 Thread Adrian Turjak
On 20/10/18 4:09 AM, Matt Riedemann wrote: > The big news this week is we have a couple of volunteer developers > from NEC (Akhil Jain and Rajat Dhasmana) who are pushing the base > framework changes across a lot of the projects [1]. I'm trying to > review as many of these as I can. The request