Re: [openstack-dev] [nova][oslo][policy] oslo.policy adoption in Nova.

2015-09-08 Thread Lei Zhang
The oslo.policy has a class method `from_dict` which can be helpful. So I replaced the `parse_rule` with `from_dict`, and it works as expect. Is there any other feature that oslo.policy doesn't have? On Mon, Sep 7, 2015 at 6:48 PM, Sergey Vilgelm wrote: > Hi nova-team,

Re: [openstack-dev] [nova][oslo][policy] oslo.policy adoption in Nova.

2015-09-07 Thread Sergey Vilgelm
Hi nova-team, Jeffrey Zhang has updated his patch[1]. Dan Smith, Could you remove -2? [1] https://review.openstack.org/#/c/198065 > On Aug 20, 2015, at 17:26, Sergey Vilgelm wrote: > > Nova-cores, > Do you have any decision

Re: [openstack-dev] [nova][oslo][policy] oslo.policy adoption in Nova.

2015-08-03 Thread Sergey Vilgelm
If i understood correctly, the main difference is that the parse_rule function is a private now in the oslo.policy library, also Jeffrey Zhang has changed this function and put into nova.policy module. I offer remove this function from the nova and make a public in the oslo.policy. On Mon, Aug 3,

Re: [openstack-dev] [nova][oslo][policy] oslo.policy adoption in Nova.

2015-08-03 Thread Doug Hellmann
Excerpts from Doug Hellmann's message of 2015-08-03 16:19:31 -0400: Excerpts from Morgan Fainberg's message of 2015-08-04 06:05:56 +1000: On Aug 4, 2015, at 05:49, Doug Hellmann d...@doughellmann.com wrote: Excerpts from Sergey Vilgelm's message of 2015-08-03 22:11:50 +0300: On

Re: [openstack-dev] [nova][oslo][policy] oslo.policy adoption in Nova.

2015-08-03 Thread Doug Hellmann
Excerpts from Davanum Srinivas (dims)'s message of 2015-08-02 21:16:32 -0400: Sean, Nova-cores, The following Nova review is stuck: https://review.openstack.org/#/c/198065/ What's the minimum features in oslo.policy that we have to add in oslo.policy to unblock that work? If we get

Re: [openstack-dev] [nova][oslo][policy] oslo.policy adoption in Nova.

2015-08-03 Thread Davanum Srinivas
Doug, All the features needed for Nova to work is present in oslo.policy (i.e. all features from old oslo-incubator copy is present in oslo.policy) -- dims On Mon, Aug 3, 2015 at 5:16 AM, Doug Hellmann d...@doughellmann.com wrote: Excerpts from Davanum Srinivas (dims)'s message of 2015-08-02

Re: [openstack-dev] [nova][oslo][policy] oslo.policy adoption in Nova.

2015-08-03 Thread Doug Hellmann
Excerpts from Sergey Vilgelm's message of 2015-08-03 19:05:52 +0300: If i understood correctly, the main difference is that the parse_rule function is a private now in the oslo.policy library, also Jeffrey Zhang has changed this function and put into nova.policy module. I offer remove this

Re: [openstack-dev] [nova][oslo][policy] oslo.policy adoption in Nova.

2015-08-03 Thread Sergey Vilgelm
On Mon, Aug 3, 2015 at 9:37 PM, Doug Hellmann d...@doughellmann.com wrote: Making that function public may be the most expedient fix, but the parser was made private for a reason, so before we expose it we should understand why, and if there are alternatives (such as creating a fixture in

Re: [openstack-dev] [nova][oslo][policy] oslo.policy adoption in Nova.

2015-08-03 Thread Doug Hellmann
Excerpts from Davanum Srinivas (dims)'s message of 2015-08-03 06:46:26 -0400: Doug, All the features needed for Nova to work is present in oslo.policy (i.e. all features from old oslo-incubator copy is present in oslo.policy) Great! I was worried that the copy local to nova had somehow been

Re: [openstack-dev] [nova][oslo][policy] oslo.policy adoption in Nova.

2015-08-03 Thread Doug Hellmann
Excerpts from Morgan Fainberg's message of 2015-08-04 06:05:56 +1000: On Aug 4, 2015, at 05:49, Doug Hellmann d...@doughellmann.com wrote: Excerpts from Sergey Vilgelm's message of 2015-08-03 22:11:50 +0300: On Mon, Aug 3, 2015 at 9:37 PM, Doug Hellmann d...@doughellmann.com wrote:

Re: [openstack-dev] [nova][oslo][policy] oslo.policy adoption in Nova.

2015-08-03 Thread Doug Hellmann
Excerpts from Sergey Vilgelm's message of 2015-08-03 22:11:50 +0300: On Mon, Aug 3, 2015 at 9:37 PM, Doug Hellmann d...@doughellmann.com wrote: Making that function public may be the most expedient fix, but the parser was made private for a reason, so before we expose it we should

Re: [openstack-dev] [nova][oslo][policy] oslo.policy adoption in Nova.

2015-08-03 Thread Morgan Fainberg
On Aug 4, 2015, at 05:49, Doug Hellmann d...@doughellmann.com wrote: Excerpts from Sergey Vilgelm's message of 2015-08-03 22:11:50 +0300: On Mon, Aug 3, 2015 at 9:37 PM, Doug Hellmann d...@doughellmann.com wrote: Making that function public may be the most expedient fix, but the parser