Re: [openstack-dev] [nova][placement] Add API Sample tests for Placement APIs

2017-07-07 Thread Chris Dent
On Fri, 7 Jul 2017, Chris Dent wrote: Thanks for sticking with this conversation and making your goals clear. Both of the pull requests were merged and there's now a new version of gabbi, 1.35.0, at: https://pypi.python.org/pypi/gabbi https://gabbi.readthedocs.io/en/latest/release.html#id1

Re: [openstack-dev] [nova][placement] Add API Sample tests for Placement APIs

2017-07-07 Thread Chris Dent
On Fri, 7 Jul 2017, Shewale, Bhagyashri wrote: Imagine one api with version x returning 5 attributes in a response and micro-version x.1 returning 6 attributes in a response and for some reasons there is a regression and the micro-version x starts returning 6 attributes instead of 5, then I

Re: [openstack-dev] [nova][placement] Add API Sample tests for Placement APIs

2017-07-07 Thread Shewale, Bhagyashri
questions) Subject: Re: [openstack-dev] [nova][placement] Add API Sample tests for Placement APIs Thanks for providing a bit more information on your goals, that helps shape my answers a bit more usefully. See within. On Wed, 5 Jul 2017, Shewale, Bhagyashri wrote: >>> So I'd sa

Re: [openstack-dev] [nova][placement] Add API Sample tests for Placement APIs

2017-07-05 Thread Chris Dent
Thanks for providing a bit more information on your goals, that helps shape my answers a bit more usefully. See within. On Wed, 5 Jul 2017, Shewale, Bhagyashri wrote: So I'd say the api is verified. What is missing, and could be useful, is using those tests to get accurate and up to date

Re: [openstack-dev] [nova][placement] Add API Sample tests for Placement APIs

2017-07-05 Thread Shewale, Bhagyashri
ual response. In the current master code, for a specific micro-version, if nova is returning extra parameters, then the gabbit test won't fail because it is only validating required attributes from the response. I think, this issue can be handled once we do strict validation of actual response with the

Re: [openstack-dev] [nova][placement] Add API Sample tests for Placement APIs

2017-06-23 Thread Chris Dent
On Thu, 22 Jun 2017, Shewale, Bhagyashri wrote: * who or what needs to consume these JSON samples? The users of placement API can rely on the request/response for different supported placement versions based on some tests running on the OpenStack CI infrastructure. Right now, most of the

Re: [openstack-dev] [nova][placement] Add API Sample tests for Placement APIs

2017-06-22 Thread Rochelle Grober
Thanks for the clarification. Yeah. No interop interaction to see here. These are not the api's you are looking for;-) I think Chris Dent's response about extending the gabbi based tests is great. I'm a firm believer in never discouraging anyone from writing more tests, especially when

Re: [openstack-dev] [nova][placement] Add API Sample tests for Placement APIs

2017-06-22 Thread Sean Dague
On 06/22/2017 01:22 PM, Matt Riedemann wrote: > Rocky, we have tests, we just don't have API samples for documentation > purposes like in the compute API reference docs. > > This doesn't have anything to do with interop guidelines, and it > wouldn't, since the Placement APIs are all admin-only

Re: [openstack-dev] [nova][placement] Add API Sample tests for Placement APIs

2017-06-22 Thread Matt Riedemann
On 6/21/2017 4:28 PM, Rochelle Grober wrote: From: Matt On 6/21/2017 7:04 AM, Shewale, Bhagyashri wrote: I would like to write functional tests to check the exact req/resp for each placement API for all supported versions similar to what is already done for other APIs under

Re: [openstack-dev] [nova][placement] Add API Sample tests for Placement APIs

2017-06-22 Thread Shewale, Bhagyashri
Sent: Thursday, June 22, 2017 3:00 PM To: OpenStack Development Mailing List (not for usage questions) Subject: Re: [openstack-dev] [nova][placement] Add API Sample tests for Placement APIs On Wed, 21 Jun 2017, Shewale, Bhagyashri wrote: > I would like to write functional tests to che

Re: [openstack-dev] [nova][placement] Add API Sample tests for Placement APIs

2017-06-22 Thread Chris Dent
On Wed, 21 Jun 2017, Shewale, Bhagyashri wrote: I would like to write functional tests to check the exact req/resp for each placement API for all supported versions similar to what is already done for other APIs under nova/tests/functional/api_sample_tests/api_samples/*. These

Re: [openstack-dev] [nova][placement] Add API Sample tests for Placement APIs

2017-06-21 Thread Rochelle Grober
> From: Matt > On 6/21/2017 7:04 AM, Shewale, Bhagyashri wrote: > > I would like to write functional tests to check the exact req/resp > > for each placement API for all supported versions similar > > > > to what is already done for other APIs under > >

Re: [openstack-dev] [nova][placement] Add API Sample tests for Placement APIs

2017-06-21 Thread Matt Riedemann
On 6/21/2017 7:04 AM, Shewale, Bhagyashri wrote: I would like to write functional tests to check the exact req/resp for each placement API for all supported versions similar to what is already done for other APIs under nova/tests/functional/api_sample_tests/api_samples/*. These