Re: [openstack-dev] [puppet] weekly meeting #59

2015-11-19 Thread Cody Herriges
Clayton O'Neill wrote: > On Tue, Nov 17, 2015 at 4:38 PM, Cody Herriges > wrote: > > Now that the standard is $::os_service_default does it mean that current > changes up for review with parameters set to the string ' DEFAULT>' should

Re: [openstack-dev] [puppet] weekly meeting #59

2015-11-17 Thread Emilien Macchi
We did our meeting: http://eavesdrop.openstack.org/meetings/puppet_openstack/2015/puppet_openstack.2015-11-17-15.00.html Thanks! Emilien On 11/16/2015 11:39 PM, Emilien Macchi wrote: > The second one. Sorry for confusion, I sent it from my phone. > > See you tomorrow! > --- > Emilien Macchi >

Re: [openstack-dev] [puppet] weekly meeting #59

2015-11-17 Thread Cody Herriges
Emilien Macchi wrote: > We did our meeting: > http://eavesdrop.openstack.org/meetings/puppet_openstack/2015/puppet_openstack.2015-11-17-15.00.html > Now that updates to the wiki doc "Coding_style" are happening, are we going to block patches that are already proposed that use the old "" pattern?

Re: [openstack-dev] [puppet] weekly meeting #59

2015-11-17 Thread Iury Gregory
Hi Cody, If there is patches using $::os_service_default and they are blocked, I think the owner just need to request removal and continue the work.( I think ) 2015-11-17 17:10 GMT-03:00 Cody Herriges : > Emilien Macchi wrote: > > We did our meeting: > > >

Re: [openstack-dev] [puppet] weekly meeting #59

2015-11-17 Thread Clayton O'Neill
On Tue, Nov 17, 2015 at 4:38 PM, Cody Herriges wrote: > Now that the standard is $::os_service_default does it mean that current > changes up for review with parameters set to the string ' DEFAULT>' should be changed to $::os_service_default before merge? > The decision was

Re: [openstack-dev] [puppet] weekly meeting #59

2015-11-17 Thread Cody Herriges
Iury Gregory wrote: > Hi Cody, > If there is patches using $::os_service_default and they are blocked, I > think the owner just need to request removal and continue the work.( I > think ) > Iury, Now that the standard is $::os_service_default does it mean that current changes up for review

Re: [openstack-dev] [puppet] weekly meeting #59

2015-11-16 Thread Iury Gregory
Hi Emilien, the link for the agenda is https://etherpad.openstack.org/p/puppet-openstack-weekly-meeting-2015111 or https://etherpad.openstack.org/p/puppet-openstack-weekly-meeting-20151117 ? Thanks o/ 2015-11-16 14:04 GMT-03:00 Emilien Macchi : > Hello! > > Here's an

Re: [openstack-dev] [puppet] weekly meeting #59

2015-11-16 Thread Emilien Macchi
The second one. Sorry for confusion, I sent it from my phone. See you tomorrow! --- Emilien Macchi On Nov 16, 2015 1:24 PM, "Iury Gregory" wrote: > Hi Emilien, the link for the agenda is > https://etherpad.openstack.org/p/puppet-openstack-weekly-meeting-2015111 > or >