Re: [openstack-dev] [tripleo] [tripleo-validations] using using top-level fact vars will deprecated in future Ansible versions

2018-07-27 Thread Sam Doran
> so if, for convenience, we do this: > vars: > a_mounts: "{{ hostvars[inventory_hostname].ansible_facts.mounts }}" > > That's completely acceptable and correct, and won't create any security > issue, right? Yes, that will work, but you don't need to use the hostvars dict. You can simply use

Re: [openstack-dev] [tripleo] [tripleo-validations] using using top-level fact vars will deprecated in future Ansible versions

2018-07-26 Thread Emilien Macchi
On Thu, Jul 26, 2018 at 12:30 PM John Fulton wrote: > Do we have a plan for which Ansible version might be the default in > upcoming TripleO versions? > > If this is the thread to discuss it then, I want to point out that > TripleO's been using ceph-ansible for Ceph integration on the client >

Re: [openstack-dev] [tripleo] [tripleo-validations] using using top-level fact vars will deprecated in future Ansible versions

2018-07-26 Thread John Fulton
On Thu, Jul 26, 2018 at 1:48 AM Cédric Jeanneret wrote: > > Hello Sam, > > Thanks for the clarifications. > > On 07/25/2018 07:46 PM, Sam Doran wrote: > > I spoke with other Ansible Core devs to get some clarity on this change. > > > > This is not a change that is being made quickly, lightly, or

Re: [openstack-dev] [tripleo] [tripleo-validations] using using top-level fact vars will deprecated in future Ansible versions

2018-07-25 Thread Cédric Jeanneret
Hello Sam, Thanks for the clarifications. On 07/25/2018 07:46 PM, Sam Doran wrote: > I spoke with other Ansible Core devs to get some clarity on this change. > > This is not a change that is being made quickly, lightly, or without a > whole of bunch of reservation. In fact, that PR created by

Re: [openstack-dev] [tripleo] [tripleo-validations] using using top-level fact vars will deprecated in future Ansible versions

2018-07-25 Thread Sam Doran
I spoke with other Ansible Core devs to get some clarity on this change. This is not a change that is being made quickly, lightly, or without a whole of bunch of reservation. In fact, that PR created by agaffney may not be merged any time soon. He just wanted to get something started and there

Re: [openstack-dev] [tripleo] [tripleo-validations] using using top-level fact vars will deprecated in future Ansible versions

2018-07-24 Thread Matt Young
I've captured this as a point of discussion for the TripleO CI Team's planning session(s). Matt On Tue, Jul 24, 2018 at 4:59 AM Bogdan Dobrelya wrote: > > On 7/23/18 9:33 PM, Emilien Macchi wrote: > > But it seems like, starting with Ansible 2.5 (what we already have in > > Rocky and beyond), we

Re: [openstack-dev] [tripleo] [tripleo-validations] using using top-level fact vars will deprecated in future Ansible versions

2018-07-24 Thread Bogdan Dobrelya
On 7/23/18 9:33 PM, Emilien Macchi wrote: But it seems like, starting with Ansible 2.5 (what we already have in Rocky and beyond), we should encourage the usage of ansible_facts dictionary. Example: var=hostvars[inventory_hostname].ansible_facts.hostname instead of: var=ansible_hostname If

Re: [openstack-dev] [tripleo] [tripleo-validations] using using top-level fact vars will deprecated in future Ansible versions

2018-07-23 Thread Cédric Jeanneret
On 07/23/2018 08:33 PM, Emilien Macchi wrote: > Thanks Monty for pointing that out to me today on #ansible-devel. > > Context: https://github.com/ansible/ansible/pull/41811 > The top-level fact vars are currently being deprecated in Ansible, maybe > 2.7. > It looks like it only affects