On Mon, Jun 24, 2013 at 10:50:18PM +0100, Mark McLoughlin wrote:
Hey,
Pulling this out of gerrit for discussion.
Background is one of my patches to diskimage-builder was -1ed because I
terminated the title line of the commit message with a period:
https://review.openstack.org/33262
On Mon, 2013-06-24 at 22:50 +0100, Mark McLoughlin wrote:
Hey,
Pulling this out of gerrit for discussion.
Background is one of my patches to diskimage-builder was -1ed because I
terminated the title line of the commit message with a period:
https://review.openstack.org/33262
This
On 06/24/2013 05:56 PM, Mark McLoughlin wrote:
On Mon, 2013-06-24 at 22:50 +0100, Mark McLoughlin wrote:
Hey,
Pulling this out of gerrit for discussion.
Background is one of my patches to diskimage-builder was -1ed because I
terminated the title line of the commit message with a period:
On 06/24/2013 06:15 PM, Monty Taylor wrote:
On 06/24/2013 05:56 PM, Mark McLoughlin wrote:
On Mon, 2013-06-24 at 22:50 +0100, Mark McLoughlin wrote:
Hey,
Pulling this out of gerrit for discussion.
Background is one of my patches to diskimage-builder was -1ed because I
terminated the title
On Mon, Jun 24, 2013 at 3:19 PM, Sean Dague s...@dague.net wrote:
On 06/24/2013 06:15 PM, Monty Taylor wrote:
On 06/24/2013 05:56 PM, Mark McLoughlin wrote:
On Mon, 2013-06-24 at 22:50 +0100, Mark McLoughlin wrote:
Hey,
Pulling this out of gerrit for discussion.
Background is one of
On 06/24/2013 06:19 PM, Sean Dague wrote:
On 06/24/2013 06:15 PM, Monty Taylor wrote:
On 06/24/2013 05:56 PM, Mark McLoughlin wrote:
On Mon, 2013-06-24 at 22:50 +0100, Mark McLoughlin wrote:
Hey,
Pulling this out of gerrit for discussion.
Background is one of my patches to
On Jun 24, 2013, at 2:50 PM, Mark McLoughlin wrote:
Unlike other nitpicking I tend to do with commit messages, I previously
never thought this was worth even mentioning to committers but if some
reviewers were going to start -1ing people for the *correct* style then
I figured it was best to
On Mon, Jun 24, 2013 at 5:36 PM, Christopher Yeoh cbky...@gmail.com wrote:
On Tue, Jun 25, 2013 at 7:56 AM, Joe Gordon joe.gord...@gmail.com wrote:
As long as it gets auto enforced in hacking, I'll adapt to whatever. I
admit I've been bleeding my first line to 72 characters recently as I
On 25 June 2013 15:34, Joe Gordon joe.gord...@gmail.com wrote:
This is exactly why we want a consensus, so we can automatically enforce it
without using any human resources (at least during the review process).
If we say we don't care, someone will come along and care. If we enforce
one
