Re: [openstack-dev] [neutron][horizon] FWaaS/VPNaaS dashboard split out from horizon

2017-06-01 Thread Itxaka Serrano Garcia


On 31/05/17 15:12, Akihiro Motoki wrote:

Hi all,

As discussed last month [1], we agree that each neutron-related
dashboard has its own repository.
I would like to move this forward on FWaaS and VPNaaS
as the horizon team plans to split them out as horizon plugins.

A couple of questions hit me.

(1) launchpad project
Do we create a new launchpad project for each dashboard?
At now, FWaaS and VPNaaS projects use 'neutron' for their bug tracking
from the historical reason, it sometimes There are two choices: the
one is to accept dashboard bugs in 'neutron' launchpad,
and the other is to have a separate launchpad project.

My vote is to create a separate launchpad project.
It allows users to search and file bugs easily.

+1


(2) repository name

Are neutron-fwaas-dashboard / neutron-vpnaas-dashboard good repository
names for you?
Most horizon related projects use -dashboard or -ui as their repo names.
I personally prefers to -dashboard as it is consistent with the
OpenStack dashboard
(the official name of horizon). On the other hand, I know some folks
prefer to -ui
as the name is shorter enough.
Any preference?


+1 for dashboard, it goes with the openstack-dashboard theme.


(3) governance
neutron-fwaas project is under the neutron project.
Does it sound okay to have neutron-fwaas-dashboard under the neutron project?
This is what the neutron team does for neutron-lbaas-dashboard before
and this model is adopted in most horizon plugins (like trove, sahara
or others).

+1

(4) initial core team

My thought is to have neutron-fwaas/vpnaas-core and horizon-core as
the initial core team.
The release team and the stable team follow what we have for
neutron-fwaas/vpnaas projects.
Sounds reasonable?

+1


Finally, I already prepare the split out version of FWaaS and VPNaaS
dashboards in my personal github repos.
Once we agree in the questions above, I will create the repositories
under git.openstack.org.

[1] 
http://lists.openstack.org/pipermail/openstack-dev/2017-April/thread.html#115200


Thank for doing this work!


__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev



__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


Re: [openstack-dev] [stable][horizon] feature freeze exception Logout user if he has no valid tokens for stable/Kilo

2016-05-04 Thread Itxaka Serrano Garcia

This is me asking for a feature freeze exception, sorry if it wasnt clear.

Itxaka

On 05/04/2016 12:11 PM, Itxaka Serrano Garcia wrote:

Link to the patch: https://review.openstack.org/#/c/304504/

Pros:
Only 13 lines of code (the rest is modifying the tests).
Resolves a very nasty end user experience issue which is not documented
anywhere.
Already merged on master since Liberty.

Cons:




Seems to me that its a low-risk/high-gain patchset.

Proposing it into the list as no consensus has been taken on the patch
itself and Kilo is going EOL.


Would also be good to get some explanations in case of refusal :)


thanks,
Itxaka

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


[openstack-dev] [stable][horizon] Logout user if he has no valid tokens for stable/Kilo

2016-05-04 Thread Itxaka Serrano Garcia

Link to the patch: https://review.openstack.org/#/c/304504/

Pros:
Only 13 lines of code (the rest is modifying the tests).
Resolves a very nasty end user experience issue which is not documented 
anywhere.

Already merged on master since Liberty.

Cons:




Seems to me that its a low-risk/high-gain patchset.

Proposing it into the list as no consensus has been taken on the patch 
itself and Kilo is going EOL.



Would also be good to get some explanations in case of refusal :)


thanks,
Itxaka

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


Re: [openstack-dev] [horizon] Set CSS style for each cell in Datatable according to the value

2016-04-14 Thread Itxaka Serrano Garcia
If Im reading the correct correctly, you can provide on your Table class 
in the Meta, a cell_class.


So you could create your custom Cell class that inherits from the normal 
Cell class (from horizon.tables.base import Cell), and based on the 
data, change the css before rendering?





On 04/14/2016 10:44 AM, 严超 wrote:

Hi, Everyone:
 Is there a possible way to set CSS style for*each cell* in
*DataTable* according to the value of the cell ? For example, if the
cell value is *'available' *then the css should display a *green icon*
as well, else if the cell value is *'error'* the the css should display
a *red icon*.
 What I found is horizon.tables*.*Columnoption:

classes

 An iterable of CSS classes which should be added to this
column. Example: classes=('foo', 'bar').

 But this sets all the column cell style.
 Is there a possible way to set CSS style for* each cell respectively?*
 I'm very grateful for answering.

/*Best Regards!*/
/*Chao Yan*
**--
About me : http://about.me/chao_yan/
//My twitter: @yanchao727 
/My Weibo: http://weibo.com/herewearenow
--/*/
/*


__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev



__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


Re: [openstack-dev] [Horizon][stable] proposing Rob Cresswell for Horizon stable core

2016-04-07 Thread Itxaka Serrano Garcia
Im still not sure if non-cores (i.e. peasants like me) can vote but I 
will do it anyway :D


A big +1 from me.

Itxaka

On 04/07/2016 12:01 PM, Matthias Runge wrote:

Hello,

I'm proposing Rob Cresswell to become stable core for Horizon. I
thought, in the past all PTL were in stable team, but this doesn't seem
to be true any more.

Please chime in with +1/-1



__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


Re: [openstack-dev] [Horizon] How do we move forward with xstatic releases?

2016-03-10 Thread Itxaka Serrano Garcia



On 03/10/2016 11:48 AM, Beth Elwell wrote:



On 10 Mar 2016, at 07:46, Richard Jones > wrote:

It has been mentioned, xstatic packages can block the gate. We
currently
control xstatic package releases, thus we can roll back, if something
goes wrong.

If we're pulling directly with npm/bower, someone from the outside can
break us. We already have the situation with pypi packages.
With proper packages, we could even use the gate to release those
packages and thus verify, we're not breaking anyone.


We're going to have potential breakage (gate breakage, in the
integrated tests) any time we release a package (regardless of release
mechanism) and have to update two separate repositories resulting in
out-of-sync version specification and expectation (ie.
upper-constraints specification and Horizon's code expectation) as
described in my OP. The only solution that we're aware of is to
synchronise updating those two things, through one of the mechanisms
proposed so far (or possibly through a mechanism not yet proposed.)


If we will anyway have potential breakage I don’t understand why the
better solution here would not be to just use the bower and npm tools
which are standardised for JavaScript and would move Horizon more
towards using widely recognised tooling from within not just Openstack
but the wider development community. Back versions always need to be
supported for a time, however I would add that long term this could end
up saving time and create a stable longer term solution.


__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org
?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev




__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev




npm/bower seems like the right tool for this instead of trying to 
convert everything to the python ecosystem.



And I dont understand the issues with plugins. They depend on a horizon 
version so they need to work with the js libraries that are provided by 
that version, same as with any python packages that horizon brings, they 
have to work with that, should not be a difference in there no?


Itxaka



__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


Re: [openstack-dev] [Horizon] Recent integration tests failures

2016-01-29 Thread Itxaka Serrano Garcia
Can confirm, had the same issue locally, was fixed after a downgrade to 
selenium 2.48.



Good catch!

Itxaka

On 01/28/2016 10:08 PM, Timur Sufiev wrote:

According to the results at
https://review.openstack.org/#/c/273697/1 capping Selenium to be not
greater than 2.49 fixes broken tests. Patch to global-requirements is
here: https://review.openstack.org/#/c/273750/

On Thu, Jan 28, 2016 at 9:22 PM Timur Sufiev > wrote:

Hello, Horizoneers

You may have noticed recent integration tests failures seemingly
unrelated to you patches, with a stacktrace like:
http://paste2.org/2Hk9138U I've already filed a bug for that,
https://bugs.launchpad.net/horizon/+bug/1539197 Appears to be a
Selenium issue, currently investigating it.




__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev



__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


Re: [openstack-dev] [Horizon] Email as User Name on the Horizon login page

2016-01-15 Thread Itxaka Serrano Garcia


Looks like the form comes from django_openstack_auth:
https://github.com/openstack/django_openstack_auth/blob/master/openstack_auth/forms.py#L53


But to be honest, no idea how that can be overridden trough the themes, 
not sure if its even possible to override anything on that page without 
modifying django_openstack_auth directly :(


Maybe someone else has a better insight on this than me.


* Horrible Hack Incoming, read at your own discretion *

You can override the template here:
https://github.com/openstack/horizon/blob/master/horizon/templates/horizon/common/_form_field.html#L51

And change this line:
{{ field.label }}


For this:
{% if field.label == "User Name" and not 
request.user.is_authenticated %}Email{% else %}{{ field.label }}{% endif 
%}



Which will check if the label is "User Name" and the user is logged out 
and directly write "Email" as the field label.


I know, its horrible and if you update horizon it will be overriden, but 
probably works for the time being if you really need it ¯\_(ツ)_/¯


* Horrible Hack Finished *




Itxaka




On 01/15/2016 05:13 AM, Adrian Turjak wrote:

I've run into a weird issue with the Liberty release of Horizon.

For our deployment we enforce emails as usernames, and thus for Horizon
we used to have "User Name" on the login page replaced with "Email".
This used to be a straightforward change in the html template file, and
with the introduction of themes we assumed it would be the same. When
one of our designers was migrating our custom CSS and html changes to
the new theme system they missed that change and I at first it was a
silly mistake.

Only on digging through the code myself I found that the "User Name" on
the login screen isn't in the html file at all, nor anywhere else
straightforward. The login page form is built on the fly with javascript
to facilitate different modes of authentication. While a bit annoying
that didn't seem too bad and I then assumed it might mean a javascript
change, only that the more I dug, the more I became confused.

Where exactly is the login form defined? And where exactly is the "User
Name" text for the login form set?

I've tried all manner of stuff to change it with no luck and I feel like
I must have missed something obvious.

Cheers,
-Adrian Turjak

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev



__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


Re: [openstack-dev] [Horizon] Routing in Horizon

2016-01-12 Thread Itxaka Serrano Garcia

> El 12 ene 2016, a las 11:22, Matthias Runge  escribió:
> 
> On 12/01/16 03:33, Richard Jones wrote:
>> The  tag addition has had to be reverted as it broke other parts
>> of the application (notably lazy loaded tabs like Instance Details), sadly.
>> 
>> Regarding which router to use - I've used the built-in router in the
>> past quite successfully. I think I'd want to see a solid reason for
>> using a 3rd party one. It could be that nested routes are part of that,
>> but I kinda see that as a convenience thing, unless I'm missing
>> something core to how routing is planned to be done. Then again we
>> really haven't had any discussion about how we see routing work. The one
>> patch that's up that uses routing seems perfectly able to do so without
>> needing extended capabilities of 3rd party routers.
> 
> I believe, there has been something else messing up with routing,
> causing pagination to be broken now.
> 
> https://launchpad.net/bugs/1532759
> 
> Unfortunately, that even hasn't been detected by tests.
> 
> Matthias
> 
> 
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Also see https://bugs.launchpad.net/horizon/+bug/1532265

Any link that has an href="#" is probably broken.

If I'm not mistaken, the # is what angular uses as locationprovider?

Itxaka
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


Re: [openstack-dev] [Horizon][stable] Horizon kilo gate fails due to testrepository dependency

2016-01-04 Thread Itxaka Serrano Garcia



Same issue on django_openstack_auth, kilo branch:

https://review.openstack.org/#/c/262778/


And same error too [0]:

2016-01-04 10:47:17.621 | Obtaining file:///opt/stack/new/keystone
2016-01-04 10:47:18.251 | Complete output from command python
setup.py egg_info:
2016-01-04 10:47:18.251 | ERROR:root:Error parsing
2016-01-04 10:47:18.251 | Traceback (most recent call last):
2016-01-04 10:47:18.251 |   File
"/usr/local/lib/python2.7/dist-packages/pbr/core.py", line 109, in pbr
2016-01-04 10:47:18.251 | attrs = util.cfg_to_args(path)
2016-01-04 10:47:18.251 |   File
"/usr/local/lib/python2.7/dist-packages/pbr/util.py", line 261, in
cfg_to_args
2016-01-04 10:47:18.251 | wrap_commands(kwargs)
2016-01-04 10:47:18.251 |   File
"/usr/local/lib/python2.7/dist-packages/pbr/util.py", line 482, in
wrap_commands
2016-01-04 10:47:18.251 | for cmd, _ in dist.get_command_list():
2016-01-04 10:47:18.251 |   File
"/usr/local/lib/python2.7/dist-packages/setuptools/dist.py", line 446,
in get_command_list
2016-01-04 10:47:18.251 | cmdclass = ep.resolve()
2016-01-04 10:47:18.251 |   File
"/usr/local/lib/python2.7/dist-packages/pkg_resources/__init__.py", line
2386, in resolve
2016-01-04 10:47:18.251 | module = __import__(self.module_name,
fromlist=['__name__'], level=0)
2016-01-04 10:47:18.251 |   File
"/usr/local/lib/python2.7/dist-packages/pbr/testr_command.py", line 47,
in 
2016-01-04 10:47:18.251 | from testrepository import commands
2016-01-04 10:47:18.251 | ImportError: No module named testrepository
2016-01-04 10:47:18.251 | error in setup command: Error parsing
/opt/stack/new/keystone/setup.cfg: ImportError: No module named
testrepository




[0]
http://logs.openstack.org/78/262778/2/check/gate-tempest-dsvm-neutron-src-django_openstack_auth/01220e8/logs/devstacklog.txt.gz


On 01/04/2016 09:13 AM, Matthias Runge wrote:

Hello,

did we had a recent change in stable tests for Kilo?

Horizon tests for kilo are now failing due to a missing dependency to
testrepository. Horizon never used testrepository (until recently,
where I added testr support, but only in mitaka branch).

As a test, I added a test dependency for kilo branch, but that fails
somewhere else due to missing testrepository:

https://review.openstack.org/#/c/262296/

The error is in [1] somewhere at the bottom:

É5-12-30 09:53:27.883 | Obtaining file:///opt/stack/new/keystone
2015-12-30 09:53:28.504 | Complete output from command python
setup.py egg_info:
2015-12-30 09:53:28.504 | ERROR:root:Error parsing
2015-12-30 09:53:28.504 | Traceback (most recent call last):
2015-12-30 09:53:28.504 |   File
"/usr/local/lib/python2.7/dist-packages/pbr/core.py", line 109, in pbr
2015-12-30 09:53:28.504 | attrs = util.cfg_to_args(path)
2015-12-30 09:53:28.504 |   File
"/usr/local/lib/python2.7/dist-packages/pbr/util.py", line 261, in
cfg_to_args
2015-12-30 09:53:28.504 | wrap_commands(kwargs)
2015-12-30 09:53:28.504 |   File
"/usr/local/lib/python2.7/dist-packages/pbr/util.py", line 482, in
wrap_commands
2015-12-30 09:53:28.504 | for cmd, _ in dist.get_command_list():
2015-12-30 09:53:28.504 |   File
"/usr/local/lib/python2.7/dist-packages/setuptools/dist.py", line 446,
in get_command_list
2015-12-30 09:53:28.504 | cmdclass = ep.resolve()
2015-12-30 09:53:28.505 |   File
"/usr/local/lib/python2.7/dist-packages/pkg_resources/__init__.py", line
2386, in resolve
2015-12-30 09:53:28.505 | module = __import__(self.module_name,
fromlist=['__name__'], level=0)
2015-12-30 09:53:28.505 |   File
"/usr/local/lib/python2.7/dist-packages/pbr/testr_command.py", line 47,
in 
2015-12-30 09:53:28.505 | from testrepository import commands
2015-12-30 09:53:28.505 | ImportError: No module named
testrepository
2015-12-30 09:53:28.505 | error in setup command: Error parsing
/opt/stack/new/keystone/setup.cfg: ImportError: No module named
testrepository

Any suggestions here?

[1]
http://logs.openstack.org/96/262296/2/check/gate-tempest-dsvm-full/e47e5c6/logs/devstacklog.txt.gz





__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev