Re: [openstack-dev] [nova] Metadata API cross joining "instance_metadata" and "instance_system_metadata"

2018-10-23 Thread Sergio A. de Carvalho Jr.
Make sense, Dan. Thanks so much for your help. Sergio On Tue, Oct 23, 2018 at 5:01 PM Dan Smith wrote: > > I tested a code change that essentially reverts > > https://review.openstack.org/#/c/276861/1/nova/api/metadata/base.py > > > > In other words, with this change metadata tables are not

Re: [openstack-dev] [nova] Metadata API cross joining "instance_metadata" and "instance_system_metadata"

2018-10-23 Thread Sergio A. de Carvalho Jr.
with this change. Do you guys see any other impact this change could have? Anything that it could potentially break? On Mon, Oct 22, 2018 at 10:05 PM Sergio A. de Carvalho Jr. < scarvalh...@gmail.com> wrote: > > https://bugs.launchpad.net/nova/+bug/1799298 > > On Mon, Oct 22, 2018 at 9:

Re: [openstack-dev] [nova] Metadata API cross joining "instance_metadata" and "instance_system_metadata"

2018-10-22 Thread Sergio A. de Carvalho Jr.
https://bugs.launchpad.net/nova/+bug/1799298 On Mon, Oct 22, 2018 at 9:15 PM Sergio A. de Carvalho Jr. < scarvalh...@gmail.com> wrote: > Cool, I'll open a bug then. > > I was wondering if, before joining the metadata tables with the rest of > instance data, we could do a UNION,

Re: [openstack-dev] [nova] Metadata API cross joining "instance_metadata" and "instance_system_metadata"

2018-10-22 Thread Sergio A. de Carvalho Jr.
Cool, I'll open a bug then. I was wondering if, before joining the metadata tables with the rest of instance data, we could do a UNION, since both tables are structurally identical. On Mon, Oct 22, 2018 at 9:04 PM Dan Smith wrote: > > Do you guys see an easy fix here? > > > > Should I open a

Re: [openstack-dev] [nova] Metadata API cross joining "instance_metadata" and "instance_system_metadata"

2018-10-22 Thread Sergio A. de Carvalho Jr.
Thanks so much for the replies, guys. > Have you debugged to the point of knowing where the initial DB query is starting from? > > Looking at history, my guess is this is the change which introduced it for all requests: > > https://review.openstack.org/#/c/276861/ That is my understanding too.

[openstack-dev] [nova] Metadata API cross joining "instance_metadata" and "instance_system_metadata"

2018-10-22 Thread Sergio A. de Carvalho Jr.
Hi, While troubleshooting a production issue we identified that the Nova metadata API is fetching a lot more raw data from the database than seems necessary. The problem appears to be caused by the SQL query used to fetch instance data that joins the "instance" table with, among others, two

[openstack-dev] [glance] Missing records in "image_locations" table

2016-11-30 Thread Sergio A. de Carvalho Jr.
Hi everyone, A while ago I reported some issues with Glance where image files went missing from the file system. Since then we implemented a monitoring script that regularly verifies the state of every active image in the Glance database, checking that: 1) it has a corresponding record in the

[openstack-dev] Missing records in Glance "image_locations" table

2016-11-29 Thread Sergio A. de Carvalho Jr.
Hi everyone, A while ago I reported some issues with Glance where image files went missing from the file system. Since then we implemented a monitoring script that regularly verifies the state of every active image in the Glance database, checking that: 1) it has a corresponding record in the

Re: [openstack-dev] [glance] Periodically checking Glance image files

2016-09-12 Thread Sergio A. de Carvalho Jr.
any gaps > in Glance. > > P.S. Please use the tag "[glance]" in the subject line to help us get to > your email faster. > > On 9/12/16 12:48 PM, Sergio A. de Carvalho Jr. wrote: > > Hi all, > > > > Is there (or was there ever) any plans to implement

[openstack-dev] Periodically checking Glance image files

2016-09-12 Thread Sergio A. de Carvalho Jr.
Hi all, Is there (or was there ever) any plans to implement in Glance a service that would periodically check that the image files are still available on the file system (or in whatever storage system being used) and have the correct checksum? We had a few issues where an image file was removed