Re: [openstack-dev] [Cinder] Is there anyone truly working on this issue https://bugs.launchpad.net/cinder/+bug/1520102?

2015-12-14 Thread Gorka Eguileor 
On 11/12, mtanino wrote:
> Hi Thang, Vincent,
> 
> I guess the root cause is that finish_volume_migration() still
> handles a volume as a dictionary instead of volume object and
> the method returns dict volume.
> 
> And then, 'rpcapi.delete_volume()' in migrate_volume_completion()
> tries to delete dict volume but it fails due to the following error.
> 

I believe that is not entirely correct, the issue is that
'finish_volume_migration' returns an ORM volume that then is passed by
'rpcapi.delete_volume' in the place of a Versioned Object Volume (this
is the recently added optional argument), so this is serialized and
deserialized as a normal dictionary (instead of as a VO dictionary), and
when the manager at the other end sees that it has received something in
the place of the VO Volume argument it tries to access the 'id'
attribute.

But since the ORM volume was not a VO it was passed as a normal
dictionary and therefore has no 'id' attribute.

For reference, Vincent has proposed a patch [1].

Cheers,
Gorka.

[1]: https://review.openstack.org/250216/

> >As far as you know, is there someone working on this issue? If not, I am 
> >gonna fix it.
> 
> Not yet. You can go ahead.
> 
> - Result of 'cinder migrate --force-host-copy True '
> 
> 2015-12-11 20:36:33.395 ERROR oslo_messaging.rpc.dispatcher 
> [req-2c271a5e-7e6a-4b38-97d1-22ef245c7892 f95ea885e1a34a81975c50be63444a0b 
> 56d8eb5cc90242178cf05aedab3c1612] Exception during message handling: 'dict' 
> object has no attribute 'id'
> 2015-12-11 20:36:33.395 TRACE oslo_messaging.rpc.dispatcher Traceback (most 
> recent call last):
> 2015-12-11 20:36:33.395 TRACE oslo_messaging.rpc.dispatcher   File 
> "/usr/lib/python2.7/site-packages/oslo_messaging/rpc/dispatcher.py", line 
> 142, in _dispatch_and_reply
> 2015-12-11 20:36:33.395 TRACE oslo_messaging.rpc.dispatcher 
> executor_callback))
> 2015-12-11 20:36:33.395 TRACE oslo_messaging.rpc.dispatcher   File 
> "/usr/lib/python2.7/site-packages/oslo_messaging/rpc/dispatcher.py", line 
> 186, in _dispatch
> 2015-12-11 20:36:33.395 TRACE oslo_messaging.rpc.dispatcher 
> executor_callback)
> 2015-12-11 20:36:33.395 TRACE oslo_messaging.rpc.dispatcher   File 
> "/usr/lib/python2.7/site-packages/oslo_messaging/rpc/dispatcher.py", line 
> 129, in _do_dispatch
> 2015-12-11 20:36:33.395 TRACE oslo_messaging.rpc.dispatcher result = 
> func(ctxt, **new_args)
> 2015-12-11 20:36:33.395 TRACE oslo_messaging.rpc.dispatcher   File 
> "/usr/lib/python2.7/site-packages/osprofiler/profiler.py", line 105, in 
> wrapper
> 2015-12-11 20:36:33.395 TRACE oslo_messaging.rpc.dispatcher return 
> f(*args, **kwargs)
> 2015-12-11 20:36:33.395 TRACE oslo_messaging.rpc.dispatcher   File 
> "/opt/stack/cinder/cinder/volume/manager.py", line 152, in lvo_inner1
> 2015-12-11 20:36:33.395 TRACE oslo_messaging.rpc.dispatcher return 
> lvo_inner2(inst, context, volume_id, **kwargs)
> 2015-12-11 20:36:33.395 TRACE oslo_messaging.rpc.dispatcher   File 
> "/usr/lib/python2.7/site-packages/oslo_concurrency/lockutils.py", line 271, 
> in inner
> 2015-12-11 20:36:33.395 TRACE oslo_messaging.rpc.dispatcher return 
> f(*args, **kwargs)
> 2015-12-11 20:36:33.395 TRACE oslo_messaging.rpc.dispatcher   File 
> "/opt/stack/cinder/cinder/volume/manager.py", line 151, in lvo_inner2
> 2015-12-11 20:36:33.395 TRACE oslo_messaging.rpc.dispatcher return 
> f(*_args, **_kwargs)
> 2015-12-11 20:36:33.395 TRACE oslo_messaging.rpc.dispatcher   File 
> "/opt/stack/cinder/cinder/volume/manager.py", line 603, in delete_volume
> 2015-12-11 20:36:33.395 TRACE oslo_messaging.rpc.dispatcher volume_id = 
> volume.id
> 2015-12-11 20:36:33.395 TRACE oslo_messaging.rpc.dispatcher AttributeError: 
> 'dict' object has no attribute 'id'
> 2015-12-11 20:36:33.395 TRACE oslo_messaging.rpc.dispatcher
> 
> Thanks,
> Mitsuhiro Tanino
> 
> On 12/10/2015 11:24 PM, Thang Pham wrote:
> >I have to try it again myself.  What errors are you seeing?  Is it the same? 
> > Feel free to post a patch if you already have one that would solve it.
> >
> >Regards,
> >Thang
> >
> >On Thu, Dec 10, 2015 at 10:51 PM, Sheng Bo Hou  >> wrote:
> >
> >Hi Mitsuhiro, Thang
> >
> >The patch https://review.openstack.org/#/c/228916is merged, but sadly it 
> > does not cover the issue https://bugs.launchpad.net/cinder/+bug/1520102. 
> > This bug is still valid.
> >As far as you know, is there someone working on this issue? If not, I am 
> > gonna fix it.
> >
> >Best wishes,
> >Vincent Hou (侯胜博)
> >
> >Staff Software Engineer, Open Standards and Open Source Team, Emerging 
> > Technology Institute, IBM China Software Development Lab
> >
> >Tel: 86-10-82450778 Fax: 86-10-82453660
> >Notes ID: Sheng Bo Hou/China/IBM@IBMCNE-mail: sb...@cn.ibm.com 
> > 
> >Address:3F Ring, Building 28 Zhongguancun Software Park, 8 Dongbeiwang 
> > West Road, Haidian District, Beijing,

Re: [openstack-dev] [Cinder] Is there anyone truly working on this issue https://bugs.launchpad.net/cinder/+bug/1520102?

2015-12-14 Thread mtanino 

Thank you for the explanation, Gorka!

Mitsuhiro

On 12/14/2015 05:00 AM, Gorka Eguileor wrote:

On 11/12, mtanino wrote:

Hi Thang, Vincent,

I guess the root cause is that finish_volume_migration() still
handles a volume as a dictionary instead of volume object and
the method returns dict volume.

And then, 'rpcapi.delete_volume()' in migrate_volume_completion()
tries to delete dict volume but it fails due to the following error.



I believe that is not entirely correct, the issue is that
'finish_volume_migration' returns an ORM volume that then is passed by
'rpcapi.delete_volume' in the place of a Versioned Object Volume (this
is the recently added optional argument), so this is serialized and
deserialized as a normal dictionary (instead of as a VO dictionary), and
when the manager at the other end sees that it has received something in
the place of the VO Volume argument it tries to access the 'id'
attribute.

But since the ORM volume was not a VO it was passed as a normal
dictionary and therefore has no 'id' attribute.

For reference, Vincent has proposed a patch [1].

Cheers,
Gorka.

[1]: https://review.openstack.org/250216/


As far as you know, is there someone working on this issue? If not, I am gonna 
fix it.


Not yet. You can go ahead.

- Result of 'cinder migrate --force-host-copy True '

2015-12-11 20:36:33.395 ERROR oslo_messaging.rpc.dispatcher 
[req-2c271a5e-7e6a-4b38-97d1-22ef245c7892 f95ea885e1a34a81975c50be63444a0b 
56d8eb5cc90242178cf05aedab3c1612] Exception during message handling: 'dict' 
object has no attribute 'id'
2015-12-11 20:36:33.395 TRACE oslo_messaging.rpc.dispatcher Traceback (most 
recent call last):
2015-12-11 20:36:33.395 TRACE oslo_messaging.rpc.dispatcher   File 
"/usr/lib/python2.7/site-packages/oslo_messaging/rpc/dispatcher.py", line 142, 
in _dispatch_and_reply
2015-12-11 20:36:33.395 TRACE oslo_messaging.rpc.dispatcher 
executor_callback))
2015-12-11 20:36:33.395 TRACE oslo_messaging.rpc.dispatcher   File 
"/usr/lib/python2.7/site-packages/oslo_messaging/rpc/dispatcher.py", line 186, 
in _dispatch
2015-12-11 20:36:33.395 TRACE oslo_messaging.rpc.dispatcher 
executor_callback)
2015-12-11 20:36:33.395 TRACE oslo_messaging.rpc.dispatcher   File 
"/usr/lib/python2.7/site-packages/oslo_messaging/rpc/dispatcher.py", line 129, 
in _do_dispatch
2015-12-11 20:36:33.395 TRACE oslo_messaging.rpc.dispatcher result = 
func(ctxt, **new_args)
2015-12-11 20:36:33.395 TRACE oslo_messaging.rpc.dispatcher   File 
"/usr/lib/python2.7/site-packages/osprofiler/profiler.py", line 105, in wrapper
2015-12-11 20:36:33.395 TRACE oslo_messaging.rpc.dispatcher return f(*args, 
**kwargs)
2015-12-11 20:36:33.395 TRACE oslo_messaging.rpc.dispatcher   File 
"/opt/stack/cinder/cinder/volume/manager.py", line 152, in lvo_inner1
2015-12-11 20:36:33.395 TRACE oslo_messaging.rpc.dispatcher return 
lvo_inner2(inst, context, volume_id, **kwargs)
2015-12-11 20:36:33.395 TRACE oslo_messaging.rpc.dispatcher   File 
"/usr/lib/python2.7/site-packages/oslo_concurrency/lockutils.py", line 271, in 
inner
2015-12-11 20:36:33.395 TRACE oslo_messaging.rpc.dispatcher return f(*args, 
**kwargs)
2015-12-11 20:36:33.395 TRACE oslo_messaging.rpc.dispatcher   File 
"/opt/stack/cinder/cinder/volume/manager.py", line 151, in lvo_inner2
2015-12-11 20:36:33.395 TRACE oslo_messaging.rpc.dispatcher return 
f(*_args, **_kwargs)
2015-12-11 20:36:33.395 TRACE oslo_messaging.rpc.dispatcher   File 
"/opt/stack/cinder/cinder/volume/manager.py", line 603, in delete_volume
2015-12-11 20:36:33.395 TRACE oslo_messaging.rpc.dispatcher volume_id = 
volume.id
2015-12-11 20:36:33.395 TRACE oslo_messaging.rpc.dispatcher AttributeError: 
'dict' object has no attribute 'id'
2015-12-11 20:36:33.395 TRACE oslo_messaging.rpc.dispatcher

Thanks,
Mitsuhiro Tanino

On 12/10/2015 11:24 PM, Thang Pham wrote:

I have to try it again myself.  What errors are you seeing?  Is it the same?  
Feel free to post a patch if you already have one that would solve it.

Regards,
Thang

On Thu, Dec 10, 2015 at 10:51 PM, Sheng Bo Hou > wrote:

Hi Mitsuhiro, Thang

The patch https://review.openstack.org/#/c/228916is merged, but sadly it 
does not cover the issue https://bugs.launchpad.net/cinder/+bug/1520102. This 
bug is still valid.
As far as you know, is there someone working on this issue? If not, I am 
gonna fix it.

Best wishes,
Vincent Hou (侯胜博)

Staff Software Engineer, Open Standards and Open Source Team, Emerging 
Technology Institute, IBM China Software Development Lab

Tel: 86-10-82450778 Fax: 86-10-82453660
Notes ID: Sheng Bo Hou/China/IBM@IBMCNE-mail: sb...@cn.ibm.com 

Address:3F Ring, Building 28 Zhongguancun Software Park, 8 Dongbeiwang West 
Road, Haidian District, Beijing, P.R.C.100193
地址:北京市海淀区东北旺西路8号中关村软件园28号楼环宇大厦3层 邮编：100193

Re: [openstack-dev] [Cinder] Is there anyone truly working on this issue https://bugs.launchpad.net/cinder/+bug/1520102?

2015-12-11 Thread mtanino 

Hi Thang, Vincent,

I guess the root cause is that finish_volume_migration() still
handles a volume as a dictionary instead of volume object and
the method returns dict volume.

And then, 'rpcapi.delete_volume()' in migrate_volume_completion()
tries to delete dict volume but it fails due to the following error.


As far as you know, is there someone working on this issue? If not, I am gonna 
fix it.


Not yet. You can go ahead.

- Result of 'cinder migrate --force-host-copy True '

2015-12-11 20:36:33.395 ERROR oslo_messaging.rpc.dispatcher 
[req-2c271a5e-7e6a-4b38-97d1-22ef245c7892 f95ea885e1a34a81975c50be63444a0b 
56d8eb5cc90242178cf05aedab3c1612] Exception during message handling: 'dict' 
object has no attribute 'id'
2015-12-11 20:36:33.395 TRACE oslo_messaging.rpc.dispatcher Traceback (most 
recent call last):
2015-12-11 20:36:33.395 TRACE oslo_messaging.rpc.dispatcher   File 
"/usr/lib/python2.7/site-packages/oslo_messaging/rpc/dispatcher.py", line 142, 
in _dispatch_and_reply
2015-12-11 20:36:33.395 TRACE oslo_messaging.rpc.dispatcher 
executor_callback))
2015-12-11 20:36:33.395 TRACE oslo_messaging.rpc.dispatcher   File 
"/usr/lib/python2.7/site-packages/oslo_messaging/rpc/dispatcher.py", line 186, 
in _dispatch
2015-12-11 20:36:33.395 TRACE oslo_messaging.rpc.dispatcher 
executor_callback)
2015-12-11 20:36:33.395 TRACE oslo_messaging.rpc.dispatcher   File 
"/usr/lib/python2.7/site-packages/oslo_messaging/rpc/dispatcher.py", line 129, 
in _do_dispatch
2015-12-11 20:36:33.395 TRACE oslo_messaging.rpc.dispatcher result = 
func(ctxt, **new_args)
2015-12-11 20:36:33.395 TRACE oslo_messaging.rpc.dispatcher   File 
"/usr/lib/python2.7/site-packages/osprofiler/profiler.py", line 105, in wrapper
2015-12-11 20:36:33.395 TRACE oslo_messaging.rpc.dispatcher return f(*args, 
**kwargs)
2015-12-11 20:36:33.395 TRACE oslo_messaging.rpc.dispatcher   File 
"/opt/stack/cinder/cinder/volume/manager.py", line 152, in lvo_inner1
2015-12-11 20:36:33.395 TRACE oslo_messaging.rpc.dispatcher return 
lvo_inner2(inst, context, volume_id, **kwargs)
2015-12-11 20:36:33.395 TRACE oslo_messaging.rpc.dispatcher   File 
"/usr/lib/python2.7/site-packages/oslo_concurrency/lockutils.py", line 271, in 
inner
2015-12-11 20:36:33.395 TRACE oslo_messaging.rpc.dispatcher return f(*args, 
**kwargs)
2015-12-11 20:36:33.395 TRACE oslo_messaging.rpc.dispatcher   File 
"/opt/stack/cinder/cinder/volume/manager.py", line 151, in lvo_inner2
2015-12-11 20:36:33.395 TRACE oslo_messaging.rpc.dispatcher return 
f(*_args, **_kwargs)
2015-12-11 20:36:33.395 TRACE oslo_messaging.rpc.dispatcher   File 
"/opt/stack/cinder/cinder/volume/manager.py", line 603, in delete_volume
2015-12-11 20:36:33.395 TRACE oslo_messaging.rpc.dispatcher volume_id = 
volume.id
2015-12-11 20:36:33.395 TRACE oslo_messaging.rpc.dispatcher AttributeError: 
'dict' object has no attribute 'id'
2015-12-11 20:36:33.395 TRACE oslo_messaging.rpc.dispatcher

Thanks,
Mitsuhiro Tanino

On 12/10/2015 11:24 PM, Thang Pham wrote:

I have to try it again myself.  What errors are you seeing?  Is it the same?  
Feel free to post a patch if you already have one that would solve it.

Regards,
Thang

On Thu, Dec 10, 2015 at 10:51 PM, Sheng Bo Hou > wrote:

Hi Mitsuhiro, Thang

The patch https://review.openstack.org/#/c/228916is merged, but sadly it 
does not cover the issue https://bugs.launchpad.net/cinder/+bug/1520102. This 
bug is still valid.
As far as you know, is there someone working on this issue? If not, I am 
gonna fix it.

Best wishes,
Vincent Hou (侯胜博)

Staff Software Engineer, Open Standards and Open Source Team, Emerging 
Technology Institute, IBM China Software Development Lab

Tel: 86-10-82450778 Fax: 86-10-82453660
Notes ID: Sheng Bo Hou/China/IBM@IBMCNE-mail: sb...@cn.ibm.com 

Address:3F Ring, Building 28 Zhongguancun Software Park, 8 Dongbeiwang West 
Road, Haidian District, Beijing, P.R.C.100193
地址:北京市海淀区东北旺西路8号中关村软件园28号楼环宇大厦3层 邮编：100193




__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev



__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

[openstack-dev] [Cinder] Is there anyone truly working on this issue https://bugs.launchpad.net/cinder/+bug/1520102?

2015-12-10 Thread Sheng Bo Hou 
Hi Mitsuhiro, Thang

The patch https://review.openstack.org/#/c/228916 is merged, but sadly it 
does not cover the issue https://bugs.launchpad.net/cinder/+bug/1520102. 
This bug is still valid.
As far as you know, is there someone working on this issue? If not, I am 
gonna fix it.

Best wishes,
Vincent Hou (侯胜博)

Staff Software Engineer, Open Standards and Open Source Team, Emerging 
Technology Institute, IBM China Software Development Lab

Tel: 86-10-82450778 Fax: 86-10-82453660
Notes ID: Sheng Bo Hou/China/IBM@IBMCNE-mail: sb...@cn.ibm.com 
Address:3F Ring, Building 28 Zhongguancun Software Park, 8 Dongbeiwang 
West Road, Haidian District, Beijing, P.R.C.100193
地址:北京市海淀区东北旺西路8号中关村软件园28号楼环宇大厦3层 邮编：100193

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [Cinder] Is there anyone truly working on this issue https://bugs.launchpad.net/cinder/+bug/1520102?

2015-12-10 Thread Thang Pham 
I have to try it again myself.  What errors are you seeing?  Is it the
same?  Feel free to post a patch if you already have one that would solve
it.

Regards,
Thang

On Thu, Dec 10, 2015 at 10:51 PM, Sheng Bo Hou  wrote:

> Hi Mitsuhiro, Thang
>
> The patch https://review.openstack.org/#/c/228916is merged, but sadly it
> does not cover the issue https://bugs.launchpad.net/cinder/+bug/1520102.
> This bug is still valid.
> As far as you know, is there someone working on this issue? If not, I am
> gonna fix it.
>
> Best wishes,
> Vincent Hou (侯胜博)
>
> Staff Software Engineer, Open Standards and Open Source Team, Emerging
> Technology Institute, IBM China Software Development Lab
>
> Tel: 86-10-82450778 Fax: 86-10-82453660
> Notes ID: Sheng Bo Hou/China/IBM@IBMCNE-mail: sb...@cn.ibm.com
> Address:3F Ring, Building 28 Zhongguancun Software Park, 8 Dongbeiwang
> West Road, Haidian District, Beijing, P.R.C.100193
> 地址:北京市海淀区东北旺西路8号中关村软件园28号楼环宇大厦3层 邮编：100193
>
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev