Re: [openstack-dev] [Neutron] DHCP configuration

[Germy Lure]

+1
common.config should be global and general while agent.config should be
local and related to the special back-end.
Maybe, we can add different prefix to the same option.

Germy

On Mon, Aug 31, 2015 at 11:13 PM, Kevin Benton  wrote:

> neutron.common.config should have general DHCP options that aren't
> specific to the reference DHCP agent. neutron.agent.dhcp.config should have
> all of the stuff specific to our agent and dnsmasq.
>
> On Mon, Aug 31, 2015 at 7:54 AM, Gal Sagie  wrote:
>
>> Hello all,
>>
>> I went over the code and noticed that we have default DHCP configuration
>> both in neutron/common/config.py  (dhcp_lease_duration , dns_domain and
>> dhcp_agent_notification)
>>
>> But also we have it in neutron/agent/dhcp/config.py (DHCP_AGENT_OPTS,
>> DHCP_OPTS)
>>
>> I think we should consider merging them (especially the agent
>> configuration)
>> into one place so it will be easier to find them.
>>
>> I will add a bug on myself to address that, anyone know if this was done
>> in purpose
>> for some reason, or anyone have other thoughts regarding this?
>>
>> Thanks
>> Gal.
>>
>>
>> __
>> OpenStack Development Mailing List (not for usage questions)
>> Unsubscribe:
>> openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>
>>
>
>
> --
> Kevin Benton
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
>
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

[openstack-dev] [Neutron] DHCP configuration

[Gal Sagie]

Hello all,

I went over the code and noticed that we have default DHCP configuration
both in neutron/common/config.py  (dhcp_lease_duration , dns_domain and
dhcp_agent_notification)

But also we have it in neutron/agent/dhcp/config.py (DHCP_AGENT_OPTS,
DHCP_OPTS)

I think we should consider merging them (especially the agent configuration)
into one place so it will be easier to find them.

I will add a bug on myself to address that, anyone know if this was done in
purpose
for some reason, or anyone have other thoughts regarding this?

Thanks
Gal.
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [Neutron] DHCP configuration

[Kevin Benton]

neutron.common.config should have general DHCP options that aren't specific
to the reference DHCP agent. neutron.agent.dhcp.config should have all of
the stuff specific to our agent and dnsmasq.

On Mon, Aug 31, 2015 at 7:54 AM, Gal Sagie  wrote:

> Hello all,
>
> I went over the code and noticed that we have default DHCP configuration
> both in neutron/common/config.py  (dhcp_lease_duration , dns_domain and
> dhcp_agent_notification)
>
> But also we have it in neutron/agent/dhcp/config.py (DHCP_AGENT_OPTS,
> DHCP_OPTS)
>
> I think we should consider merging them (especially the agent
> configuration)
> into one place so it will be easier to find them.
>
> I will add a bug on myself to address that, anyone know if this was done
> in purpose
> for some reason, or anyone have other thoughts regarding this?
>
> Thanks
> Gal.
>
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
>


-- 
Kevin Benton
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev