Re: [openstack-dev] [cinder]pylint errors with hashlib

2014-08-29 Thread Ivan Kolodyazhny
Already done by xing-yang: https://review.openstack.org/#/c/117685/.

Thanks for raising this topic.

Regards,
Ivan Kolodyazhny,
Software Engineer,
Mirantis Inc.

On Fri, Aug 29, 2014 at 7:40 AM, John Griffith john.griff...@solidfire.com
wrote:




 On Mon, Aug 25, 2014 at 8:47 PM, Clark Boylan cboy...@sapwetik.org
 wrote:

 On Mon, Aug 25, 2014, at 06:45 PM, Murali Balcha wrote:
  Pylint on my patch is failing with the following error:
 
  Module 'hashlib' has no 'sha256'
 
  Cinder pylint already has following exceptions,
 
 
  pylint_exceptions:[Instance of 'sha1' has no 'update' member, ]
 
  pylint_exceptions:[Module 'hashlib' has no 'sha224' member, ]
 
 
  So I think hashlib has no 'sha256' should be added to the exception
  list as well. How can I update the exception list?
 
 
  Thanks,
 
  Murali Balcha
  ___
  OpenStack-dev mailing list
  OpenStack-dev@lists.openstack.org
  http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

 I think this may be related to your install of python. Mine does not
 have this problem.

 $ python
 Python 2.7.6 (default, Mar 22 2014, 22:59:56)
 [GCC 4.8.2] on linux2
 Type help, copyright, credits or license for more information.
  import hashlib
  hashlib.sha256
 built-in function openssl_sha256
  hashlib.sha224
 built-in function openssl_sha224
  s = hashlib.sha1()
  s.update('somestring')
 

 You should not need to treat these as acceptable failures.

 Clark

 ___
 OpenStack-dev mailing list
 OpenStack-dev@lists.openstack.org
 http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

 ​
 The error pointed out by Murali is actually showing up in the gate [1].  I
 think adding the pylint exception is fine in this case.

 [1]:
 http://logs.openstack.org/68/110068/8/check/gate-cinder-pylint/8c6813d/console.html
 ​


 ___
 OpenStack-dev mailing list
 OpenStack-dev@lists.openstack.org
 http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


Re: [openstack-dev] [cinder]pylint errors with hashlib

2014-08-28 Thread John Griffith
On Mon, Aug 25, 2014 at 8:47 PM, Clark Boylan cboy...@sapwetik.org wrote:

 On Mon, Aug 25, 2014, at 06:45 PM, Murali Balcha wrote:
  Pylint on my patch is failing with the following error:
 
  Module 'hashlib' has no 'sha256'
 
  Cinder pylint already has following exceptions,
 
 
  pylint_exceptions:[Instance of 'sha1' has no 'update' member, ]
 
  pylint_exceptions:[Module 'hashlib' has no 'sha224' member, ]
 
 
  So I think hashlib has no 'sha256' should be added to the exception
  list as well. How can I update the exception list?
 
 
  Thanks,
 
  Murali Balcha
  ___
  OpenStack-dev mailing list
  OpenStack-dev@lists.openstack.org
  http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

 I think this may be related to your install of python. Mine does not
 have this problem.

 $ python
 Python 2.7.6 (default, Mar 22 2014, 22:59:56)
 [GCC 4.8.2] on linux2
 Type help, copyright, credits or license for more information.
  import hashlib
  hashlib.sha256
 built-in function openssl_sha256
  hashlib.sha224
 built-in function openssl_sha224
  s = hashlib.sha1()
  s.update('somestring')
 

 You should not need to treat these as acceptable failures.

 Clark

 ___
 OpenStack-dev mailing list
 OpenStack-dev@lists.openstack.org
 http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

​
The error pointed out by Murali is actually showing up in the gate [1].  I
think adding the pylint exception is fine in this case.

[1]:
http://logs.openstack.org/68/110068/8/check/gate-cinder-pylint/8c6813d/console.html
​
___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


[openstack-dev] [cinder]pylint errors with hashlib

2014-08-25 Thread Murali Balcha
Pylint on my patch is failing with the following error:

Module 'hashlib' has no 'sha256'

Cinder pylint already has following exceptions,


pylint_exceptions:[Instance of 'sha1' has no 'update' member, ]

pylint_exceptions:[Module 'hashlib' has no 'sha224' member, ]


So I think hashlib has no 'sha256' should be added to the exception list as 
well. How can I update the exception list?


Thanks,

Murali Balcha
___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


Re: [openstack-dev] [cinder]pylint errors with hashlib

2014-08-25 Thread Clark Boylan
On Mon, Aug 25, 2014, at 06:45 PM, Murali Balcha wrote:
 Pylint on my patch is failing with the following error:
 
 Module 'hashlib' has no 'sha256'
 
 Cinder pylint already has following exceptions,
 
 
 pylint_exceptions:[Instance of 'sha1' has no 'update' member, ]
 
 pylint_exceptions:[Module 'hashlib' has no 'sha224' member, ]
 
 
 So I think hashlib has no 'sha256' should be added to the exception
 list as well. How can I update the exception list?
 
 
 Thanks,
 
 Murali Balcha
 ___
 OpenStack-dev mailing list
 OpenStack-dev@lists.openstack.org
 http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

I think this may be related to your install of python. Mine does not
have this problem.

$ python
Python 2.7.6 (default, Mar 22 2014, 22:59:56) 
[GCC 4.8.2] on linux2
Type help, copyright, credits or license for more information.
 import hashlib
 hashlib.sha256
built-in function openssl_sha256
 hashlib.sha224
built-in function openssl_sha224
 s = hashlib.sha1()
 s.update('somestring')
 

You should not need to treat these as acceptable failures.

Clark

___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev