Re: [openstack-dev] [fuel] [FFE] FF Exception request for Custom node attributes feature

2015-07-24 Thread Mike Scherbakov
Colleagues, it sounds like we need to complete what was requested by Julia here (and it would take about a day as I understand), plus Andrey's request (which seems to be very important for partner story and flexibility), plus additional pieces which turned into bugs [1]. I'd like to hear opinion

Re: [openstack-dev] [fuel] [FFE] FF Exception request for Custom node attributes feature

2015-07-24 Thread Igor Kalnitsky
Fuelers, I'm ok to go with CLI part of this story. It's already implemented and was actively reviewed yesterday. As for labels serialisation to astute.yaml.. I don't know it seems pretty easy to implement, but we must be strict and do not accept any exceptions because it's easy to implement.

Re: [openstack-dev] [fuel] [FFE] FF Exception request for Custom node attributes feature

2015-07-24 Thread Andrey Danin
I apologize for my hasty email earlier. Thank you all who tried to help me but I have to revoke my additions to this feature. I completely missed the fact that labels may be changed after the deployment is done. It creates inconsistency between label values and actual values in astute.yaml on the

Re: [openstack-dev] [fuel] [FFE] FF Exception request for Custom node attributes feature

2015-07-24 Thread Roman Prykhodchenko
+1 to merging the CLI part, if all our comments there are filed as High priority bugs and then fixed ASAP - romcheg 24 лип. 2015 о 07:58 Mike Scherbakov mscherba...@mirantis.com написав(ла): Colleagues, it sounds like we need to complete what was requested by Julia here (and it would

Re: [openstack-dev] [fuel] [FFE] FF Exception request for Custom node attributes feature

2015-07-24 Thread Julia Aranovich
The fuelclient request was merged with all needed +1s. Known issues are filed to Launchpad: https://bugs.launchpad.net/fuel/+bugs?field.tag=feature-node-labels-cli So, we'll have a support of custom node labels both in Fuel UI and CLI in 7.0. Thank you guys all who contributed to the feature and

Re: [openstack-dev] [fuel] [FFE] FF Exception request for Custom node attributes feature

2015-07-23 Thread Andrey Danin
Hi, folks. I understand it may be not a good time but I want to make a proposal regarding this feature. The feature may be extremely useful for plugin developers if these labels would be serialized into astute.yaml. They may be used by plugin tasks to do node-specific modifications. Let me

[openstack-dev] [fuel] [FFE] FF Exception request for Custom node attributes feature

2015-07-23 Thread Julia Aranovich
Team, I would like to request an exception from the Feature Freeze for CLI changes of working with custom node labels added to fuelclient (fuel2) [1]. UI and Nailgun parts of the story are already merged [2]. There CLI request is being actively reviewed, the base flow is accepted. There are

Re: [openstack-dev] [fuel] [FFE] FF Exception request for Custom node attributes feature

2015-07-23 Thread Julia Aranovich
Mike, thanks for the important points you've provided. My main argument for this FFE is the following: we've already got a confirmation from SME for this patch. But also got some not critical comments at the last minute before we were going to merge it and have to handle it now. But it looks that

Re: [openstack-dev] [fuel] [FFE] FF Exception request for Custom node attributes feature

2015-07-23 Thread Mike Scherbakov
-1 My concerns are the following: 1. This feature is of a High priority, not Essential [1] 2. We already had to give exception for flexible networking CLI part [2], as it is essential one. So basically that means we have a conflict of focus for SMEs in the area. 3. Just by working

Re: [openstack-dev] [fuel] [FFE] FF Exception request for Custom node attributes feature

2015-07-23 Thread Igor Kalnitsky
Hi Julia, I'm ok with FF exception for CLI part. I don't think it can somehow decrease product quality, so as a core I'll help to land it. Thanks, Igor On Thu, Jul 23, 2015 at 7:50 PM, Julia Aranovich jkirnos...@mirantis.com wrote: Team, I would like to request an exception from the Feature

Re: [openstack-dev] [fuel] [FFE] FF Exception request for Custom node attributes feature

2015-07-23 Thread Sebastian Kalinowski
+1 for this FFE as it's important to have this functionality covered in CLI 2015-07-23 19:46 GMT+02:00 Igor Kalnitsky ikalnit...@mirantis.com: Hi Julia, I'm ok with FF exception for CLI part. I don't think it can somehow decrease product quality, so as a core I'll help to land it. Thanks,