Re: [openstack-dev] [ironic] AttributeError: 'GitReviewException' object has no attribute 'EXIT_CODE'

[Yuriy Taraday]

Hello, Malhar.

It seems that the actual error is hidden behind ""-like lines. Judging by line numbers in traceback that is
seen, you're using version 1.25.0, and there I can see how the error got
away:
https://github.com/openstack-infra/git-review/blob/1.25.0/git_review/cmd.py#L768

Can you edit file /usr/local/lib/python2.7/dist-packages/git_review/cmd.py
adding something like "import traceback; traceback.print_exc()" before or
after that line? It should provide some to what error does git-review get
when it tries to contact Gerrit.

On Sun, Jul 26, 2015 at 5:33 PM Malhar Vora  wrote:

> Hi Jeremy,
>
> I have signed agreement on https://review.openstack.org/. That is not a
> problem. 
>
> On Sun, Jul 26, 2015 at 7:25 PM, Jeremy Stanley  wrote:
>
>> On 2015-07-26 02:53:30 -0700 (-0700), Malhar Vora wrote:
>> > I have done everything from scratch and followed below step.
>> >
>> > Please check and tell me what is missing,
>> [...]
>> > 3. Created account in https://review.openstack.org and updated contact
>> > details
>> [...]
>>
>> There's a related step you've skipped here. From our instructions:
>>
>> "agree to the Individual Contributor License Agreement" at
>> https://review.openstack.org/#/settings/agreements
>>
>> I expect that's the problem, but don't have time to check the ICLA
>> signers group membership right now to confirm.
>>
>> > 6. Installed git-review using apt-get install git-review
>> [...]
>> > We don't know where your gerrit is. Please manually create a remote
>> > named "gerrit" and try again.
>> > Could not connect to gerrit at ssh://
>> > malhar_v...@review.openstack.org:29418/openstack/ironic.git
>> [...]
>>
>> This is likely obscuring the actual error. Chances are the version
>> of git-review in your distribution is misinterpreting the lack of a
>> signed CLA during its test push as a failure to connect to Gerrit.
>> This was a known issue in one or more releases of the utility. More
>> recent versions (1.25.0 certainly, maybe 1.24 as well but I'm having
>> trouble tracking down exactly which commit improved that situation)
>> are clearer about this and you'll actually see the CLA or contact
>> info errors rather than a misleading error about SSH credentials.
>> 
>>
>
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [ironic] AttributeError: 'GitReviewException' object has no attribute 'EXIT_CODE'

[Malhar Vora]

Hi Jeremy,

I have signed agreement on https://review.openstack.org/. That is not a
problem.


Thanks,


Regds,
*Malhar Vora*
http://about.me/malhar.vora


On Sun, Jul 26, 2015 at 7:25 PM, Jeremy Stanley  wrote:

> On 2015-07-26 02:53:30 -0700 (-0700), Malhar Vora wrote:
> > I have done everything from scratch and followed below step.
> >
> > Please check and tell me what is missing,
> [...]
> > 3. Created account in https://review.openstack.org and updated contact
> > details
> [...]
>
> There's a related step you've skipped here. From our instructions:
>
> "agree to the Individual Contributor License Agreement" at
> https://review.openstack.org/#/settings/agreements
>
> I expect that's the problem, but don't have time to check the ICLA
> signers group membership right now to confirm.
>
> > 6. Installed git-review using apt-get install git-review
> [...]
> > We don't know where your gerrit is. Please manually create a remote
> > named "gerrit" and try again.
> > Could not connect to gerrit at ssh://
> > malhar_v...@review.openstack.org:29418/openstack/ironic.git
> [...]
>
> This is likely obscuring the actual error. Chances are the version
> of git-review in your distribution is misinterpreting the lack of a
> signed CLA during its test push as a failure to connect to Gerrit.
> This was a known issue in one or more releases of the utility. More
> recent versions (1.25.0 certainly, maybe 1.24 as well but I'm having
> trouble tracking down exactly which commit improved that situation)
> are clearer about this and you'll actually see the CLA or contact
> info errors rather than a misleading error about SSH credentials.
> --
> Jeremy Stanley
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
>
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [ironic] AttributeError: 'GitReviewException' object has no attribute 'EXIT_CODE'

[Jeremy Stanley]

On 2015-07-26 02:53:30 -0700 (-0700), Malhar Vora wrote:
> I have done everything from scratch and followed below step.
> 
> Please check and tell me what is missing,
[...]
> 3. Created account in https://review.openstack.org and updated contact
> details
[...]

There's a related step you've skipped here. From our instructions:

"agree to the Individual Contributor License Agreement" at
https://review.openstack.org/#/settings/agreements

I expect that's the problem, but don't have time to check the ICLA
signers group membership right now to confirm.

> 6. Installed git-review using apt-get install git-review
[...]
> We don't know where your gerrit is. Please manually create a remote
> named "gerrit" and try again.
> Could not connect to gerrit at ssh://
> malhar_v...@review.openstack.org:29418/openstack/ironic.git
[...]

This is likely obscuring the actual error. Chances are the version
of git-review in your distribution is misinterpreting the lack of a
signed CLA during its test push as a failure to connect to Gerrit.
This was a known issue in one or more releases of the utility. More
recent versions (1.25.0 certainly, maybe 1.24 as well but I'm having
trouble tracking down exactly which commit improved that situation)
are clearer about this and you'll actually see the CLA or contact
info errors rather than a misleading error about SSH credentials.
-- 
Jeremy Stanley


signature.asc
Description: Digital signature
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [ironic] AttributeError: 'GitReviewException' object has no attribute 'EXIT_CODE'

[Malhar Vora]

Hi,

I have done everything from scratch and followed below step.

Please check and tell me what is missing,

1. git clone https://github.com/openstack/ironic ironic

2. Applied my changes

3. Created account in https://review.openstack.org and updated contact
details

4. Generated key using ssh-keygen -t rsa without passphase

5. Added content of ~/.ssh/id_rsa.pub to https://review.openstack.org

6. Installed git-review using apt-get install git-review

7. Added modified files using git add .

8. Set name, email and gerrit username as given below:
   git config --global user.name "Malhar Vora"
   git config --global user.email "mlvora.2...@gmail.com"
   git config --global gitreview.username malhar_vora

9. I execute git review -s and again get following.
   malhar@ubuntu:~/Documents/contribution/ironic$ git review -s
Using global/system git-review config files
(/etc/git-review/git-review.conf) is deprecated
Could not connect to gerrit.
Enter your gerrit username: malhar_vora
Trying again with ssh://
malhar_v...@review.openstack.org:29418/openstack/ironic.git

We don't know where your gerrit is. Please manually create a remote
named "gerrit" and try again.
Could not connect to gerrit at ssh://
malhar_v...@review.openstack.org:29418/openstack/ironic.git
Traceback (most recent call last):
  File "/usr/local/bin/git-review", line 11, in 
sys.exit(main())
  File "/usr/local/lib/python2.7/dist-packages/git_review/cmd.py", line
1534, in main
sys.exit(e.EXIT_CODE)
AttributeError: 'GitReviewException' object has no attribute 'EXIT_CODE'



Thanks,

Malhar

Regds,
*Malhar Vora*
http://about.me/malhar.vora


On Sat, Jul 25, 2015 at 12:50 PM, Jeremy Stanley  wrote:

> On 2015-07-25 07:39:31 -0700 (-0700), Malhar Vora wrote:
> [...]
> > error: Could not fetch gerrit
> > Problems encountered installing commit-msg hook
> > The following command failed with exit code 1
> > "scp -P29418 malhar_v...@review.openstack.org:hooks/commit-msg
> > .git/hooks/commit-msg"
> > ---
> > Agent admitted failure to sign using the key.
> > Permission denied (publickey).
> > ---
>
> This error message implies that either your username or SSH key are
> invalid. I'm guessing you got past this because I'm seeing
> successful authentication for your username in our Gerrit logs now.
>
> However, you don't appear to have entered contact information, at
> https://review.openstack.org/#/settings/contact so if you're trying
> to submit a change to a repo which requires CLA agreement (for
> example, openstack/ironic) then that will be necessary for you as
> well.
>
> For reference, our account setup documentation is available at:
>
> http://docs.openstack.org/infra/manual/developers.html#account-setup
>
> --
> Jeremy Stanley
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
>
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [ironic] AttributeError: 'GitReviewException' object has no attribute 'EXIT_CODE'

[Jeremy Stanley]

On 2015-07-25 07:39:31 -0700 (-0700), Malhar Vora wrote:
[...]
> error: Could not fetch gerrit
> Problems encountered installing commit-msg hook
> The following command failed with exit code 1
> "scp -P29418 malhar_v...@review.openstack.org:hooks/commit-msg
> .git/hooks/commit-msg"
> ---
> Agent admitted failure to sign using the key.
> Permission denied (publickey).
> ---

This error message implies that either your username or SSH key are
invalid. I'm guessing you got past this because I'm seeing
successful authentication for your username in our Gerrit logs now.

However, you don't appear to have entered contact information, at
https://review.openstack.org/#/settings/contact so if you're trying
to submit a change to a repo which requires CLA agreement (for
example, openstack/ironic) then that will be necessary for you as
well.

For reference, our account setup documentation is available at:

http://docs.openstack.org/infra/manual/developers.html#account-setup

-- 
Jeremy Stanley


signature.asc
Description: Digital signature
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [ironic] AttributeError: 'GitReviewException' object has no attribute 'EXIT_CODE'

[Jeremy Stanley]

On 2015-07-25 11:22:38 +0100 (+0100), Lucas Alvares Gomes wrote:
> Apparently you don't have the git remote map to review.openstack.org,
> you can add it by running the following:
> 
> $ git remote add gerrit
> ssh://malhar_...@review.openstack.org:29418/openstack/ironic.git

This should not _ever_ be necessary with git-review. IF git-review
is able to authenticate to Gerrit, it will add the remote
automatically. The actual problem here is an authentication failure.
Please never recommend this as a workaround, it only increases
confusion.
-- 
Jeremy Stanley


signature.asc
Description: Digital signature
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [ironic] AttributeError: 'GitReviewException' object has no attribute 'EXIT_CODE'

[Malhar Vora]

Hi Lucas,

Yes my username is malhar_vora.

I have tried steps that you have mentioned but still facing issue.

malhar@ubuntu:~/Documents/contribution/temp/ironic$ git review -s
Using global/system git-review config files
(/etc/git-review/git-review.conf) is deprecated
Problem running 'git remote update gerrit'
Fetching gerrit
Agent admitted failure to sign using the key.
Permission denied (publickey).
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
error: Could not fetch gerrit
Problems encountered installing commit-msg hook
The following command failed with exit code 1
"scp -P29418 malhar_v...@review.openstack.org:hooks/commit-msg
.git/hooks/commit-msg"
---
Agent admitted failure to sign using the key.
Permission denied (publickey).
---



Regds,
*Malhar Vora*
http://about.me/malhar.vora


On Sat, Jul 25, 2015 at 5:53 AM, Lucas Alvares Gomes 
wrote:

> Hi,
>
> > Please make sure you have the correct access rights
> > and the repository exists.
> > error: Could not fetch gerrit
> > Problems encountered installing commit-msg hook
> > The following command failed with exit code 1
> > "scp -P29418 malhar_...@review.openstack.org:hooks/commit-msg
> > .git/hooks/commit-msg"
>
> Sorry it's probably the typo in the command I gave you. Your username
> is "malhar_vora" not "malhar_vor", correct ?
>
> Try:
>
> $ git remote remove gerrit
> $ git remote add gerrit
> ssh://malhar_v...@review.openstack.org:29418/openstack/ironic.git
>
> Cheers,
> Lucas
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [ironic] AttributeError: 'GitReviewException' object has no attribute 'EXIT_CODE'

[Lucas Alvares Gomes]

Hi,

> Please make sure you have the correct access rights
> and the repository exists.
> error: Could not fetch gerrit
> Problems encountered installing commit-msg hook
> The following command failed with exit code 1
> "scp -P29418 malhar_...@review.openstack.org:hooks/commit-msg
> .git/hooks/commit-msg"

Sorry it's probably the typo in the command I gave you. Your username
is "malhar_vora" not "malhar_vor", correct ?

Try:

$ git remote remove gerrit
$ git remote add gerrit
ssh://malhar_v...@review.openstack.org:29418/openstack/ironic.git

Cheers,
Lucas

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [ironic] AttributeError: 'GitReviewException' object has no attribute 'EXIT_CODE'

[Malhar Vora]

Hi Lucas,

I have followed steps you mentioned. I am getting following issue now.

malhar@ubuntu:~/Documents/contribution/temp/ironic$ git review -s
Using global/system git-review config files
(/etc/git-review/git-review.conf) is deprecated
Problem running 'git remote update gerrit'
Fetching gerrit
Permission denied (publickey).
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
error: Could not fetch gerrit
Problems encountered installing commit-msg hook
The following command failed with exit code 1
"scp -P29418 malhar_...@review.openstack.org:hooks/commit-msg
.git/hooks/commit-msg"
---
Permission denied (publickey).
---


I have generated ssh key and added same to gerrit twice but still facing
this issue.

Thanks,

Malhar

Regds,
*Malhar Vora*
http://about.me/malhar.vora


On Sat, Jul 25, 2015 at 3:22 AM, Lucas Alvares Gomes 
wrote:

> Hi,
>
> > malhar@ubuntu:~/Documents/contribution/temp/ironic$ git review -s
> > Using global/system git-review config files
> > (/etc/git-review/git-review.conf) is deprecated
> > Could not connect to gerrit.
> > Enter your gerrit username: myusername
> > Trying again with
> > ssh://malhar_v...@review.openstack.org:29418/openstack/ironic.git
> > 
> > We don't know where your gerrit is. Please manually create a remote
> > named "gerrit" and try again.
> > Could not connect to gerrit at
> > ssh://malhar_v...@review.openstack.org:29418/openstack/ironic.git
> > Traceback (most recent call last):
> >   File "/usr/local/bin/git-review", line 11, in 
> > sys.exit(main())
> >   File "/usr/local/lib/python2.7/dist-packages/git_review/cmd.py", line
> > 1534, in main
> > sys.exit(e.EXIT_CODE)
> > AttributeError: 'GitReviewException' object has no attribute 'EXIT_CODE'
> >
>
> Apparently you don't have the git remote map to review.openstack.org,
> you can add it by running the following:
>
> $ git remote add gerrit
> ssh://malhar_...@review.openstack.org:29418/openstack/ironic.git
>
> Cheers,
> Lucas
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [ironic] AttributeError: 'GitReviewException' object has no attribute 'EXIT_CODE'

[Lucas Alvares Gomes]

Hi,

> malhar@ubuntu:~/Documents/contribution/temp/ironic$ git review -s
> Using global/system git-review config files
> (/etc/git-review/git-review.conf) is deprecated
> Could not connect to gerrit.
> Enter your gerrit username: myusername
> Trying again with
> ssh://malhar_v...@review.openstack.org:29418/openstack/ironic.git
> 
> We don't know where your gerrit is. Please manually create a remote
> named "gerrit" and try again.
> Could not connect to gerrit at
> ssh://malhar_v...@review.openstack.org:29418/openstack/ironic.git
> Traceback (most recent call last):
>   File "/usr/local/bin/git-review", line 11, in 
> sys.exit(main())
>   File "/usr/local/lib/python2.7/dist-packages/git_review/cmd.py", line
> 1534, in main
> sys.exit(e.EXIT_CODE)
> AttributeError: 'GitReviewException' object has no attribute 'EXIT_CODE'
>

Apparently you don't have the git remote map to review.openstack.org,
you can add it by running the following:

$ git remote add gerrit
ssh://malhar_...@review.openstack.org:29418/openstack/ironic.git

Cheers,
Lucas

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

[openstack-dev] [ironic] AttributeError: 'GitReviewException' object has no attribute 'EXIT_CODE'

[Malhar Vora]

Hi all,


I am a beginner and facing issue in committing code to gerrit. Following
are my details.

Operating system is Ubuntu 15.04

I have installed OpenStack usinff DevStack :
http://docs.openstack.org/developer/devstack/

I did changes, added modified file and then did git review -s
I am facing following issue when I do

*git review -s*malhar@ubuntu:~/Documents/contribution/temp/ironic$ git
review -s
Using global/system git-review config files
(/etc/git-review/git-review.conf) is deprecated
Could not connect to gerrit.
Enter your gerrit username: myusername
Trying again with ssh://
malhar_v...@review.openstack.org:29418/openstack/ironic.git

We don't know where your gerrit is. Please manually create a remote
named "gerrit" and try again.
Could not connect to gerrit at ssh://
malhar_v...@review.openstack.org:29418/openstack/ironic.git
Traceback (most recent call last):
  File "/usr/local/bin/git-review", line 11, in 
sys.exit(main())
  File "/usr/local/lib/python2.7/dist-packages/git_review/cmd.py", line
1534, in main
sys.exit(e.EXIT_CODE)
AttributeError: 'GitReviewException' object has no attribute 'EXIT_CODE'


I followed
*http://docs.openstack.org/infra/manual/developers.html#development-workflow
.*

I tried reinstalling git-review using both pip and apt-get

Please guide me for this issue.,


Thanks,

Regds,
*Malhar Vora*
http://about.me/malhar.vora
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev