Re: [openstack-dev] [nova][api] Is this a potential issue

2013-11-18 Thread yunhong jiang
On Mon, 2013-11-18 at 10:18 -0500, Andrew Laski wrote: > On 11/15/13 at 04:01pm, yunhong jiang wrote: > >On Fri, 2013-11-15 at 17:19 -0500, Andrew Laski wrote: > >If yes, would it be possible to create a special task_state as IDLE, to > >distinguish it better? When no task on-going, the task_state

Re: [openstack-dev] [nova][api] Is this a potential issue

2013-11-18 Thread Andrew Laski
On 11/15/13 at 04:01pm, yunhong jiang wrote: On Fri, 2013-11-15 at 17:19 -0500, Andrew Laski wrote: On 11/15/13 at 07:30am, Dan Smith wrote: >> You're not missing anything. But I think that's a bug, or at least an >> unexpected change in behaviour from how it used to work. If you follow >> ins

Re: [openstack-dev] [nova][api] Is this a potential issue

2013-11-15 Thread yunhong jiang
On Fri, 2013-11-15 at 17:19 -0500, Andrew Laski wrote: > On 11/15/13 at 07:30am, Dan Smith wrote: > >> You're not missing anything. But I think that's a bug, or at least an > >> unexpected change in behaviour from how it used to work. If you follow > >> instance_update() in nova.db.sqlalchemy.api

Re: [openstack-dev] [nova][api] Is this a potential issue

2013-11-15 Thread Andrew Laski
On 11/15/13 at 07:30am, Dan Smith wrote: You're not missing anything. But I think that's a bug, or at least an unexpected change in behaviour from how it used to work. If you follow instance_update() in nova.db.sqlalchemy.api just the presence of expected_task_state triggers the check. So we m

Re: [openstack-dev] [nova][api] Is this a potential issue

2013-11-15 Thread Jiang, Yunhong
> -Original Message- > From: Dan Smith [mailto:d...@danplanet.com] > Sent: Friday, November 15, 2013 7:30 AM > To: OpenStack Development Mailing List (not for usage questions); > isaku.yamah...@gmail.com > Subject: Re: [openstack-dev] [nova][api] Is this a potential i

Re: [openstack-dev] [nova][api] Is this a potential issue

2013-11-15 Thread Dan Smith
> You're not missing anything. But I think that's a bug, or at least an > unexpected change in behaviour from how it used to work. If you follow > instance_update() in nova.db.sqlalchemy.api just the presence of > expected_task_state triggers the check. So we may need to find a way to > pass tha

Re: [openstack-dev] [nova][api] Is this a potential issue

2013-11-15 Thread Andrew Laski
gt;>From: Jiang, Yunhong [mailto:yunhong.ji...@intel.com] >>Sent: Thursday, November 07, 2013 5:39 PM >>To: openstack-dev@lists.openstack.org >>Subject: [openstack-dev] [nova][api] Is this a potential issue >> >>Hi, all >>I'm a bit confused of followe

Re: [openstack-dev] [nova][api] Is this a potential issue

2013-11-15 Thread Isaku Yamahata
rom: Jiang, Yunhong [mailto:yunhong.ji...@intel.com] > >>Sent: Thursday, November 07, 2013 5:39 PM > >>To: openstack-dev@lists.openstack.org > >>Subject: [openstack-dev] [nova][api] Is this a potential issue > >> > >>Hi, all > >>I'm a bi

Re: [openstack-dev] [nova][api] Is this a potential issue

2013-11-14 Thread Jiang, Yunhong
> > The migration shouldn't end up being set to 'reverting' twice because of > the expected_task_state set and check in > instance.save(expected_task_state=None). The quota reservation could > happen twice, so a rollback in the case of a failure in instance.save > could be good. A patch uploaded

Re: [openstack-dev] [nova][api] Is this a potential issue

2013-11-12 Thread Jiang, Yunhong
> -Original Message- > From: Andrew Laski [mailto:andrew.la...@rackspace.com] > Sent: Tuesday, November 12, 2013 12:07 PM > To: OpenStack Development Mailing List (not for usage questions) > Subject: Re: [openstack-dev] [nova][api] Is this a potential issue > > O

Re: [openstack-dev] [nova][api] Is this a potential issue

2013-11-12 Thread Andrew Laski
: [openstack-dev] [nova][api] Is this a potential issue Hi, all I'm a bit confused of followed code in ./compute/api.py, which will be invoked by api/openstack/compute/servers.py, _action_revert_resize(). From the code seems there is a small windows between get the migration o

Re: [openstack-dev] [nova][api] Is this a potential issue

2013-11-11 Thread Jiang, Yunhong
Resend after the HK summit, hope someone can give me hint on it. Thanks --jyh > -Original Message- > From: Jiang, Yunhong [mailto:yunhong.ji...@intel.com] > Sent: Thursday, November 07, 2013 5:39 PM > To: openstack-dev@lists.openstack.org > Subject: [openstack-dev] [nova]

[openstack-dev] [nova][api] Is this a potential issue

2013-11-07 Thread Jiang, Yunhong
Hi, all I'm a bit confused of followed code in ./compute/api.py, which will be invoked by api/openstack/compute/servers.py, _action_revert_resize(). From the code seems there is a small windows between get the migration object and update migration.status. If another API request c