Re: [openstack-dev] [nova][api] quota-class-show not sync to quota-show
On Tue, Apr 11, 2017 at 1:21 PM, Matt Riedemann wrote: > On 4/11/2017 2:52 AM, Alex Xu wrote: > >> We talked about remove the quota-class API for multiple times >> (http://lists.openstack.org/pipermail/openstack-dev/2016-July/099218.html >> ) >> >> I guess we can deprecate the entire quota-class API directly. >> >> > I had a spec proposed to deprecate the os-quota-class-sets API [1] but it > was abandoned since we discussed it at the Pike PTG and decided we would > just leave it alone until Nova was getting limits information from Keystone > [2]. > FWIW - in addition to merging the conceptual document [0], Sean recently proposed the limits interface [1] for the keystone bits. [0] http://specs.openstack.org/openstack/keystone-specs/specs/keystone/ongoing/unified-limits.htm [1] https://review.openstack.org/#/c/455709/ > > I think the reason we probably missed this API was because of the really > roundabout way that the information is provided in the response. It calls > the quota engine driver [3] to get the class quotas. For the DB driver if > nothing is overridden then nothing comes back here [4]. And the resources > in the quota driver have a default property which is based on the config > options [5]. So we'll return quotas on floating_ips and other proxy > resources simply because of how abstract this all is. > > To fix it, the os-quota-class-sets API would have to maintain a blacklist > of resources to exclude from the response, like what we do for limits [6]. > > So yeah, I guess we'd need a new spec and microversion for this. > > [1] https://review.openstack.org/#/c/411035/ > [2] https://review.openstack.org/#/c/440815/ > [3] https://github.com/openstack/nova/blob/15.0.0/nova/api/opens > tack/compute/quota_classes.py#L67 > [4] https://github.com/openstack/nova/blob/15.0.0/nova/quota.py#L92 > [5] https://github.com/openstack/nova/blob/15.0.0/nova/quota.py#L1069 > [6] https://github.com/openstack/nova/blob/15.0.0/nova/api/opens > tack/compute/views/limits.py#L20 > > -- > > Thanks, > > Matt > > > __ > OpenStack Development Mailing List (not for usage questions) > Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [nova][api] quota-class-show not sync to quota-show
On 4/11/2017 2:52 AM, Alex Xu wrote: We talked about remove the quota-class API for multiple times (http://lists.openstack.org/pipermail/openstack-dev/2016-July/099218.html) I guess we can deprecate the entire quota-class API directly. I had a spec proposed to deprecate the os-quota-class-sets API [1] but it was abandoned since we discussed it at the Pike PTG and decided we would just leave it alone until Nova was getting limits information from Keystone [2]. I think the reason we probably missed this API was because of the really roundabout way that the information is provided in the response. It calls the quota engine driver [3] to get the class quotas. For the DB driver if nothing is overridden then nothing comes back here [4]. And the resources in the quota driver have a default property which is based on the config options [5]. So we'll return quotas on floating_ips and other proxy resources simply because of how abstract this all is. To fix it, the os-quota-class-sets API would have to maintain a blacklist of resources to exclude from the response, like what we do for limits [6]. So yeah, I guess we'd need a new spec and microversion for this. [1] https://review.openstack.org/#/c/411035/ [2] https://review.openstack.org/#/c/440815/ [3] https://github.com/openstack/nova/blob/15.0.0/nova/api/openstack/compute/quota_classes.py#L67 [4] https://github.com/openstack/nova/blob/15.0.0/nova/quota.py#L92 [5] https://github.com/openstack/nova/blob/15.0.0/nova/quota.py#L1069 [6] https://github.com/openstack/nova/blob/15.0.0/nova/api/openstack/compute/views/limits.py#L20 -- Thanks, Matt __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [nova][api] quota-class-show not sync to quota-show
We talked about remove the quota-class API for multiple times ( http://lists.openstack.org/pipermail/openstack-dev/2016-July/099218.html) I guess we can deprecate the entire quota-class API directly. 2017-04-07 18:19 GMT+08:00 Chen CH Ji : > Version 2.35 removed most deprecated output like floating ip etc so we > won't have following in quota-show output > | floating_ips | 10 | > | fixed_ips | -1 | > | security_groups | 10 | > | security_group_rules | 20 | > > however, quota-class-show still have those output, should we use 2.35 to > fix this bug or add a new microversion or because os-quota-class-sets is > about to deprecate, we can let it be ? Thanks > > DEBUG (session:347) REQ: curl -g -i -X GET http://192.168.123.10:8774/v2. > 1/os-quota-class-sets/1 -H "OpenStack-API-Version: compute 2.41" -H > "User-Agent: python-novaclient" -H "Accept: application/json" -H > "X-OpenStack-Nova-API-Version: 2.41" -H "X-Auth-Token: {SHA1} > 5008bb2787a9548d65b063f4db2525b4e3bf7163" > > RESP BODY: {"quota_class_set": {"injected_file_content_bytes": 10240, > "metadata_items": 128, "ram": 51200, "floating_ips": 10, "key_pairs": 100, > "id": "1", "instances": 10, "security_group_rules": 20, "injected_files": > 5, "cores": 20, "fixed_ips": -1, "injected_file_path_bytes": 255, > "security_groups": 10}} > > Best Regards! > > Kevin (Chen) Ji 纪 晨 > > Engineer, zVM Development, CSTL > Notes: Chen CH Ji/China/IBM@IBMCN Internet: jiche...@cn.ibm.com > Phone: +86-10-82451493 <010%208245%201493> > Address: 3/F Ring Building, ZhongGuanCun Software Park, Haidian District, > Beijing 100193, PRC > > __ > OpenStack Development Mailing List (not for usage questions) > Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > > __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
[openstack-dev] [nova][api] quota-class-show not sync to quota-show
Version 2.35 removed most deprecated output like floating ip etc so we won't have following in quota-show output | floating_ips| 10| | fixed_ips | -1| | security_groups | 10| | security_group_rules| 20| however, quota-class-show still have those output, should we use 2.35 to fix this bug or add a new microversion or because os-quota-class-sets is about to deprecate, we can let it be ? Thanks DEBUG (session:347) REQ: curl -g -i -X GET http://192.168.123.10:8774/v2.1/os-quota-class-sets/1 -H "OpenStack-API-Version: compute 2.41" -H "User-Agent: python-novaclient" -H "Accept: application/json" -H "X-OpenStack-Nova-API-Version: 2.41" -H "X-Auth-Token: {SHA1}5008bb2787a9548d65b063f4db2525b4e3bf7163" RESP BODY: {"quota_class_set": {"injected_file_content_bytes": 10240, "metadata_items": 128, "ram": 51200, "floating_ips": 10, "key_pairs": 100, "id": "1", "instances": 10, "security_group_rules": 20, "injected_files": 5, "cores": 20, "fixed_ips": -1, "injected_file_path_bytes": 255, "security_groups": 10}} Best Regards! Kevin (Chen) Ji 纪 晨 Engineer, zVM Development, CSTL Notes: Chen CH Ji/China/IBM@IBMCN Internet: jiche...@cn.ibm.com Phone: +86-10-82451493 Address: 3/F Ring Building, ZhongGuanCun Software Park, Haidian District, Beijing 100193, PRC __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev