Re: [openstack-dev] [nova] When can/should we change additionalProperties=False in GET /servers(/detail)?

2018-09-19 Thread Ghanshyam Mann
On Wed, 19 Sep 2018 02:26:30 +0900 Matt Riedemann wrote > On 9/17/2018 9:41 PM, Ghanshyam Mann wrote: > > On Tue, 18 Sep 2018 09:33:30 +0900 Alex Xu wrote > > > > > That only means after 599276 we only have servers API and > > os-instance-action API stopped

Re: [openstack-dev] [nova] When can/should we change additionalProperties=False in GET /servers(/detail)?

2018-09-19 Thread Matt Riedemann
On 9/18/2018 12:26 PM, Matt Riedemann wrote: On 9/17/2018 9:41 PM, Ghanshyam Mann wrote:   On Tue, 18 Sep 2018 09:33:30 +0900 Alex Xu wrote   > That only means after 599276 we only have servers API and os-instance-action API stopped accepting the undefined query parameter.   > What

Re: [openstack-dev] [nova] When can/should we change additionalProperties=False in GET /servers(/detail)?

2018-09-18 Thread Matt Riedemann
On 9/17/2018 9:41 PM, Ghanshyam Mann wrote: On Tue, 18 Sep 2018 09:33:30 +0900 Alex Xu wrote > That only means after 599276 we only have servers API and os-instance-action API stopped accepting the undefined query parameter. > What I'm thinking about is checking all the APIs,

Re: [openstack-dev] [nova] When can/should we change additionalProperties=False in GET /servers(/detail)?

2018-09-17 Thread Ghanshyam Mann
On Tue, 18 Sep 2018 09:33:30 +0900 Alex Xu wrote > That only means after 599276 we only have servers API and os-instance-action > API stopped accepting the undefined query parameter. > What I'm thinking about is checking all the APIs, add json-query-param > checking with

Re: [openstack-dev] [nova] When can/should we change additionalProperties=False in GET /servers(/detail)?

2018-09-17 Thread Alex Xu
That only means after 599276 we only have servers API and os-instance-action API stopped accepting the undefined query parameter. What I'm thinking about is checking all the APIs, add json-query-param checking with additionalProperties=True if the API don't have yet. And using another

Re: [openstack-dev] [nova] When can/should we change additionalProperties=False in GET /servers(/detail)?

2018-09-17 Thread Matt Riedemann
On 9/17/2018 3:06 PM, Jay Pipes wrote: My vote would be just change additionalProperties to False in the 599276 patch and be done with it. Well, it would be on a microversion boundary so the user would be opting into this stricter validation, but that's the point of microversions. So my

Re: [openstack-dev] [nova] When can/should we change additionalProperties=False in GET /servers(/detail)?

2018-09-17 Thread Jay Pipes
On 09/17/2018 03:28 PM, Matt Riedemann wrote: This is a question from a change [1] which adds a new changes-before filter to the servers, os-instance-actions and os-migrations APIs. For context, the os-instance-actions API stopped accepting undefined query parameters in 2.58 when we added

[openstack-dev] [nova] When can/should we change additionalProperties=False in GET /servers(/detail)?

2018-09-17 Thread Matt Riedemann
This is a question from a change [1] which adds a new changes-before filter to the servers, os-instance-actions and os-migrations APIs. For context, the os-instance-actions API stopped accepting undefined query parameters in 2.58 when we added paging support. The os-migrations API stopped