Re: [openstack-dev] [nova] Why is osapi_v3.enabled = False by default?
On 7/16/2015 4:57 AM, Sean Dague wrote: On 07/15/2015 08:12 PM, GHANSHYAM MANN wrote: On Thu, Jul 16, 2015 at 3:03 AM, Sean Dague wrote: On 07/15/2015 01:44 PM, Matt Riedemann wrote: The osapi_v3.enabled option is False by default [1] even though it's marked as the CURRENT API and the v2 API is marked as SUPPORTED (and we've frozen it for new feature development). I got looking at this because osapi_v3.enabled is True in nova.conf in both the check-tempest-dsvm-nova-v21-full job and non-v21 check-tempest-dsvm-full job, but only in the v21 job is "x-openstack-nova-api-version: '2.1'" used. Shouldn't the v2.1 API be enabled by default now? [1] http://git.openstack.org/cgit/openstack/nova/tree/nova/api/openstack/__init__.py#n44 Honestly, we should probably deprecate out osapi_v3.enabled make it osapi_v21 (or osapi_v2_microversions) so as to not confuse people further. Nice Catch. We might have just forgot to make it default to True. How about just deprecating it and remove in N and makes v21 enable all the time (irrespective of osapi_v3.enabled) as they are current now. Yeh, that's probably a fine approach as well. I don't think we need an option any more here. -Sean OK, I'll push up a change, thanks everyone! -- Thanks, Matt Riedemann __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [nova] Why is osapi_v3.enabled = False by default?
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On 07/16/2015 03:27 AM, Alex Xu wrote: > >> Honestly, we should probably deprecate out osapi_v3.enabled make >> it osapi_v21 (or osapi_v2_microversions) so as to not confuse >> people further. > > +1 for renaming it to osapi_v21 (or osapi_v2_microversions). > > > Why we still need this option? Agreed - it isn't needed anymore. - -- - -- Ed Leafe -BEGIN PGP SIGNATURE- Version: GnuPG v2 Comment: GPGTools - https://gpgtools.org Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBCgAGBQJVp7fGAAoJEKMgtcocwZqL0McP/3BZZoRUiMr0YhSNAgaNXziu HaJVXYiB8Aui/9ixtKDmO/4JL6lhjAgV2b2JMWce2rJxTLtDCoJBpZ2tUOVejlaH 5qvJjLeU2r3wPUphoF/3G/Q0ABaCKbgz/J6duJFOjH2YaHfHs1qEwsDjrmN3MZ4n Ir6HMqKyo94bg5tGPAkcvxVX55G9RVjbLWojMH/4GEklzNekoKcOVWzCoSS1bQ9J JLjiZfF7mrqAVkO24xljcM95Obpl2iToNsdcmqUOtobJb9KvV5SRQ8p9QTh9TDhj pQg0RHbTqdxv3RE6QyhoSTdeOj+trorIj3gVUu4xcMcJnDCcVIeoxociXVhK70bk e8j4/q90ILGrAz701I7XjPfzKl6UQxjjGRHsCIXGsMnPFg3oENziuD4PvscRhrsj iFqBFMUD4j2jdIbm7MaHzmj5rrtl56rAcsrbdFXSu3HwdJzxnchRFHd2M6ExoQJ1 u2kfaev+sUdVzkoOL26GIV2GG4nC+4gE4Qy4ScRj0Ib+2VhnldNdKqhnGmh5WgGB sEqOrZ03Qqc3VGwTJK/9RuMkkAvDN6ny76kQGeKUDcMggJdbwqTFyy3iEba9O23U UQPr+mK2uwy5s5HFtdudMe2tUQ5YXikXde+y549Y1UmoN3dcBB7Pjvn6+TbC9tE7 QBjLDJX92bp6T3sL8asE =e3dk -END PGP SIGNATURE- __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [nova] Why is osapi_v3.enabled = False by default?
On 07/15/2015 08:12 PM, GHANSHYAM MANN wrote: > On Thu, Jul 16, 2015 at 3:03 AM, Sean Dague wrote: >> On 07/15/2015 01:44 PM, Matt Riedemann wrote: >>> The osapi_v3.enabled option is False by default [1] even though it's >>> marked as the CURRENT API and the v2 API is marked as SUPPORTED (and >>> we've frozen it for new feature development). >>> >>> I got looking at this because osapi_v3.enabled is True in nova.conf in >>> both the check-tempest-dsvm-nova-v21-full job and non-v21 >>> check-tempest-dsvm-full job, but only in the v21 job is >>> "x-openstack-nova-api-version: '2.1'" used. >>> >>> Shouldn't the v2.1 API be enabled by default now? >>> >>> [1] >>> http://git.openstack.org/cgit/openstack/nova/tree/nova/api/openstack/__init__.py#n44 >> >> Honestly, we should probably deprecate out osapi_v3.enabled make it >> osapi_v21 (or osapi_v2_microversions) so as to not confuse people further. >> > > Nice Catch. We might have just forgot to make it default to True. > > How about just deprecating it and remove in N and makes v21 enable all > the time (irrespective of osapi_v3.enabled) as they are current now. Yeh, that's probably a fine approach as well. I don't think we need an option any more here. -Sean -- Sean Dague http://dague.net __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [nova] Why is osapi_v3.enabled = False by default?
FYI, this should be part work of https://github.com/openstack/nova-specs/blob/master/specs/liberty/approved/nova-api-remove-v3.rst 2015-07-16 16:27 GMT+08:00 Alex Xu : > > > 2015-07-16 7:54 GMT+08:00 Ken'ichi Ohmichi : > >> 2015-07-16 3:03 GMT+09:00 Sean Dague : >> > On 07/15/2015 01:44 PM, Matt Riedemann wrote: >> >> The osapi_v3.enabled option is False by default [1] even though it's >> >> marked as the CURRENT API and the v2 API is marked as SUPPORTED (and >> >> we've frozen it for new feature development). >> >> >> >> I got looking at this because osapi_v3.enabled is True in nova.conf in >> >> both the check-tempest-dsvm-nova-v21-full job and non-v21 >> >> check-tempest-dsvm-full job, but only in the v21 job is >> >> "x-openstack-nova-api-version: '2.1'" used. >> >> >> >> Shouldn't the v2.1 API be enabled by default now? >> >> >> >> [1] >> >> >> http://git.openstack.org/cgit/openstack/nova/tree/nova/api/openstack/__init__.py#n44 >> >> Oops, nice catch. >> Yeah, we need to make the default enabled. >> >> > Honestly, we should probably deprecate out osapi_v3.enabled make it >> > osapi_v21 (or osapi_v2_microversions) so as to not confuse people >> further. >> >> +1 for renaming it to osapi_v21 (or osapi_v2_microversions). >> > > Why we still need this option? > > >> >> Thanks >> Ken Ohmichi >> >> __ >> OpenStack Development Mailing List (not for usage questions) >> Unsubscribe: >> openstack-dev-requ...@lists.openstack.org?subject:unsubscribe >> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev >> > > __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [nova] Why is osapi_v3.enabled = False by default?
2015-07-16 7:54 GMT+08:00 Ken'ichi Ohmichi : > 2015-07-16 3:03 GMT+09:00 Sean Dague : > > On 07/15/2015 01:44 PM, Matt Riedemann wrote: > >> The osapi_v3.enabled option is False by default [1] even though it's > >> marked as the CURRENT API and the v2 API is marked as SUPPORTED (and > >> we've frozen it for new feature development). > >> > >> I got looking at this because osapi_v3.enabled is True in nova.conf in > >> both the check-tempest-dsvm-nova-v21-full job and non-v21 > >> check-tempest-dsvm-full job, but only in the v21 job is > >> "x-openstack-nova-api-version: '2.1'" used. > >> > >> Shouldn't the v2.1 API be enabled by default now? > >> > >> [1] > >> > http://git.openstack.org/cgit/openstack/nova/tree/nova/api/openstack/__init__.py#n44 > > Oops, nice catch. > Yeah, we need to make the default enabled. > > > Honestly, we should probably deprecate out osapi_v3.enabled make it > > osapi_v21 (or osapi_v2_microversions) so as to not confuse people > further. > > +1 for renaming it to osapi_v21 (or osapi_v2_microversions). > Why we still need this option? > > Thanks > Ken Ohmichi > > __ > OpenStack Development Mailing List (not for usage questions) > Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [nova] Why is osapi_v3.enabled = False by default?
On Thu, Jul 16, 2015 at 3:03 AM, Sean Dague wrote: > On 07/15/2015 01:44 PM, Matt Riedemann wrote: >> The osapi_v3.enabled option is False by default [1] even though it's >> marked as the CURRENT API and the v2 API is marked as SUPPORTED (and >> we've frozen it for new feature development). >> >> I got looking at this because osapi_v3.enabled is True in nova.conf in >> both the check-tempest-dsvm-nova-v21-full job and non-v21 >> check-tempest-dsvm-full job, but only in the v21 job is >> "x-openstack-nova-api-version: '2.1'" used. >> >> Shouldn't the v2.1 API be enabled by default now? >> >> [1] >> http://git.openstack.org/cgit/openstack/nova/tree/nova/api/openstack/__init__.py#n44 > > Honestly, we should probably deprecate out osapi_v3.enabled make it > osapi_v21 (or osapi_v2_microversions) so as to not confuse people further. > Nice Catch. We might have just forgot to make it default to True. How about just deprecating it and remove in N and makes v21 enable all the time (irrespective of osapi_v3.enabled) as they are current now. > -Sean > > -- > Sean Dague > http://dague.net > > __ > OpenStack Development Mailing List (not for usage questions) > Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev -- Thanks & Regards Ghanshyam Mann __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [nova] Why is osapi_v3.enabled = False by default?
2015-07-16 3:03 GMT+09:00 Sean Dague : > On 07/15/2015 01:44 PM, Matt Riedemann wrote: >> The osapi_v3.enabled option is False by default [1] even though it's >> marked as the CURRENT API and the v2 API is marked as SUPPORTED (and >> we've frozen it for new feature development). >> >> I got looking at this because osapi_v3.enabled is True in nova.conf in >> both the check-tempest-dsvm-nova-v21-full job and non-v21 >> check-tempest-dsvm-full job, but only in the v21 job is >> "x-openstack-nova-api-version: '2.1'" used. >> >> Shouldn't the v2.1 API be enabled by default now? >> >> [1] >> http://git.openstack.org/cgit/openstack/nova/tree/nova/api/openstack/__init__.py#n44 Oops, nice catch. Yeah, we need to make the default enabled. > Honestly, we should probably deprecate out osapi_v3.enabled make it > osapi_v21 (or osapi_v2_microversions) so as to not confuse people further. +1 for renaming it to osapi_v21 (or osapi_v2_microversions). Thanks Ken Ohmichi __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [nova] Why is osapi_v3.enabled = False by default?
On 07/15/2015 01:44 PM, Matt Riedemann wrote: > The osapi_v3.enabled option is False by default [1] even though it's > marked as the CURRENT API and the v2 API is marked as SUPPORTED (and > we've frozen it for new feature development). > > I got looking at this because osapi_v3.enabled is True in nova.conf in > both the check-tempest-dsvm-nova-v21-full job and non-v21 > check-tempest-dsvm-full job, but only in the v21 job is > "x-openstack-nova-api-version: '2.1'" used. > > Shouldn't the v2.1 API be enabled by default now? > > [1] > http://git.openstack.org/cgit/openstack/nova/tree/nova/api/openstack/__init__.py#n44 Honestly, we should probably deprecate out osapi_v3.enabled make it osapi_v21 (or osapi_v2_microversions) so as to not confuse people further. -Sean -- Sean Dague http://dague.net __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
[openstack-dev] [nova] Why is osapi_v3.enabled = False by default?
The osapi_v3.enabled option is False by default [1] even though it's marked as the CURRENT API and the v2 API is marked as SUPPORTED (and we've frozen it for new feature development). I got looking at this because osapi_v3.enabled is True in nova.conf in both the check-tempest-dsvm-nova-v21-full job and non-v21 check-tempest-dsvm-full job, but only in the v21 job is "x-openstack-nova-api-version: '2.1'" used. Shouldn't the v2.1 API be enabled by default now? [1] http://git.openstack.org/cgit/openstack/nova/tree/nova/api/openstack/__init__.py#n44 -- Thanks, Matt Riedemann __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
