Re: [openstack-dev] [oslo] pbr and warnerrors status

[Doug Hellmann]

Excerpts from Ben Nemec's message of 2017-02-08 10:15:57 -0600:
> 
> On 02/08/2017 09:41 AM, Doug Hellmann wrote:
> > Excerpts from Ben Nemec's message of 2017-02-08 09:20:31 -0600:
> >>
> >> On 02/08/2017 01:53 AM, Andreas Jaeger wrote:
> >>> On 2017-02-08 00:56, Ian Cordasco  wrote:
> 
> 
>  On Feb 7, 2017 5:47 PM, "Joshua Harlow"   > wrote:
> 
>  Likely just never pulled the trigger.
> 
>  Seems like we should pull it though.
> 
> 
> 
>  Will have to wait until Pike given the library release freeze
> >>>
> >>> I've pushed a patch to release pbr so that we won't forget about it:
> >>>
> >>> https://review.openstack.org/430618
> >>>
> >>> Andreas
> >>>
> >>
> >> Great, thanks everybody!
> >>
> >
> > It would be useful for someone to look at the pbr change and verify that
> > releasing it as-is won't break the builds for a bunch of projects by
> > turning the flag back on. If it will, we're going to want to provide a
> > way to stage the roll out. If we change the name of the flag, for
> > example, we could release pbr for support for checking warnings, and
> > then projects could enable that when they have time and with the fixes
> > to the docs needed to make it work properly.
> 
> I think the only way to do this would be to run a docs build in every 
> project with warnerrors turned on, using the unreleased pbr.  Given the 
> amount of time it's been broken, there's a good chance some issues have 
> snuck in (they had in diskimage-builder).  So maybe deprecating the old 
> option name and requiring another explicit opt-in from everyone is the 
> safest way to go.
> 
> Thoughts on a new name?  fatalwarnings maybe?
> 

I've proposed [1] to rename the option.

Doug

[1] https://review.openstack.org/437929

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [oslo] pbr and warnerrors status

[Doug Hellmann]

Excerpts from Andreas Jaeger's message of 2017-02-10 13:57:03 +0100:
> On 02/08/2017 05:22 PM, Jay Faulkner  wrote:
>  > [...]
> > IMO, I’d suggest skipping this and just fixing the broken attribute. 
> > Projects that are impacted by the change simply need to merge a one-line 
> > change to set warnerrors=false. FWIW, you can actually run a local docs 
> > build, find and resolve warnings without the PBR change. It seems overkill 
> > to me to change the term since doing so will be super confusing to anyone 
> > who hasn’t read this mailing list thread.
> >
> > If there’s a significant enough concern, a change could be pushed to set 
> > warnerrors=false on the projects that are concerned before this release is 
> > made.
> 
> Yes, this should indeed be an easy change to fix it.
> 
> So, since requirements freeze is over, let me remove my WIP on
> https://review.openstack.org/430618 so that it can be released as 
> convenient for the release team,
> 
> Andreas

I think we're unlikely to release a new version of pbr until after the
ocata final releases are done. It's too pervasive and poses a lot of
risk if something is broken.

Doug

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [oslo] pbr and warnerrors status

[Andreas Jaeger]

On 02/08/2017 05:22 PM, Jay Faulkner  wrote:
> [...]

IMO, I’d suggest skipping this and just fixing the broken attribute. Projects 
that are impacted by the change simply need to merge a one-line change to set 
warnerrors=false. FWIW, you can actually run a local docs build, find and 
resolve warnings without the PBR change. It seems overkill to me to change the 
term since doing so will be super confusing to anyone who hasn’t read this 
mailing list thread.

If there’s a significant enough concern, a change could be pushed to set 
warnerrors=false on the projects that are concerned before this release is made.


Yes, this should indeed be an easy change to fix it.

So, since requirements freeze is over, let me remove my WIP on
https://review.openstack.org/430618 so that it can be released as 
convenient for the release team,


Andreas
--
 Andreas Jaeger aj@{suse.com,opensuse.org} Twitter: jaegerandi
  SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
   GF: Felix Imendörffer, Jane Smithard, Graham Norton,
   HRB 21284 (AG Nürnberg)
GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126


__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [oslo] pbr and warnerrors status

[Jay Faulkner]

> On Feb 8, 2017, at 8:15 AM, Ben Nemec  wrote:
> 
> 
> 
> On 02/08/2017 09:41 AM, Doug Hellmann wrote:
>> Excerpts from Ben Nemec's message of 2017-02-08 09:20:31 -0600:
>>> 
>>> On 02/08/2017 01:53 AM, Andreas Jaeger wrote:
 On 2017-02-08 00:56, Ian Cordasco  wrote:
> 
> 
> On Feb 7, 2017 5:47 PM, "Joshua Harlow"  > wrote:
> 
>Likely just never pulled the trigger.
> 
>Seems like we should pull it though.
> 
> 
> 
> Will have to wait until Pike given the library release freeze
 
 I've pushed a patch to release pbr so that we won't forget about it:
 
 https://review.openstack.org/430618
 
 Andreas
 
>>> 
>>> Great, thanks everybody!
>>> 
>> 
>> It would be useful for someone to look at the pbr change and verify that
>> releasing it as-is won't break the builds for a bunch of projects by
>> turning the flag back on. If it will, we're going to want to provide a
>> way to stage the roll out. If we change the name of the flag, for
>> example, we could release pbr for support for checking warnings, and
>> then projects could enable that when they have time and with the fixes
>> to the docs needed to make it work properly.
> 
> I think the only way to do this would be to run a docs build in every project 
> with warnerrors turned on, using the unreleased pbr.  Given the amount of 
> time it's been broken, there's a good chance some issues have snuck in (they 
> had in diskimage-builder).  So maybe deprecating the old option name and 
> requiring another explicit opt-in from everyone is the safest way to go.
> 
> Thoughts on a new name?  fatalwarnings maybe?
> 

IMO, I’d suggest skipping this and just fixing the broken attribute. Projects 
that are impacted by the change simply need to merge a one-line change to set 
warnerrors=false. FWIW, you can actually run a local docs build, find and 
resolve warnings without the PBR change. It seems overkill to me to change the 
term since doing so will be super confusing to anyone who hasn’t read this 
mailing list thread.

If there’s a significant enough concern, a change could be pushed to set 
warnerrors=false on the projects that are concerned before this release is made.

-
Jay Faulkner
OSIC

> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [oslo] pbr and warnerrors status

[Ben Nemec]

On 02/08/2017 09:41 AM, Doug Hellmann wrote:

Excerpts from Ben Nemec's message of 2017-02-08 09:20:31 -0600:


On 02/08/2017 01:53 AM, Andreas Jaeger wrote:

On 2017-02-08 00:56, Ian Cordasco  wrote:



On Feb 7, 2017 5:47 PM, "Joshua Harlow" > wrote:

Likely just never pulled the trigger.

Seems like we should pull it though.



Will have to wait until Pike given the library release freeze


I've pushed a patch to release pbr so that we won't forget about it:

https://review.openstack.org/430618

Andreas



Great, thanks everybody!



It would be useful for someone to look at the pbr change and verify that
releasing it as-is won't break the builds for a bunch of projects by
turning the flag back on. If it will, we're going to want to provide a
way to stage the roll out. If we change the name of the flag, for
example, we could release pbr for support for checking warnings, and
then projects could enable that when they have time and with the fixes
to the docs needed to make it work properly.


I think the only way to do this would be to run a docs build in every 
project with warnerrors turned on, using the unreleased pbr.  Given the 
amount of time it's been broken, there's a good chance some issues have 
snuck in (they had in diskimage-builder).  So maybe deprecating the old 
option name and requiring another explicit opt-in from everyone is the 
safest way to go.


Thoughts on a new name?  fatalwarnings maybe?

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [oslo] pbr and warnerrors status

[Doug Hellmann]

Excerpts from Ben Nemec's message of 2017-02-08 09:20:31 -0600:
> 
> On 02/08/2017 01:53 AM, Andreas Jaeger wrote:
> > On 2017-02-08 00:56, Ian Cordasco  wrote:
> >>
> >>
> >> On Feb 7, 2017 5:47 PM, "Joshua Harlow"  >> > wrote:
> >>
> >> Likely just never pulled the trigger.
> >>
> >> Seems like we should pull it though.
> >>
> >>
> >>
> >> Will have to wait until Pike given the library release freeze
> >
> > I've pushed a patch to release pbr so that we won't forget about it:
> >
> > https://review.openstack.org/430618
> >
> > Andreas
> >
> 
> Great, thanks everybody!
> 

It would be useful for someone to look at the pbr change and verify that
releasing it as-is won't break the builds for a bunch of projects by
turning the flag back on. If it will, we're going to want to provide a
way to stage the roll out. If we change the name of the flag, for
example, we could release pbr for support for checking warnings, and
then projects could enable that when they have time and with the fixes
to the docs needed to make it work properly.

Doug

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [oslo] pbr and warnerrors status

[Ben Nemec]

On 02/08/2017 01:53 AM, Andreas Jaeger wrote:

On 2017-02-08 00:56, Ian Cordasco  wrote:



On Feb 7, 2017 5:47 PM, "Joshua Harlow" > wrote:

Likely just never pulled the trigger.

Seems like we should pull it though.



Will have to wait until Pike given the library release freeze


I've pushed a patch to release pbr so that we won't forget about it:

https://review.openstack.org/430618

Andreas



Great, thanks everybody!

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [oslo] pbr and warnerrors status

[Andreas Jaeger]

On 2017-02-08 00:56, Ian Cordasco  wrote:
> 
> 
> On Feb 7, 2017 5:47 PM, "Joshua Harlow"  > wrote:
> 
> Likely just never pulled the trigger.
> 
> Seems like we should pull it though.
> 
> 
> 
> Will have to wait until Pike given the library release freeze

I've pushed a patch to release pbr so that we won't forget about it:

https://review.openstack.org/430618

Andreas
-- 
 Andreas Jaeger aj@{suse.com,opensuse.org} Twitter: jaegerandi
  SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
   GF: Felix Imendörffer, Jane Smithard, Graham Norton,
   HRB 21284 (AG Nürnberg)
GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126


__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [oslo] pbr and warnerrors status

[Ian Cordasco]

On Feb 7, 2017 5:47 PM, "Joshua Harlow"  wrote:

Likely just never pulled the trigger.

Seems like we should pull it though.



Will have to wait until Pike given the library release freeze
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [oslo] pbr and warnerrors status

[Joshua Harlow]

Likely just never pulled the trigger.

Seems like we should pull it though.

-Josh

Ben Nemec wrote:

Someone just spent a bunch of effort fixing all the warnings in our docs
project and I'd like to turn on warnerrors so we keep it that way.
Unfortunately, I discovered that warnerrors is still not effective in
setup.cfg.

After digging a little more, I see we never released pbr after the
discussion in
http://lists.openstack.org/pipermail/openstack-dev/2016-June/097849.html
The last release is 1.10, which doesn't include the fix. Was there a
reason for this, or did we just never pull the trigger on the release?

Thanks.

-Ben

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

[openstack-dev] [oslo] pbr and warnerrors status

[Ben Nemec]

Someone just spent a bunch of effort fixing all the warnings in our docs 
project and I'd like to turn on warnerrors so we keep it that way. 
Unfortunately, I discovered that warnerrors is still not effective in 
setup.cfg.


After digging a little more, I see we never released pbr after the 
discussion in 
http://lists.openstack.org/pipermail/openstack-dev/2016-June/097849.html 
 The last release is 1.10, which doesn't include the fix.  Was there a 
reason for this, or did we just never pull the trigger on the release?


Thanks.

-Ben

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev