Re: [openstack-dev] [oslo.messaging][zmq] Redundant zmq.Context creation

2015-02-04 Thread Li Ma
Any news here? Per-socket solution is a conservative solution that makes zeromq driver work for multiple-workers. Neutron-server has api-worker and rpc-worker. I'm not sure per-driver is applicable. I will try to figure it out soon. On Fri, Jan 23, 2015 at 7:53 PM, Oleksii Zamiatin wrote: > 23.01

Re: [openstack-dev] [oslo.messaging][zmq] Redundant zmq.Context creation

2015-01-23 Thread Oleksii Zamiatin
23.01.15, 13:22, Elena Ezhova ?: On Fri, Jan 23, 2015 at 1:55 PM, Ilya Pekelny > wrote: On Fri, Jan 23, 2015 at 12:46 PM, ozamiatin mailto:ozamia...@mirantis.com>> wrote: IMHO It should be created once per Reactor/Client or even per

Re: [openstack-dev] [oslo.messaging][zmq] Redundant zmq.Context creation

2015-01-23 Thread Elena Ezhova
On Fri, Jan 23, 2015 at 1:55 PM, Ilya Pekelny wrote: > > > On Fri, Jan 23, 2015 at 12:46 PM, ozamiatin > wrote: > >> IMHO It should be created once per Reactor/Client or even per driver >> instance. >> > > Per driver, sounds good. > Wouldn't this create regression for Neutron? The original chang

Re: [openstack-dev] [oslo.messaging][zmq] Redundant zmq.Context creation

2015-01-23 Thread Ilya Pekelny
On Fri, Jan 23, 2015 at 12:46 PM, ozamiatin wrote: > IMHO It should be created once per Reactor/Client or even per driver > instance. > Per driver, sounds good. > > By the way (I didn't check it yet with current implementation of the > driver) such approach should break the IPC, because such k

[openstack-dev] [oslo.messaging][zmq] Redundant zmq.Context creation

2015-01-23 Thread ozamiatin
Hi, Working on zmq driver I've noticed that for now zmq.Context is created per socket which is definitely redundant. That was introduced by the change https://review.openstack.org/#/c/126914/5/oslo/messaging/_drivers/impl_zmq.py It makes the correct thing reducing the global context variable,