On Thu, Jan 30, 2014 at 2:06 AM, Daniel P. Berrange wrote:
> On Wed, Jan 29, 2014 at 01:22:59PM -0500, Joe Gordon wrote:
>> On Tue, Jan 28, 2014 at 4:45 AM, John Garbutt wrote:
>> > On 27 January 2014 10:10, Daniel P. Berrange wrote:
>> >> On Fri, Jan 24, 2014 at 11:42:54AM -0500, Joe Gordon wro
On Wed, Jan 29, 2014 at 01:22:59PM -0500, Joe Gordon wrote:
> On Tue, Jan 28, 2014 at 4:45 AM, John Garbutt wrote:
> > On 27 January 2014 10:10, Daniel P. Berrange wrote:
> >> On Fri, Jan 24, 2014 at 11:42:54AM -0500, Joe Gordon wrote:
> >>> On Fri, Jan 24, 2014 at 7:24 AM, Daniel P. Berrange
>
On 01/29/2014 07:22 PM, Joe Gordon wrote:
> On Tue, Jan 28, 2014 at 4:45 AM, John Garbutt wrote:
>> On 27 January 2014 10:10, Daniel P. Berrange wrote:
>>> On Fri, Jan 24, 2014 at 11:42:54AM -0500, Joe Gordon wrote:
On Fri, Jan 24, 2014 at 7:24 AM, Daniel P. Berrange
wrote:
>
On Tue, Jan 28, 2014 at 4:45 AM, John Garbutt wrote:
> On 27 January 2014 10:10, Daniel P. Berrange wrote:
>> On Fri, Jan 24, 2014 at 11:42:54AM -0500, Joe Gordon wrote:
>>> On Fri, Jan 24, 2014 at 7:24 AM, Daniel P. Berrange
>>> wrote:
>>>
>>> > Periodically I've seen people submit big coding s
On 27 January 2014 10:10, Daniel P. Berrange wrote:
> On Fri, Jan 24, 2014 at 11:42:54AM -0500, Joe Gordon wrote:
>> On Fri, Jan 24, 2014 at 7:24 AM, Daniel P. Berrange
>> wrote:
>>
>> > Periodically I've seen people submit big coding style cleanups to Nova
>> > code. These are typically all good
On Fri, Jan 24, 2014 at 11:42:54AM -0500, Joe Gordon wrote:
> On Fri, Jan 24, 2014 at 7:24 AM, Daniel P. Berrange
> wrote:
>
> > Periodically I've seen people submit big coding style cleanups to Nova
> > code. These are typically all good ideas / beneficial, however, I have
> > rarely (perhaps ev
On Fri, Jan 24, 2014 at 7:24 AM, Daniel P. Berrange wrote:
> Periodically I've seen people submit big coding style cleanups to Nova
> code. These are typically all good ideas / beneficial, however, I have
> rarely (perhaps even never?) seen the changes accompanied by new hacking
> check rules.
>
>
Periodically I've seen people submit big coding style cleanups to Nova
code. These are typically all good ideas / beneficial, however, I have
rarely (perhaps even never?) seen the changes accompanied by new hacking
check rules.
The problem with not having a hacking check added *in the same commit*