Re: [openstack-dev] sqlalchemy-migrate call for reviews
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 It's weird: we run python33 job for gate but not checks. Adding Cyril Roelandt who ported the library to py3 to CC. On 01/12/14 23:40, Thomas Goirand wrote: > On 12/01/2014 06:19 PM, Ihar Hrachyshka wrote: >> Indeed, the review queue is non-responsive. There are other >> patches in the queue that bit rot there: >> >> https://review.openstack.org/#/q/status:open+project:stackforge/sqlalchemy-migrate,n,z > >> > I did +2 some of the patches which I thought were totally > unharmful, but none passed the gate. Now, it looks like the Python > 3.3 gate for it is broken... :( Where are those "module not found" > issues from? > > Thomas > > ___ OpenStack-dev > mailing list OpenStack-dev@lists.openstack.org > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > -BEGIN PGP SIGNATURE- Version: GnuPG/MacGPG2 v2.0.22 (Darwin) iQEcBAEBCgAGBQJUfY4VAAoJEC5aWaUY1u57HmsIAJku4Zt/QK2HsV8RwGfgSRSW +WpET+Kqlhcx4WJEqaUApF/+N40NwMYrOEP4Tj1R1RAtT38ABQexvi3uvbQTEb71 XIVL+fzVP99GHqHKROYDWplXZCWfxlQJN2d43c0/JgEWWExZwlGNZbjA70vuCjjt eW3IpjcwKXvmeUTqHfQXTqttzDRePh9tuHxTooZAZ+hm+HOd0WUrtHI44KnxXGt2 1LAynY848I2bxxUrD3PgZWb/N9vwQ5+gZWv4KMRHtDvZJaTa1Oyycflqn+55HBn5 VShaWyVR9zvAKKL6FxIrtnO59EZdtb12YyDecskmIYCg07ywYZGQAUxKuIZK9oI= =bULf -END PGP SIGNATURE- ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] sqlalchemy-migrate call for reviews
On 12/01/2014 06:19 PM, Ihar Hrachyshka wrote: > Indeed, the review queue is non-responsive. There are other patches in > the queue that bit rot there: > > https://review.openstack.org/#/q/status:open+project:stackforge/sqlalchemy-migrate,n,z I did +2 some of the patches which I thought were totally unharmful, but none passed the gate. Now, it looks like the Python 3.3 gate for it is broken... :( Where are those "module not found" issues from? Thomas ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] sqlalchemy-migrate call for reviews
On 2014-12-01 13:24:43 -0500 (-0500), Mike Bayer wrote: [...] > for users on the outside of immediate Openstack use cases I’d > prefer if they can continue working towards moving to Alembic; the > major features I’ve introduced in Alembic including the SQLite > support are intended to make transition much more feasible. Agreed, perhaps the documentation for sqlalchemy-migrate needs to make that statement visible (if it doesn't already). That's also a reasonable message for someone to pass along to those other non-OpenStack users discussing it in external forums... "this is deprecated, on limited life support until OpenStack can complete its transition to Alembic, and other developers using it should look hard at performing similar updates to their software." -- Jeremy Stanley ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] sqlalchemy-migrate call for reviews
I can +2 whichever patches are needed by Openstack projects, or that are critically needed in general, that you can point me towards directly. Overall I’m not the “maintainer” of sqlalchemy-migrate, I’ve only volunteered to have a +2 role for critically needed issues, so in the absence of someone willing to take on a real maintainer role (bug triage, etc.), for users on the outside of immediate Openstack use cases I’d prefer if they can continue working towards moving to Alembic; the major features I’ve introduced in Alembic including the SQLite support are intended to make transition much more feasible. > On Dec 1, 2014, at 5:19 AM, Ihar Hrachyshka wrote: > > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA512 > > Indeed, the review queue is non-responsive. There are other patches in > the queue that bit rot there: > > https://review.openstack.org/#/q/status:open+project:stackforge/sqlalchemy-migrate,n,z > > I guess since no one with a +2 hammer systematically monitors patches > there, users are on their own and better fork if blocked. Sad but true. > > (btw technically monitoring is not that difficult: gerrit allows to > subscribe to specific projects, and this one does not look like time > consuming from reviewer perspective.) > > /Ihar > > On 30/11/14 00:28, Jeremy Stanley wrote: >> To anyone who reviews sqlalchemy-migrate changes, there are people >> talking to themselves on GitHub about long-overdue bug fixes >> because the Gerrit review queue for it is sluggish and they >> apparently don't realize the SQLAM reviewers don't look at Google >> Code issues[1] and GitHub pull request comments[2]. >> >> [1] >> https://code.google.com/p/sqlalchemy-migrate/issues/detail?id=171 >> [2] https://github.com/stackforge/sqlalchemy-migrate/pull/5 >> > -BEGIN PGP SIGNATURE- > Version: GnuPG/MacGPG2 v2.0.22 (Darwin) > > iQEcBAEBCgAGBQJUfECeAAoJEC5aWaUY1u57cx8H/2d8urszdd3RIsU+3JyrnVg6 > I92WtoCS84HdOEE7DjM5m/tgFGjIp9Gh4lovEft5JYDcnHACfd4gdhUunt+PAvVO > 2usFuPdR9IJvbKc28FJAqZeXJpvMc0KSMN4j8t1dtgu6Cv4TaFZEN77G6vrV9jem > b56npPlmpIaDpGP49XtFBHMcbU0pVJ0AQCWUd0wOX+NQl4EfF0stlvxd/1LWn9xf > rZCzatEqyRItlAB+ATpI0TlGSgvVv0PKqrV+TnoZ4OU/TZINNoCjZELB7NkmfDMz > 9rJgviCmCHRyWs+VwsbEeGKDI3nBLjX7UEk5K2f93VsZQWYpW3q6Z2rrpmH977Y= > =gT/r > -END PGP SIGNATURE- > > ___ > OpenStack-dev mailing list > OpenStack-dev@lists.openstack.org > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] sqlalchemy-migrate call for reviews
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Indeed, the review queue is non-responsive. There are other patches in the queue that bit rot there: https://review.openstack.org/#/q/status:open+project:stackforge/sqlalchemy-migrate,n,z I guess since no one with a +2 hammer systematically monitors patches there, users are on their own and better fork if blocked. Sad but true. (btw technically monitoring is not that difficult: gerrit allows to subscribe to specific projects, and this one does not look like time consuming from reviewer perspective.) /Ihar On 30/11/14 00:28, Jeremy Stanley wrote: > To anyone who reviews sqlalchemy-migrate changes, there are people > talking to themselves on GitHub about long-overdue bug fixes > because the Gerrit review queue for it is sluggish and they > apparently don't realize the SQLAM reviewers don't look at Google > Code issues[1] and GitHub pull request comments[2]. > > [1] > https://code.google.com/p/sqlalchemy-migrate/issues/detail?id=171 > [2] https://github.com/stackforge/sqlalchemy-migrate/pull/5 > -BEGIN PGP SIGNATURE- Version: GnuPG/MacGPG2 v2.0.22 (Darwin) iQEcBAEBCgAGBQJUfECeAAoJEC5aWaUY1u57cx8H/2d8urszdd3RIsU+3JyrnVg6 I92WtoCS84HdOEE7DjM5m/tgFGjIp9Gh4lovEft5JYDcnHACfd4gdhUunt+PAvVO 2usFuPdR9IJvbKc28FJAqZeXJpvMc0KSMN4j8t1dtgu6Cv4TaFZEN77G6vrV9jem b56npPlmpIaDpGP49XtFBHMcbU0pVJ0AQCWUd0wOX+NQl4EfF0stlvxd/1LWn9xf rZCzatEqyRItlAB+ATpI0TlGSgvVv0PKqrV+TnoZ4OU/TZINNoCjZELB7NkmfDMz 9rJgviCmCHRyWs+VwsbEeGKDI3nBLjX7UEk5K2f93VsZQWYpW3q6Z2rrpmH977Y= =gT/r -END PGP SIGNATURE- ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] sqlalchemy-migrate call for reviews
I’ve +2’ed it, it was caused by https://review.openstack.org/#/c/81955/. > On Nov 29, 2014, at 9:54 PM, Davanum Srinivas wrote: > > Looks like there is a review in the queue - > https://review.openstack.org/#/c/111485/ > > -- dims > > On Sat, Nov 29, 2014 at 6:28 PM, Jeremy Stanley wrote: >> To anyone who reviews sqlalchemy-migrate changes, there are people >> talking to themselves on GitHub about long-overdue bug fixes because >> the Gerrit review queue for it is sluggish and they apparently don't >> realize the SQLAM reviewers don't look at Google Code issues[1] and >> GitHub pull request comments[2]. >> >> [1] https://code.google.com/p/sqlalchemy-migrate/issues/detail?id=171 >> [2] https://github.com/stackforge/sqlalchemy-migrate/pull/5 >> >> -- >> Jeremy Stanley >> >> ___ >> OpenStack-dev mailing list >> OpenStack-dev@lists.openstack.org >> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > > > > -- > Davanum Srinivas :: https://twitter.com/dims > > ___ > OpenStack-dev mailing list > OpenStack-dev@lists.openstack.org > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] sqlalchemy-migrate call for reviews
Looks like there is a review in the queue - https://review.openstack.org/#/c/111485/ -- dims On Sat, Nov 29, 2014 at 6:28 PM, Jeremy Stanley wrote: > To anyone who reviews sqlalchemy-migrate changes, there are people > talking to themselves on GitHub about long-overdue bug fixes because > the Gerrit review queue for it is sluggish and they apparently don't > realize the SQLAM reviewers don't look at Google Code issues[1] and > GitHub pull request comments[2]. > > [1] https://code.google.com/p/sqlalchemy-migrate/issues/detail?id=171 > [2] https://github.com/stackforge/sqlalchemy-migrate/pull/5 > > -- > Jeremy Stanley > > ___ > OpenStack-dev mailing list > OpenStack-dev@lists.openstack.org > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev -- Davanum Srinivas :: https://twitter.com/dims ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
[openstack-dev] sqlalchemy-migrate call for reviews
To anyone who reviews sqlalchemy-migrate changes, there are people talking to themselves on GitHub about long-overdue bug fixes because the Gerrit review queue for it is sluggish and they apparently don't realize the SQLAM reviewers don't look at Google Code issues[1] and GitHub pull request comments[2]. [1] https://code.google.com/p/sqlalchemy-migrate/issues/detail?id=171 [2] https://github.com/stackforge/sqlalchemy-migrate/pull/5 -- Jeremy Stanley ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
