Re: [openstack-dev] [Nova] modify_image_attribute() in ec2_api is broken in Nova

2014-02-12 Thread Vishvananda Ishaya 
This looks like a bug to me. It would be great if you could report it on 
launchpad.

Vish

On Feb 11, 2014, at 7:49 PM, wu jiang win...@gmail.com wrote:

 Hi all,
 
 I met some problems when testing an ec2_api:'modify_image_attribute()' in 
 Nova.
 I found the params send to Nova, are not suitable to match it in AWS api.
 I logged it in launchpad: https://bugs.launchpad.net/nova/+bug/1272844
 
 -
 
 1. Here is the definition part of modify_image_attribute(): 
 
 def modify_image_attribute(
 self, context, image_id, attribute, operation_type, **kwargs)
 
 2. And here is the example of it in AWS api:
 
 https://ec2.amazonaws.com/?Action=ModifyImageAttributeImageId=ami-61a54008LaunchPermission.Remove.1.UserId=
 
 -
 
 3. You can see the value isn't suitable to match the defination in Nova codes.
 Therefore, Nova will raise the exception like this:
 
 TypeError: 'modify_image_attribute() takes exactly 5 non-keyword arguments 
 (3 given)'
 
 4. I printed out the params send to Nova via eucaTools.
 The results also validate the conclusions above:
 
  args={'launch_permission': {'add': {'1': {'group': u'all'}}}, 'image_id': 
  u'ami-0004'} 
 
 --
 
 So, is this api correct? Should we need to modify it according to the format 
 of AWS api?
 
 
 Best Wishes,
 wingwj
 ___
 OpenStack-dev mailing list
 OpenStack-dev@lists.openstack.org
 http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev



signature.asc
Description: Message signed with OpenPGP using GPGMail
___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [Nova] modify_image_attribute() in ec2_api is broken in Nova

2014-02-12 Thread wu jiang 
Hi Vish, thanks for your reply.

I've already registered it on launchpad:
https://bugs.launchpad.net/nova/+bug/1272844


Thanks~


On Thu, Feb 13, 2014 at 2:18 AM, Vishvananda Ishaya
vishvana...@gmail.comwrote:

 This looks like a bug to me. It would be great if you could report it on
 launchpad.

 Vish

 On Feb 11, 2014, at 7:49 PM, wu jiang win...@gmail.com wrote:

 Hi all,

 I met some problems when testing an ec2_api:'modify_image_attribute()' in
 Nova.
 I found the params send to Nova, are not suitable to match it in AWS api.
 I logged it in launchpad: https://bugs.launchpad.net/nova/+bug/1272844

 -

 1. Here is the definition part of modify_image_attribute():

 def modify_image_attribute(
 self, context, image_id, attribute, operation_type, **kwargs)

 2. And here is the example of it in AWS api:


 https://ec2.amazonaws.com/?Action=ModifyImageAttributeImageId=ami-61a54008LaunchPermission.Remove.1.UserId=

 -

 3. You can see the value isn't suitable to match the defination in Nova
 codes.
 Therefore, Nova will raise the exception like this:

 TypeError: 'modify_image_attribute() takes exactly 5 non-keyword
 arguments (3 given)'

 4. I printed out the params send to Nova via eucaTools.
 The results also validate the conclusions above:

  args={'launch_permission': {'add': {'1': {'group': u'all'}}},
 'image_id': u'ami-0004'}

 --

 So, is this api correct? Should we need to modify it according to the
 format of AWS api?


 Best Wishes,
 wingwj
 ___
 OpenStack-dev mailing list
 OpenStack-dev@lists.openstack.org
 http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev



 ___
 OpenStack-dev mailing list
 OpenStack-dev@lists.openstack.org
 http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev