Re: [openstack-dev] [Nova] object field naming question

2014-10-10 Thread Murray, Paul (HP Cloud)
-- From: Dan Smith d...@danplanet.commailto:d...@danplanet.com Date: 9 October 2014 17:40 Subject: Re: [openstack-dev] [Nova] object field naming question To: OpenStack Development Mailing List (not for usage questions) openstack-dev@lists.openstack.orgmailto:openstack-dev@lists.openstack.org

Re: [openstack-dev] [Nova] object field naming question

2014-10-09 Thread Daniel P. Berrange
On Thu, Oct 09, 2014 at 01:45:43PM +, Murray, Paul (HP Cloud) wrote: Hi All, The following question relates to this change: https://review.openstack.org/#/c/125091/ This change adds a field to the ComputeNode object called supported_instances. It also adds an object called

Re: [openstack-dev] [Nova] object field naming question

2014-10-09 Thread Jay Pipes
On 10/09/2014 10:16 AM, Daniel P. Berrange wrote: On Thu, Oct 09, 2014 at 01:45:43PM +, Murray, Paul (HP Cloud) wrote: Hi All, The following question relates to this change: https://review.openstack.org/#/c/125091/ This change adds a field to the ComputeNode object called

Re: [openstack-dev] [Nova] object field naming question

2014-10-09 Thread Jay Pipes
On 10/09/2014 09:45 AM, Murray, Paul (HP Cloud) wrote: Hi All, The following question relates to this change: https://review.openstack.org/#/c/125091/ This change adds a field to the ComputeNode object called “supported_instances”. It also adds an object called “SupportedInstance” that has

Re: [openstack-dev] [Nova] object field naming question

2014-10-09 Thread Dan Smith
The value it adds (and that an underscore would add in hvtype - hv_type) is that the name would match the naming style for the vast majority of everything else in OpenStack. See, for examples: Agreed. As mentioned in the review, I disagree on this point, since doing a cleanup afterwards