Re: [openstack-dev] [all] python-troveclient keystone v3 support breaking the world
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On 12/11/14 15:17, Sean Dague wrote: 1) just delete the trove exercise so we can move forward - https://review.openstack.org/#/c/133930 - that will need to be backported as well. The patch is merged. Do we still need to backport it baring in mind that client revert [1] was merged? I guess no, but better check. Also, since trove client is back in shape, should we revert your devstack patch? [1]: https://review.openstack.org/#/c/133958/ /Ihar -BEGIN PGP SIGNATURE- Version: GnuPG/MacGPG2 v2.0.22 (Darwin) iQEcBAEBCgAGBQJUZKC1AAoJEC5aWaUY1u57PC8IAKZSqHTNtBOUBgB8VwzUpS4Q UQZNJI8jfGjl6Eqd/H2BRvobSjKMKUnhriY4rbz0PhMUWTHrxwZFmi7i4mq5VhYq y5yv70JijVatlXjCuFps8coqvOdseprB2IugX5LJ3/4edfs1xbJ3hJti/35Iklxd 9J8FM41Whx8t62jfSmNWTah1Y+GVMDwvnwFMDqjUpzwHW1bPHgoumSh5ZwlG5hwl 3BKTNCjnYY0b6yswUKSvDafPWGSNNlQT2ZQuVTBmFq65UC5mq3SWMhZ7ikLEca2K o9gMzG5iQxpviKzHFMgZj7ZCGpjcE58GI/8D2e4btlST6blvvjqWYl1VyzJahDM= =s/Hp -END PGP SIGNATURE- ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [all] python-troveclient keystone v3 support breaking the world
On 11/13/2014 07:14 AM, Ihar Hrachyshka wrote: On 12/11/14 15:17, Sean Dague wrote: 1) just delete the trove exercise so we can move forward - https://review.openstack.org/#/c/133930 - that will need to be backported as well. The patch is merged. Do we still need to backport it baring in mind that client revert [1] was merged? I guess no, but better check. Also, since trove client is back in shape, should we revert your devstack patch? [1]: https://review.openstack.org/#/c/133958/ Honestly, devstack exercises are deprecated. I'd rather just keep it out. They tend to be things that projects write once, then rot, and I end up deleting or disabling them 6 months later. Service testing should be in tempest, where we're in an environment that's a bit more controlled, and has lots better debug information when things go wrong. -Sean -- Sean Dague http://dague.net signature.asc Description: OpenPGP digital signature ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [all] python-troveclient keystone v3 support breaking the world
On 11/12/2014 09:17 AM, Sean Dague wrote: https://review.openstack.org/#/c/102315/ was merged yesterday, it creates a non functional trove python client. (There are currently no tests in python trove client to see if the commands even run after a code change). This means the trove devstack exercise can't work. Which means everything testing cells (oslo.db, nova, glance, heat, etc) can't pass any changes. I've proposed 2 fixes. 1) just delete the trove exercise so we can move forward - https://review.openstack.org/#/c/133930 - that will need to be backported as well. 2) revert the troveclient change - https://review.openstack.org/#/c/102315/ (which I think also should be done) and not repropose until there are actual tests in the troveclient tree to prevent this kind of breakage. -Sean The bug in question - http://status.openstack.org/elastic-recheck/#1391840 -Sean -- Sean Dague http://dague.net ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [all] python-troveclient keystone v3 support breaking the world
Sean, I'm looking into this and have proposed https://review.openstack.org/#/c/133958/ as an interim measure. As soon as the trove gate passes I'll try and get a couple of other votes and have that change merged. Dims and I had a short chat on IRC and weren't able to come up with a quick solution to the problem; I think the change you identified needs to be reworked. More to come. -amrith | -Original Message- | From: Sean Dague [mailto:s...@dague.net] | Sent: Wednesday, November 12, 2014 9:22 AM | To: OpenStack Development Mailing List (not for usage questions) | Subject: Re: [openstack-dev] [all] python-troveclient keystone v3 support | breaking the world | | On 11/12/2014 09:17 AM, Sean Dague wrote: | https://review.openstack.org/#/c/102315/ was merged yesterday, it | creates a non functional trove python client. (There are currently no | tests in python trove client to see if the commands even run after a | code change). | | This means the trove devstack exercise can't work. | | Which means everything testing cells (oslo.db, nova, glance, heat, | etc) can't pass any changes. | | I've proposed 2 fixes. | | 1) just delete the trove exercise so we can move forward - | https://review.openstack.org/#/c/133930 - that will need to be | backported as well. | | 2) revert the troveclient change - | https://review.openstack.org/#/c/102315/ (which I think also should be | done) and not repropose until there are actual tests in the | troveclient tree to prevent this kind of breakage. | | -Sean | | | The bug in question - http://status.openstack.org/elastic-recheck/#1391840 | | -Sean | | -- | Sean Dague | http://dague.net | | ___ | OpenStack-dev mailing list | OpenStack-dev@lists.openstack.org | http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [all] python-troveclient keystone v3 support breaking the world
Thanks Sean and Amrith - for getting the patches lined up to unblock the gate and keep things moving. I missed the action (just got off a plane). I'll follow up on IRC to get the tests up and running on python-troveclient, and on the next steps to rework the patch. Thanks, Nikhil On Wed, Nov 12, 2014 at 6:59 AM, Amrith Kumar amr...@tesora.com wrote: Sean, I'm looking into this and have proposed https://review.openstack.org/#/c/133958/ as an interim measure. As soon as the trove gate passes I'll try and get a couple of other votes and have that change merged. Dims and I had a short chat on IRC and weren't able to come up with a quick solution to the problem; I think the change you identified needs to be reworked. More to come. -amrith | -Original Message- | From: Sean Dague [mailto:s...@dague.net] | Sent: Wednesday, November 12, 2014 9:22 AM | To: OpenStack Development Mailing List (not for usage questions) | Subject: Re: [openstack-dev] [all] python-troveclient keystone v3 support | breaking the world | | On 11/12/2014 09:17 AM, Sean Dague wrote: | https://review.openstack.org/#/c/102315/ was merged yesterday, it | creates a non functional trove python client. (There are currently no | tests in python trove client to see if the commands even run after a | code change). | | This means the trove devstack exercise can't work. | | Which means everything testing cells (oslo.db, nova, glance, heat, | etc) can't pass any changes. | | I've proposed 2 fixes. | | 1) just delete the trove exercise so we can move forward - | https://review.openstack.org/#/c/133930 - that will need to be | backported as well. | | 2) revert the troveclient change - | https://review.openstack.org/#/c/102315/ (which I think also should be | done) and not repropose until there are actual tests in the | troveclient tree to prevent this kind of breakage. | | -Sean | | | The bug in question - http://status.openstack.org/elastic-recheck/#1391840 | | -Sean | | -- | Sean Dague | http://dague.net | | ___ | OpenStack-dev mailing list | OpenStack-dev@lists.openstack.org | http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
