Re: [openstack-dev] Contribution work flow
2014-09-13 7:09 GMT-03:00 Sharan Kumar M sharan.monikan...@gmail.com: Hi, I am about to submit my first patch. I saw the contributions guidelines in the documentations. Just to make it clear, is it that I issue a pull request in GitHub, which automatically pushes my patch to gerrit? Also, I found something called change-Id in the commit message. Is it the hash code for the git commit? If yes, should we prefix a 'I' in the beginning of hash code? Thanks, Sharan Kumar M ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev Hi Sharan, In order to submit your contributions you have to configure your git repo as stated in [0]. We don't directly issue pull requests, we use git review instead. If you didn't install it yet, install it with 'pip install git-review', and then simply 'git review' your change. So, the workflow is: - Code, code, code - Make sure you have your changes in a branch called bug/bug-no or bp/bp-id. If you started working in master, simply do a 'git checkout -b bug/bug-no or bp/bp-id' - Commit the change - Write the commit message [1] - And finally 'git review' The change-id is auto generated, you don't have to add it by hand. You can check more details about the workflow in [2]. [0] https://wiki.openstack.org/wiki/Gerrit_Workflow#Project_Setup [1] https://wiki.openstack.org/wiki/GitCommitMessages [2] https://wiki.openstack.org/wiki/Gerrit_Workflow#Normal_Workflow Hope it's clear, and if not, feel free to reach me on IRC at irc.freenode.org at #openstack-101. My IRC handle is vkmc. My best, ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] Contribution work flow
On 2014-09-13 15:39:30 +0530 (+0530), Sharan Kumar M wrote: I am about to submit my first patch. Welcome to our contributor community! I'm going to apologize in advance for the convoluted way in which our projects accept code contributions, but it's streamlined for high-volume contributors (which it's very efficient at enabling) but can be a bit of an initial hassle for first-time or casual contributors. I saw the contributions guidelines in the documentations. It doesn't sound like you did. Please *carefully* follow the instructions here: https://wiki.openstack.org/wiki/How_To_Contribute#If_you.27re_a_developer There is a legal agreement you'll need to confirm if you want to contribute patches to most of our official projects, which as a prerequisite requires that you first join the OpenStack Foundation as a (free) member. The process is basically instantaneous, but if you skip steps or do them out of order you're going to end up confused very quickly. Just to make it clear, is it that I issue a pull request in GitHub, which automatically pushes my patch to gerrit? We do not use Github to run the OpenStack Project. We are a free project, and Github is not free software. Also, I found something called change-Id in the commit message. Is it the hash code for the git commit? If yes, should we prefix a 'I' in the beginning of hash code? This is an implementation detail of our code review system, which tools should create for you (it's normally generated by a Git hook which is installed in your local repository configuration the first time you run 'git review' and then gets inserted into commit messages for you on each subsequent commit message edit in that repository). Please do not manually construct the Change-Id for a commit. -- Jeremy Stanley ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] Contribution work flow
Shar, Hi! 1) install git-review and set it up (poke around openstack docs) 2) after crafting your patch in a new branch (git branch name-of-branch-you-are-working-on), commit the changes (git add -a), craft a commit message, save it, and then type git review If everything is correct, it will submit to openstack's ci machine (review.openstack.org) and you can track CI testing + reviews and such. Also - cool to see you working on OpenStack! Cheers, Patrick On 09/13/2014 03:09 AM, Sharan Kumar M wrote: Hi, I am about to submit my first patch. I saw the contributions guidelines in the documentations. Just to make it clear, is it that I issue a pull request in GitHub, which automatically pushes my patch to gerrit? Also, I found something called change-Id in the commit message. Is it the hash code for the git commit? If yes, should we prefix a 'I' in the beginning of hash code? Thanks, Sharan Kumar M ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
