Re: [openstack-dev] [AODH] event-alarm timeout discussion

2016-11-09 Thread Julien Danjou
On Mon, Sep 26 2016, Zhai, Edwin wrote: > Do you have any idea to resolve this race condition? So following our discussion at the summit, I went ahead and wrote a spec about that feature: https://review.openstack.org/#/c/395058/ Comments are welcome obviously! Cheers, -- Julien Danjou # Fre

Re: [openstack-dev] [AODH] event-alarm timeout discussion

2016-09-25 Thread Zhai, Edwin
On Fri, 23 Sep 2016, gordon chung wrote: On 23/09/2016 2:18 AM, Zhai, Edwin wrote: There are many targets(topics)/endpoints in above ceilometer code. But in AODH, we just have one topic, 'alarm.all', and one endpoint. If it is still multi-threaded, there is already potential race condition

Re: [openstack-dev] [AODH] event-alarm timeout discussion

2016-09-23 Thread gordon chung
On 23/09/2016 2:18 AM, Zhai, Edwin wrote: > > There are many targets(topics)/endpoints in above ceilometer code. But > in AODH, we just have one topic, 'alarm.all', and one endpoint. If it is > still multi-threaded, there is already potential race condition here, > but event-alarm tiemout make i

Re: [openstack-dev] [AODH] event-alarm timeout discussion

2016-09-23 Thread gordon chung
On 23/09/2016 3:19 AM, Zhai, Edwin wrote: > "Each notification listener is associated with an executor which > controls how incoming notification messages will be received and > dispatched. By default, the most simple executor is used - the blocking > executor. This executor processes inbound not

Re: [openstack-dev] [AODH] event-alarm timeout discussion

2016-09-23 Thread Zhai, Edwin
Just check oslo messaging doc, don't know if it's out of date. "Each notification listener is associated with an executor which controls how incoming notification messages will be received and dispatched. By default, the most simple executor is used - the blocking executor. This executor proces

Re: [openstack-dev] [AODH] event-alarm timeout discussion

2016-09-22 Thread Zhai, Edwin
Thanks for your clarification, see my comments below. On Thu, 22 Sep 2016, gordon chung wrote: On 22/09/2016 2:40 AM, Zhai, Edwin wrote: See https://github.com/openstack/aodh/blob/master/aodh/evaluator/event.py#L158 evaluate_events is the handler of the endpoint for 'alarm.all', it iterate

Re: [openstack-dev] [AODH] event-alarm timeout discussion

2016-09-22 Thread gordon chung
On 22/09/2016 2:40 AM, Zhai, Edwin wrote: > > See > https://github.com/openstack/aodh/blob/master/aodh/evaluator/event.py#L158 > > evaluate_events is the handler of the endpoint for 'alarm.all', it > iterates the event list and evaluate them one by one with project > alarms. If both 'timeout.end'

Re: [openstack-dev] [AODH] event-alarm timeout discussion

2016-09-21 Thread Zhai, Edwin
Gordon, Thanks for your comments. Pls. check my answer and flow chart below. On Wed, 21 Sep 2016, gordon chung wrote: === event-alarm timeout implementation = As it's for event-alarm, we need keep it as event-driven. Furthermore, for quick response, we need use event for ti

Re: [openstack-dev] [AODH] event-alarm timeout discussion

2016-09-21 Thread gordon chung
On 21/09/16 01:43 AM, Zhai, Edwin wrote: > All, > > I'd like make some clarification for the event-alarm timeout design as > many of you have some misunderstanding here. Pls. correct me if any > mistakes. > > I realized that there are 2 different things, but we mix them sometime: > 1. event-timeo

[openstack-dev] [AODH] event-alarm timeout discussion

2016-09-20 Thread Zhai, Edwin
All, I'd like make some clarification for the event-alarm timeout design as many of you have some misunderstanding here. Pls. correct me if any mistakes. I realized that there are 2 different things, but we mix them sometime: 1. event-timeout-alarm This is one new type of alarm that bracket *.