Re: [openstack-dev] [Cinder][FFE] Cinder switch-over to oslo.messaging
Flavio Percoco wrote: On 06/03/14 11:50 +0100, Thierry Carrez wrote: So on one hand this is a significant change that looks like it could wait (little direct feature gain). On the other we have oslo.messaging being adopted in a lot of projects, and we reduce the maintenance envelope if we switch most projects to it BEFORE release. This one really boils down to how early it can be merged. If it's done before the meeting next Tuesday, it's a net gain. If not, it becomes too much of a distraction from bugfixes for reviewers and any regression it creates might get overlooked. FWIW, I just rebased it earlier today and the patch could be merged today if it gets enough reviews. Discussed it with John and confirmed the exception. Go for it ! -- Thierry Carrez (ttx) signature.asc Description: OpenPGP digital signature ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
[openstack-dev] [Cinder][FFE] Cinder switch-over to oslo.messaging
I'd like to request a FFE for the oslo.messaging migration in Cinder. Some projects have already switched over oslo.messaging and others are still doing so. I think we should switch remaining projects to oslo.messaging as soon as possible and keep the RPC library in use consistent throughout OpenStack. Cinder's patch has been up for review for a couple of weeks already and it's been kept updated with master. Besides some of the gate failures we've had in the last couple of weeks, it seems to work as expected. As a final note, most of the work on this patch followed the style and changes done in Nova, for better or for worse. The review link is: https://review.openstack.org/#/c/71873/ Cheers, Flavio -- @flaper87 Flavio Percoco pgpopMOYxazNg.pgp Description: PGP signature ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [Cinder][FFE] Cinder switch-over to oslo.messaging
Flavio Percoco wrote: I'd like to request a FFE for the oslo.messaging migration in Cinder. Some projects have already switched over oslo.messaging and others are still doing so. I think we should switch remaining projects to oslo.messaging as soon as possible and keep the RPC library in use consistent throughout OpenStack. Cinder's patch has been up for review for a couple of weeks already and it's been kept updated with master. Besides some of the gate failures we've had in the last couple of weeks, it seems to work as expected. As a final note, most of the work on this patch followed the style and changes done in Nova, for better or for worse. The review link is: https://review.openstack.org/#/c/71873/ So on one hand this is a significant change that looks like it could wait (little direct feature gain). On the other we have oslo.messaging being adopted in a lot of projects, and we reduce the maintenance envelope if we switch most projects to it BEFORE release. This one really boils down to how early it can be merged. If it's done before the meeting next Tuesday, it's a net gain. If not, it becomes too much of a distraction from bugfixes for reviewers and any regression it creates might get overlooked. -- Thierry Carrez (ttx) signature.asc Description: OpenPGP digital signature ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [Cinder][FFE] Cinder switch-over to oslo.messaging
On 06/03/14 11:50 +0100, Thierry Carrez wrote: Flavio Percoco wrote: I'd like to request a FFE for the oslo.messaging migration in Cinder. Some projects have already switched over oslo.messaging and others are still doing so. I think we should switch remaining projects to oslo.messaging as soon as possible and keep the RPC library in use consistent throughout OpenStack. Cinder's patch has been up for review for a couple of weeks already and it's been kept updated with master. Besides some of the gate failures we've had in the last couple of weeks, it seems to work as expected. As a final note, most of the work on this patch followed the style and changes done in Nova, for better or for worse. The review link is: https://review.openstack.org/#/c/71873/ So on one hand this is a significant change that looks like it could wait (little direct feature gain). On the other we have oslo.messaging being adopted in a lot of projects, and we reduce the maintenance envelope if we switch most projects to it BEFORE release. This one really boils down to how early it can be merged. If it's done before the meeting next Tuesday, it's a net gain. If not, it becomes too much of a distraction from bugfixes for reviewers and any regression it creates might get overlooked. FWIW, I just rebased it earlier today and the patch could be merged today if it gets enough reviews. Cheers, Fla. -- @flaper87 Flavio Percoco pgpC_dt24wcQj.pgp Description: PGP signature ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
