Re: [openstack-dev] [Heat][Horizon] Any guidelines for naming heat resource type names?

2016-08-18 Thread Praveen Yalagandula 
Tatiana,
Thanks for filing the bug and putting in a patch!
Cheers,
Praveen

On Wed, Aug 17, 2016 at 1:45 AM Tatiana Ovtchinnikova <
t.v.ovtchinnik...@gmail.com> wrote:

> Filed a bug: https://bugs.launchpad.net/horizon/+bug/1614000
>
>
> 2016-08-17 11:19 GMT+03:00 Tatiana Ovtchinnikova <
> t.v.ovtchinnik...@gmail.com>:
>
>> It is definitely a bug in Horizon. The additional columns
>> "Implementation", "Component" and "Resource" are representative for a
>> limited resource type group only. Since Heat allows to specify a URL as a
>> resource type, we should not use these columns at all. "Type" column and
>> filter will do just the same trick.
>>
>> Tatiana.
>>
>>
>> 2016-08-17 1:22 GMT+03:00 Rob Cresswell :
>>
>>> This sounds like a bug on the Horizon side. There is/was a patch
>>> regarding a similar issue with LBaaS v2 resources too. It's likely just an
>>> incorrect assumption in the logic processing these names.
>>>
>>> Rob
>>>
>>> On 16 Aug 2016 11:03 p.m., "Zane Bitter"  wrote:
>>>
 On 16/08/16 17:43, Praveen Yalagandula wrote:
 > Hi all,
 > We have developed some heat resources for our custom API server. We
 > followed the instructions in the development guide
 > at http://docs.openstack.org/developer/heat/pluginguide.html and got
 > everything working. However, the Horizon "Resource Types" panel is
 > returning a 500 error with "TemplateSyntaxError: u'resource'" message.
 >
 > Upon further debugging, we found that the Horizon is expecting all
 Heat
 > resource type names to be of form
 > . However, we didn't see this
 > requirement in the heat development documents. Some of our resource
 > types have just two words (e.g., "Avi::Pool"). Heat itself didn't care
 > about these names at all.

 Given that Heat has a REST API specifically for validating templates,
 it's surprising that Horizon would implement its own, apparently
 incorrect, validation.

 > Question: Is there a general consensus is to enforce
 > the  format for type names?

 No. We don't really care what you call them (although using OS:: or
 AWS:: as a prefix for your own custom types would be very unwise). In
 fact, Heat allows you to specify a URL of a template file as a resource
 type, and it sounds like that might run afoul of the same restriction.

 > If so, can we please update the heat plugin guide to reflect this?
 > If not, we can file it is as a bug in Horizon.

 +1 for bug in Horizon.

 - ZB


 __
 OpenStack Development Mailing List (not for usage questions)
 Unsubscribe:
 openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
 http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

>>>
>>>
>>> __
>>> OpenStack Development Mailing List (not for usage questions)
>>> Unsubscribe:
>>> openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
>>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>>
>>>
>>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [Heat][Horizon] Any guidelines for naming heat resource type names?

2016-08-17 Thread Tatiana Ovtchinnikova 
Filed a bug: https://bugs.launchpad.net/horizon/+bug/1614000

2016-08-17 11:19 GMT+03:00 Tatiana Ovtchinnikova <
t.v.ovtchinnik...@gmail.com>:

> It is definitely a bug in Horizon. The additional columns
> "Implementation", "Component" and "Resource" are representative for a
> limited resource type group only. Since Heat allows to specify a URL as a
> resource type, we should not use these columns at all. "Type" column and
> filter will do just the same trick.
>
> Tatiana.
>
>
> 2016-08-17 1:22 GMT+03:00 Rob Cresswell :
>
>> This sounds like a bug on the Horizon side. There is/was a patch
>> regarding a similar issue with LBaaS v2 resources too. It's likely just an
>> incorrect assumption in the logic processing these names.
>>
>> Rob
>>
>> On 16 Aug 2016 11:03 p.m., "Zane Bitter"  wrote:
>>
>>> On 16/08/16 17:43, Praveen Yalagandula wrote:
>>> > Hi all,
>>> > We have developed some heat resources for our custom API server. We
>>> > followed the instructions in the development guide
>>> > at http://docs.openstack.org/developer/heat/pluginguide.html and got
>>> > everything working. However, the Horizon "Resource Types" panel is
>>> > returning a 500 error with "TemplateSyntaxError: u'resource'" message.
>>> >
>>> > Upon further debugging, we found that the Horizon is expecting all Heat
>>> > resource type names to be of form
>>> > . However, we didn't see this
>>> > requirement in the heat development documents. Some of our resource
>>> > types have just two words (e.g., "Avi::Pool"). Heat itself didn't care
>>> > about these names at all.
>>>
>>> Given that Heat has a REST API specifically for validating templates,
>>> it's surprising that Horizon would implement its own, apparently
>>> incorrect, validation.
>>>
>>> > Question: Is there a general consensus is to enforce
>>> > the  format for type names?
>>>
>>> No. We don't really care what you call them (although using OS:: or
>>> AWS:: as a prefix for your own custom types would be very unwise). In
>>> fact, Heat allows you to specify a URL of a template file as a resource
>>> type, and it sounds like that might run afoul of the same restriction.
>>>
>>> > If so, can we please update the heat plugin guide to reflect this?
>>> > If not, we can file it is as a bug in Horizon.
>>>
>>> +1 for bug in Horizon.
>>>
>>> - ZB
>>>
>>> 
>>> __
>>> OpenStack Development Mailing List (not for usage questions)
>>> Unsubscribe: openstack-dev-requ...@lists.op
>>> enstack.org?subject:unsubscribe
>>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>>
>>
>> 
>> __
>> OpenStack Development Mailing List (not for usage questions)
>> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscrib
>> e
>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>
>>
>
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [Heat][Horizon] Any guidelines for naming heat resource type names?

2016-08-17 Thread Tatiana Ovtchinnikova 
It is definitely a bug in Horizon. The additional columns "Implementation",
"Component" and "Resource" are representative for a limited resource type
group only. Since Heat allows to specify a URL as a resource type, we
should not use these columns at all. "Type" column and filter will do just
the same trick.

Tatiana.

2016-08-17 1:22 GMT+03:00 Rob Cresswell :

> This sounds like a bug on the Horizon side. There is/was a patch regarding
> a similar issue with LBaaS v2 resources too. It's likely just an incorrect
> assumption in the logic processing these names.
>
> Rob
>
> On 16 Aug 2016 11:03 p.m., "Zane Bitter"  wrote:
>
>> On 16/08/16 17:43, Praveen Yalagandula wrote:
>> > Hi all,
>> > We have developed some heat resources for our custom API server. We
>> > followed the instructions in the development guide
>> > at http://docs.openstack.org/developer/heat/pluginguide.html and got
>> > everything working. However, the Horizon "Resource Types" panel is
>> > returning a 500 error with "TemplateSyntaxError: u'resource'" message.
>> >
>> > Upon further debugging, we found that the Horizon is expecting all Heat
>> > resource type names to be of form
>> > . However, we didn't see this
>> > requirement in the heat development documents. Some of our resource
>> > types have just two words (e.g., "Avi::Pool"). Heat itself didn't care
>> > about these names at all.
>>
>> Given that Heat has a REST API specifically for validating templates,
>> it's surprising that Horizon would implement its own, apparently
>> incorrect, validation.
>>
>> > Question: Is there a general consensus is to enforce
>> > the  format for type names?
>>
>> No. We don't really care what you call them (although using OS:: or
>> AWS:: as a prefix for your own custom types would be very unwise). In
>> fact, Heat allows you to specify a URL of a template file as a resource
>> type, and it sounds like that might run afoul of the same restriction.
>>
>> > If so, can we please update the heat plugin guide to reflect this?
>> > If not, we can file it is as a bug in Horizon.
>>
>> +1 for bug in Horizon.
>>
>> - ZB
>>
>> 
>> __
>> OpenStack Development Mailing List (not for usage questions)
>> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscrib
>> e
>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
>
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [Heat][Horizon] Any guidelines for naming heat resource type names?

2016-08-16 Thread Rob Cresswell 
This sounds like a bug on the Horizon side. There is/was a patch regarding a 
similar issue with LBaaS v2 resources too. It's likely just an incorrect 
assumption in the logic processing these names.

Rob

On 16 Aug 2016 11:03 p.m., "Zane Bitter" 
> wrote:
On 16/08/16 17:43, Praveen Yalagandula wrote:
> Hi all,
> We have developed some heat resources for our custom API server. We
> followed the instructions in the development guide
> at http://docs.openstack.org/developer/heat/pluginguide.html and got
> everything working. However, the Horizon "Resource Types" panel is
> returning a 500 error with "TemplateSyntaxError: u'resource'" message.
>
> Upon further debugging, we found that the Horizon is expecting all Heat
> resource type names to be of form
> . However, we didn't see this
> requirement in the heat development documents. Some of our resource
> types have just two words (e.g., "Avi::Pool"). Heat itself didn't care
> about these names at all.

Given that Heat has a REST API specifically for validating templates,
it's surprising that Horizon would implement its own, apparently
incorrect, validation.

> Question: Is there a general consensus is to enforce
> the  format for type names?

No. We don't really care what you call them (although using OS:: or
AWS:: as a prefix for your own custom types would be very unwise). In
fact, Heat allows you to specify a URL of a template file as a resource
type, and it sounds like that might run afoul of the same restriction.

> If so, can we please update the heat plugin guide to reflect this?
> If not, we can file it is as a bug in Horizon.

+1 for bug in Horizon.

- ZB

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: 
openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [Heat][Horizon] Any guidelines for naming heat resource type names?

2016-08-16 Thread Zane Bitter 

On 16/08/16 17:43, Praveen Yalagandula wrote:

Hi all,
We have developed some heat resources for our custom API server. We
followed the instructions in the development guide
at http://docs.openstack.org/developer/heat/pluginguide.html and got
everything working. However, the Horizon "Resource Types" panel is
returning a 500 error with "TemplateSyntaxError: u'resource'" message.

Upon further debugging, we found that the Horizon is expecting all Heat
resource type names to be of form
. However, we didn't see this
requirement in the heat development documents. Some of our resource
types have just two words (e.g., "Avi::Pool"). Heat itself didn't care
about these names at all.


Given that Heat has a REST API specifically for validating templates, 
it's surprising that Horizon would implement its own, apparently 
incorrect, validation.



Question: Is there a general consensus is to enforce
the  format for type names?


No. We don't really care what you call them (although using OS:: or 
AWS:: as a prefix for your own custom types would be very unwise). In 
fact, Heat allows you to specify a URL of a template file as a resource 
type, and it sounds like that might run afoul of the same restriction.



If so, can we please update the heat plugin guide to reflect this?
If not, we can file it is as a bug in Horizon.


+1 for bug in Horizon.

- ZB

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

[openstack-dev] [Heat][Horizon] Any guidelines for naming heat resource type names?

2016-08-16 Thread Praveen Yalagandula 
Hi all,
We have developed some heat resources for our custom API server. We
followed the instructions in the development guide at
http://docs.openstack.org/developer/heat/pluginguide.html and got
everything working. However, the Horizon "Resource Types" panel is
returning a 500 error with "TemplateSyntaxError: u'resource'" message.

Upon further debugging, we found that the Horizon is expecting all Heat
resource type names to be of form
. However, we didn't see this
requirement in the heat development documents. Some of our resource types
have just two words (e.g., "Avi::Pool"). Heat itself didn't care about
these names at all.

Question: Is there a general consensus is to enforce the

format for type names?
If so, can we please update the heat plugin guide to reflect this?
If not, we can file it is as a bug in Horizon.

Thanks,
Praveen
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev