Re: [openstack-dev] [Horizon] Angular action services and initScope

2016-07-20 Thread Richard Jones
Thanks for the response, Thai! Before I get into addressing your specifics below, I've put up a proof of concept patch that modifies images create-volume to remove the need for scope: https://review.openstack.org/#/c/345145 On 21 July 2016 at 08:23, Thai Q Tran wrote: >

Re: [openstack-dev] [Horizon] Angular action services and initScope

2016-07-20 Thread Thai Q Tran
You all sort of touched on what I am about to reiterate:   1. The scope was intended to be used as a way to propagate events up and down the chain (from table controller to step controller) since there was no real way to share information between controllers (remember that a modal dialog launches

Re: [openstack-dev] [Horizon] Angular action services and initScope

2016-07-18 Thread Richard Jones
On 18 July 2016 at 11:49, Rob Cresswell wrote: > Maybe I'm missing the point, but the schema stuff just defines a model and > passes it to the schema directive via ctrl; doesn't that remove any issues > with workflows? ui-bootstraps modal and modalinstance already

Re: [openstack-dev] [Horizon] Angular action services and initScope

2016-07-18 Thread Richard Jones
On 18 July 2016 at 11:34, Tripp, Travis S wrote: > TL;DR, I’ll be quite happy to get rid of the need for initScope and like > exploring a common way to share model other than events. > > |From: Richard Jones > | Date: Sunday, July 17, 2016 at 6:55

Re: [openstack-dev] [Horizon] Angular action services and initScope

2016-07-18 Thread Rob Cresswell
Maybe I'm missing the point, but the schema stuff just defines a model and passes it to the schema directive via ctrl; doesn't that remove any issues with workflows? ui-bootstraps modal and modalinstance already provides a way to pass that data back to the initial location (table etc) again

Re: [openstack-dev] [Horizon] Angular action services and initScope

2016-07-18 Thread Tripp, Travis S
TL;DR, I’ll be quite happy to get rid of the need for initScope and like exploring a common way to share model other than events. |From: Richard Jones | Date: Sunday, July 17, 2016 at 6:55 PM | I think this is a bad idea because in the angular world "factory" means

Re: [openstack-dev] [Horizon] Angular action services and initScope

2016-07-17 Thread Richard Jones
Richard > From: Richard Jones <r1chardj0...@gmail.com> > Reply-To: OpenStack List <openstack-dev@lists.openstack.org> > Date: Friday, July 15, 2016 at 2:28 PM > To: OpenStack List <openstack-dev@lists.openstack.org> > Subject: [openstack-dev] [Horiz

Re: [openstack-dev] [Horizon] Angular action services and initScope

2016-07-15 Thread Tripp, Travis S
dj0...@gmail.com> Reply-To: OpenStack List <openstack-dev@lists.openstack.org> Date: Friday, July 15, 2016 at 2:28 PM To: OpenStack List <openstack-dev@lists.openstack.org> Subject: [openstack-dev] [Horizon] Angular action services and initScope Hi folks, Something that's been bother

[openstack-dev] [Horizon] Angular action services and initScope

2016-07-15 Thread Richard Jones
Hi folks, Something that's been bothering me for a while is that the action services break the encapsulation model of Angular Services - that they are singletons, and consumable by multiple simultaneous consumers without those consumers affecting each other through their use of the Service. At