Re: [openstack-dev] [Horizon] Some thoughts about Horizon's test suite

2014-08-29 Thread Radomir Dopieralski
On 29/08/14 04:22, Richard Jones wrote: Very recently I attempted to fix a simple bug in which a Panel was being displayed when it shouldn't have been. The resultant 5-line fix ended up breaking 498 of the 1048 unit tests in the suite. I estimated that it would take about a week's effort to

Re: [openstack-dev] [Horizon] Some thoughts about Horizon's test suite

2014-08-29 Thread Richard Jones
Thanks for your thoughts Radomir. The nova api in question is memoized so it'll only be called once per request. Caching it for longer would be a very good idea, but that then brings into play deeper knowledge than I have about how long to cache things like nova extension configuration. Also, I

[openstack-dev] [Horizon] Some thoughts about Horizon's test suite

2014-08-28 Thread Richard Jones
I'm relatively new to Horizon, but I come with a bunch of experience with Python more generally. I've contributed a couple of small patches to Horizon in an effort to get more familiar with the codebase. Julie Pichon's blog post about testing in Horizon has been invaluable