Re: [openstack-dev] [Horizon] Update on Angular Identity work

2015-08-24 Thread Thai Q Tran
So I have been thinking about this topic a bit more and here are my thoughts on it.First, I think having a hybrid approach is do-able, as long as we know ahead of time what are the extension points we want to support. I am afraid that if you ask someone this question, the answer would be

Re: [openstack-dev] [Horizon] Update on Angular Identity work

2015-08-21 Thread Thai Q Tran
Hi Doug,I think your point is valid, but it would basically move the point of conflict from the HTML page to the controller. You could alleviate that problem by having services, aka service for headers, service for table batch action, etc that could then follow similar to the angular workflow

Re: [openstack-dev] [Horizon] Update on Angular Identity work

2015-08-21 Thread Tripp, Travis S
/core/images/table/images-table-row-details.html From: Thai Q Tran Reply-To: OpenStack List Date: Friday, August 21, 2015 at 1:38 PM To: OpenStack List Subject: Re: [openstack-dev] [Horizon] Update on Angular Identity work Hi Doug, I think your point is valid, but it would basically move the point

Re: [openstack-dev] [Horizon] Update on Angular Identity work

2015-08-20 Thread Lin Hua Cheng
: - To: OpenStack Development Mailing List (not for usage questions) openstack-dev@lists.openstack.org From: Lin Hua Cheng os.lch...@gmail.com Date: 08/19/2015 05:15PM Subject: Re: [openstack-dev] [Horizon] Update on Angular Identity work Hi Thai, Thanks for investigating the two options. Option 2 might

Re: [openstack-dev] [Horizon] Update on Angular Identity work

2015-08-20 Thread Doug Fish
questions) openstack-dev@lists.openstack.org From: Lin Hua Cheng os.lch...@gmail.com Date: 08/19/2015 05:15PM Subject: Re: [openstack-dev] [Horizon] Update on Angular Identity work Hi Thai, Thanks for investigating the two options. Option 2 might be better. Folks have to learn the new

Re: [openstack-dev] [Horizon] Update on Angular Identity work

2015-08-20 Thread Thai Q Tran
Hi Lin,Let me draw on some examples to help clarify what I mean.Option 1:table.controller.jsctrl.headers = { gettext('column 1'), gettext('column 2')};ctrl.noItemMessage = gettext('You no longer have any items in your table. You either lack the sufficient priveledges or your

Re: [openstack-dev] [Horizon] Update on Angular Identity work

2015-08-19 Thread Thai Q Tran
Hi Lin,I agree with you and Eric that we have a lot of HTML fragments. Some of them I think make sense as directives:The table footer is a good example of something we can convert into a directive:https://review.openstack.org/#/c/207631/The table header on the other hand is something more specific

Re: [openstack-dev] [Horizon] Update on Angular Identity work

2015-08-19 Thread Lin Hua Cheng
Cheng os.lch...@gmail.com wrote: - To: OpenStack Development Mailing List (not for usage questions) openstack-dev@lists.openstack.org From: Lin Hua Cheng os.lch...@gmail.com Date: 08/18/2015 02:36PM Cc: Vince Brunssen/Austin/IBM@IBMUS Subject: Re: [openstack-dev] [Horizon] Update on Angular

Re: [openstack-dev] [Horizon] Update on Angular Identity work

2015-08-18 Thread Thai Q Tran
Hi everyone,Just wanted to keep everyone up to date on the angular panels work. The goal was to set a pattern that others can follow, to that end, there were a few requirements:1. reusable and possibly pluggable2. easy to understand3. reduce code duplicationThese requirements don't always go

Re: [openstack-dev] [Horizon] Update on Angular Identity work

2015-08-18 Thread Lin Hua Cheng
I think the table setup pattern have some opportunity for reducing code duplication before it gets re-used by other panels.. We used to just need to write one file to define a table, now we have to write 9 files [1]. Can we have a table directive to reduce the duplicated code before moving