Re: [openstack-dev] [Infra] MyISAM as a default storage engine for MySQL in the gate
OK, so, we aren’t generally running neutron tests w/ MySQL + InnoDB, right? I happen to be running them locally against a MySQL that defaults to InnoDB. And I’m trying to see if it’s deadlocking or not as I’m not able to get through them. All the eventlet + MySQLdb deadlock issues won’t be apparent with MyISAM. On Jul 21, 2014, at 11:55 AM, Roman Podoliaka wrote: > Aha, makes sense. Yeah, this means we miss such a check at least in > Neutron and should add one to the test suite. Thanks! > > On Mon, Jul 21, 2014 at 6:34 PM, Clark Boylan wrote: >> >> On Jul 21, 2014 8:28 AM, "Roman Podoliaka" wrote: >>> >>> Hi all, >>> >>> To my surprise I found that we default to using MyISAM in the gate >>> [1], while InnoDB would be a much more suitable choice, which people >>> use in production deployments (== we should test it in the gate). This >>> means, that every table, for which we haven't explicitly specified to >>> use InnoDB, will be created using MyISAM engine, which is clearly not >>> what we want (and we have migration scripts at least in Neutron which >>> don't specify InnoDB explicitly and rely on MySQL configuration >>> value). >>> >>> Is there any specific reason we default to MyISAM? Or I should submit >>> a patch changing the default storage engine to be InnoDB? >>> >> We want projects to force the use of innodb over myisam. To test this the >> gate defaults to myisam and should check that innodb is used instead by the >> projects. So this is very intentional. >> >> Are we missing those checks in places? >> >> >>> >>> Thanks, >>> Roman >>> >>> [1] >>> https://github.com/openstack-infra/config/blob/master/modules/openstack_project/manifests/slave_db.pp#L12 >>> >>> ___ >>> OpenStack-dev mailing list >>> OpenStack-dev@lists.openstack.org >>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev >> >> Clark >> >> >> ___ >> OpenStack-dev mailing list >> OpenStack-dev@lists.openstack.org >> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev >> > > ___ > OpenStack-dev mailing list > OpenStack-dev@lists.openstack.org > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [Infra] MyISAM as a default storage engine for MySQL in the gate
Aha, makes sense. Yeah, this means we miss such a check at least in Neutron and should add one to the test suite. Thanks! On Mon, Jul 21, 2014 at 6:34 PM, Clark Boylan wrote: > > On Jul 21, 2014 8:28 AM, "Roman Podoliaka" wrote: >> >> Hi all, >> >> To my surprise I found that we default to using MyISAM in the gate >> [1], while InnoDB would be a much more suitable choice, which people >> use in production deployments (== we should test it in the gate). This >> means, that every table, for which we haven't explicitly specified to >> use InnoDB, will be created using MyISAM engine, which is clearly not >> what we want (and we have migration scripts at least in Neutron which >> don't specify InnoDB explicitly and rely on MySQL configuration >> value). >> >> Is there any specific reason we default to MyISAM? Or I should submit >> a patch changing the default storage engine to be InnoDB? >> > We want projects to force the use of innodb over myisam. To test this the > gate defaults to myisam and should check that innodb is used instead by the > projects. So this is very intentional. > > Are we missing those checks in places? > > >> >> Thanks, >> Roman >> >> [1] >> https://github.com/openstack-infra/config/blob/master/modules/openstack_project/manifests/slave_db.pp#L12 >> >> ___ >> OpenStack-dev mailing list >> OpenStack-dev@lists.openstack.org >> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > > Clark > > > ___ > OpenStack-dev mailing list > OpenStack-dev@lists.openstack.org > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
[openstack-dev] [Infra] MyISAM as a default storage engine for MySQL in the gate
Hi all, To my surprise I found that we default to using MyISAM in the gate [1], while InnoDB would be a much more suitable choice, which people use in production deployments (== we should test it in the gate). This means, that every table, for which we haven't explicitly specified to use InnoDB, will be created using MyISAM engine, which is clearly not what we want (and we have migration scripts at least in Neutron which don't specify InnoDB explicitly and rely on MySQL configuration value). Is there any specific reason we default to MyISAM? Or I should submit a patch changing the default storage engine to be InnoDB? Thanks, Roman [1] https://github.com/openstack-infra/config/blob/master/modules/openstack_project/manifests/slave_db.pp#L12 ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [Infra] MyISAM as a default storage engine for MySQL in the gate
On Jul 21, 2014 8:28 AM, "Roman Podoliaka" wrote: > > Hi all, > > To my surprise I found that we default to using MyISAM in the gate > [1], while InnoDB would be a much more suitable choice, which people > use in production deployments (== we should test it in the gate). This > means, that every table, for which we haven't explicitly specified to > use InnoDB, will be created using MyISAM engine, which is clearly not > what we want (and we have migration scripts at least in Neutron which > don't specify InnoDB explicitly and rely on MySQL configuration > value). > > Is there any specific reason we default to MyISAM? Or I should submit > a patch changing the default storage engine to be InnoDB? > We want projects to force the use of innodb over myisam. To test this the gate defaults to myisam and should check that innodb is used instead by the projects. So this is very intentional. Are we missing those checks in places? > > Thanks, > Roman > > [1] https://github.com/openstack-infra/config/blob/master/modules/openstack_project/manifests/slave_db.pp#L12 > > ___ > OpenStack-dev mailing list > OpenStack-dev@lists.openstack.org > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev Clark ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
