Re: [openstack-dev] [Infra] Rebase button enabled for all Gerrit users
On 02/13/2015 11:42 AM, Jeremy Stanley wrote: > For a few months, some project core teams (including Nova's) have > been running with an ACL granting access to the "rebase" button in > Gerrit for all the projects they manage, a permission usually only > exposed to the "owner" of an individual change. This has been > generally useful for them, especially when someone updates a commit > message via the Gerrit WebUI and there are changes depending on that > one which then show as outdated. So far they've seen no real > drawbacks, and since it's already possible for any Gerrit user to > locally rebase and push that to a change as an updated patchset > anyway we've deemed it generally safe to go ahead and expose that > button to everyone. > > If you encounter any unexpected issues you think might be related to > this behavior change, please let me or someone else in the Infra > team know about it. Thanks! > Nice, thanks. I had actually stopped updating commit messages inline on patch series because of the rebase issue. Sounds like this solves that problem. -Ben __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [Infra] Rebase button enabled for all Gerrit users
> On Feb 13, 2015, at 09:42, Jeremy Stanley wrote: > > For a few months, some project core teams (including Nova's) have > been running with an ACL granting access to the "rebase" button in > Gerrit for all the projects they manage, a permission usually only > exposed to the "owner" of an individual change. This has been > generally useful for them, especially when someone updates a commit > message via the Gerrit WebUI and there are changes depending on that > one which then show as outdated. So far they've seen no real > drawbacks, and since it's already possible for any Gerrit user to > locally rebase and push that to a change as an updated patchset > anyway we've deemed it generally safe to go ahead and expose that > button to everyone. > > If you encounter any unexpected issues you think might be related to > this behavior change, please let me or someone else in the Infra > team know about it. Thanks! > -- > Jeremy Stanley > > __ > OpenStack Development Mailing List (not for usage questions) > Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev Great change! Thanks! This will make managing changesets better overall. __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
[openstack-dev] [Infra] Rebase button enabled for all Gerrit users
For a few months, some project core teams (including Nova's) have been running with an ACL granting access to the "rebase" button in Gerrit for all the projects they manage, a permission usually only exposed to the "owner" of an individual change. This has been generally useful for them, especially when someone updates a commit message via the Gerrit WebUI and there are changes depending on that one which then show as outdated. So far they've seen no real drawbacks, and since it's already possible for any Gerrit user to locally rebase and push that to a change as an updated patchset anyway we've deemed it generally safe to go ahead and expose that button to everyone. If you encounter any unexpected issues you think might be related to this behavior change, please let me or someone else in the Infra team know about it. Thanks! -- Jeremy Stanley __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
