Re: [openstack-dev] [Ironic] January review redux

2014-02-05 Thread Ruby Loo
From: Devananda van der Veen mailto:devananda@gmail.com>> So, I'd like to nominate the following two additions to the ironic-core team: Max Lobur https://review.openstack.org/#/q/reviewer:mlobur%2540mirantis.com+project:openstack/ironic,n,z Roman Prykhodchenko https://review.openstack.org/#

Re: [openstack-dev] [Ironic] January review redux

2014-02-05 Thread Haomeng, Wang
+1 for both:) On Wed, Feb 5, 2014 at 6:08 PM, Yuriy Zveryanskyy wrote: > On 02/04/2014 09:42 PM, Devananda van der Veen wrote: > > So, I'd like to nominate the following two additions to the ironic-core > team: > > Max Lobur > https://review.openstack.org/#/q/reviewer:mlobur%2540mirantis.com+pro

Re: [openstack-dev] [Ironic] January review redux

2014-02-05 Thread Yuriy Zveryanskyy
On 02/04/2014 09:42 PM, Devananda van der Veen wrote: So, I'd like to nominate the following two additions to the ironic-core team: Max Lobur https://review.openstack.org/#/q/reviewer:mlobur%2540mirantis.com+project:openstack/ironic,n,z Roman Prykhodchenko https://review.openstack.org/#/q/rev

Re: [openstack-dev] [Ironic] January review redux

2014-02-05 Thread Lucas Alvares Gomes
> > So, I'd like to nominate the following two additions to the ironic-core > team: > > Max Lobur > > https://review.openstack.org/#/q/reviewer:mlobur%2540mirantis.com+project:openstack/ironic,n,z > > Roman Prykhodchenko > > https://review.openstack.org/#/q/reviewer:rprikhodchenko%2540mirantis.com+

Re: [openstack-dev] [Ironic] January review redux

2014-02-04 Thread Chris K
I have worked with both Max and Roman for sometime now, Both are very active in the Ironic IRC channel and are a pleasure to work with. They both have good grasp of the projects goals, and I look forward to having them as Ironic Core members. So with that I fully +1 both Max and Roman. (do two +1'

[openstack-dev] [Ironic] January review redux

2014-02-04 Thread Devananda van der Veen
The last month and a half had most of our team out for holiday leave at some point, and the review stats reflect that. I had hoped our review queue would come down once we all got back from the holidays, but that hasn't happened. In fact, our review queue has grown significantly Perhaps it's a