[openstack-dev] [Ironic] What to do with reservation check in node update API?

2015-07-21 Thread Dmitry Tantsur
Hi folks! If you're not aware already, I'm working on solving node is locked problems breaking users (and tracking it at https://etherpad.openstack.org/p/ironic-locking-reform). We have retries in place in client, but we all agree that it's not the eventual solution. One of the things we've

Re: [openstack-dev] [Ironic] What to do with reservation check in node update API?

2015-07-21 Thread Lucas Alvares Gomes
Hi, So, it looks like the only reason we check the reservation field here is because we want to return a 409 for node is locked rather than a 400, right? do_node_deploy and such will raise a NodeLocked, which should do the same as this check. It's unclear to me why we can't just remove this

Re: [openstack-dev] [Ironic] What to do with reservation check in node update API?

2015-07-21 Thread Lucas Alvares Gomes
Hi, Another question folks: while the problem above is valid and should be solved, I was actually keeping in mind another one: https://github.com/openstack/ironic/blob/master/ironic/api/controllers/v1/node.py#L1052-L1057 This is also not retried, and it prevents updating during power

Re: [openstack-dev] [Ironic] What to do with reservation check in node update API?

2015-07-21 Thread Dmitry Tantsur
On 07/21/2015 03:26 PM, Lucas Alvares Gomes wrote: Hi, So, it looks like the only reason we check the reservation field here is because we want to return a 409 for node is locked rather than a 400, right? do_node_deploy and such will raise a NodeLocked, which should do the same as this check.

Re: [openstack-dev] [Ironic] What to do with reservation check in node update API?

2015-07-21 Thread Dmitry Tantsur
On 07/21/2015 03:32 PM, Lucas Alvares Gomes wrote: Hi, Another question folks: while the problem above is valid and should be solved, I was actually keeping in mind another one: https://github.com/openstack/ironic/blob/master/ironic/api/controllers/v1/node.py#L1052-L1057 This is also not

Re: [openstack-dev] [Ironic] What to do with reservation check in node update API?

2015-07-21 Thread Dmitry Tantsur
On 07/21/2015 02:24 PM, Dmitry Tantsur wrote: Hi folks! If you're not aware already, I'm working on solving node is locked problems breaking users (and tracking it at https://etherpad.openstack.org/p/ironic-locking-reform). We have retries in place in client, but we all agree that it's not the

Re: [openstack-dev] [Ironic] What to do with reservation check in node update API?

2015-07-21 Thread Serge Kovaleff
I'd choose Option #2 Cheers, Serge Kovaleff http://www.mirantis.com cell: +38 (063) 83-155-70 On Tue, Jul 21, 2015 at 3:24 PM, Dmitry Tantsur dtant...@redhat.com wrote: Hi folks! If you're not aware already, I'm working on solving node is locked problems breaking users (and tracking it at

Re: [openstack-dev] [Ironic] What to do with reservation check in node update API?

2015-07-21 Thread Jim Rollenhagen
On Tue, Jul 21, 2015 at 02:24:14PM +0200, Dmitry Tantsur wrote: Hi folks! If you're not aware already, I'm working on solving node is locked problems breaking users (and tracking it at https://etherpad.openstack.org/p/ironic-locking-reform). We have retries in place in client, but we all

Re: [openstack-dev] [Ironic] What to do with reservation check in node update API?

2015-07-21 Thread Dmitry Tantsur
On 07/21/2015 03:01 PM, Jim Rollenhagen wrote: On Tue, Jul 21, 2015 at 02:24:14PM +0200, Dmitry Tantsur wrote: Hi folks! If you're not aware already, I'm working on solving node is locked problems breaking users (and tracking it at https://etherpad.openstack.org/p/ironic-locking-reform). We