Re: [openstack-dev] [Metrics][Nova] Another take on review turnaround stats

2013-07-01 Thread Russell Bryant
On 06/28/2013 06:49 PM, Nachi Ueno wrote: Hi Russell Your tool is awesome. I have also two idea (I believe it's not crazy :P ). 1) Show LOC of the review Long patch takes long time.. 2) Show priority of the review If it shows priority of the review, it wil be more useful, because we

Re: [openstack-dev] [Metrics][Nova] Another take on review turnaround stats

2013-06-28 Thread John Garbutt
Interesting, thanks for trying that. I think this is the time people feel the most. It should help set expectations on how long it will take to get your change into trunk. It seems, on average, to take two weeks. Hopefully it is useful to spot reviews that are proving tricky to get in, and they

Re: [openstack-dev] [Metrics][Nova] Another take on review turnaround stats

2013-06-28 Thread Christopher Yeoh
On Fri, Jun 28, 2013 at 12:12 PM, Russell Bryant rbry...@redhat.comwrote:The results are much better than I was afraid of. On average across all projects, patches waiting for review have an age of just under 14 days since they were first posted. Nova is below average, sitting at an average

Re: [openstack-dev] [Metrics][Nova] Another take on review turnaround stats

2013-06-28 Thread Russell Bryant
On 06/28/2013 08:24 AM, Christopher Yeoh wrote: How about time since first revision or -1 applied (but not including -1s by Jenkins due to gate flakiness), whichever is shorter. That eliminates non trivial rebases which I've found are often required after about 7 days but doesn't push out the

Re: [openstack-dev] [Metrics][Nova] Another take on review turnaround stats

2013-06-28 Thread Russell Bryant
On 06/28/2013 12:18 PM, Matt Riedemann wrote: Hey I made the list! _https://review.openstack.org/#/c/25355/_ Just wanted to point out for nova in longest-waiting reviews based on first revision: 1.94 days, 12 hours, 49 minutes - _https://review.openstack.org/25355_ (PowerVM