Re: [openstack-dev] [Neutron][FYI] Bookmarklet for neutron gerrit review
Fantastic! Works for me.
Thanks,
Carl
On Fri, May 9, 2014 at 3:33 AM, mar...@redhat.com wrote:
> On 08/05/14 21:29, Henry Gessau wrote:
>> Have any of you javascript gurus respun this for the new gerrit version?
>> Or can this now be done on the backend somehow?
>
> haha, have been thinking this since the gerrit upgrade a couple days
> ago. It was very useful for reviews... I am NOT a javascript guru but
> since it's Friday I gave myself 15 minutes to play with it - this works
> for me:
>
>
> javascript:(function(){
> list = document.querySelectorAll('table.commentPanelHeader');
> for(i in list) {
> title = list[i];
> if(! title.innerHTML) { continue; }
> text = title.nextSibling;
> if (text.innerHTML.search('Build failed') > 0) {
> title.style.color='red'
> } else if(title.innerHTML.search('Jenkins|CI|Ryu|Testing|Mine')
>>= 0) {
> title.style.color='#66'
> } else {
> title.style.color='blue'
> }
> }
> })()
>
>
> marios
>
>>
>> On Tue, Mar 04, at 4:00 pm, Carl Baldwin wrote:
>>
>>> Nachi,
>>>
>>> Great! I'd been meaning to do something like this. I took yours and
>>> tweaked it a bit to highlight failed Jenkins builds in red and grey
>>> other Jenkins messages. Human reviews are left in blue.
>>>
>>> javascript:(function(){
>>> list = document.querySelectorAll('td.GJEA35ODGC');
>>> for(i in list) {
>>> title = list[i];
>>> if(! title.innerHTML) { continue; }
>>> text = title.nextSibling;
>>> if (text.innerHTML.search('Build failed') > 0) {
>>> title.style.color='red'
>>> } else if(title.innerHTML.search('Jenkins|CI|Ryu|Testing|Mine') >=
>>> 0) {
>>> title.style.color='#66'
>>> } else {
>>> title.style.color='blue'
>>> }
>>> }
>>> })()
>>>
>>> Carl
>>>
>>> On Wed, Feb 26, 2014 at 12:31 PM, Nachi Ueno wrote:
Hi folks
I wrote an bookmarklet for neutron gerrit review.
This bookmarklet make the comment title for 3rd party ci as gray.
javascript:(function(){list =
document.querySelectorAll('td.GJEA35ODGC'); for(i in
list){if(!list[i].innerHTML){continue;};if(list[i].innerHTML &&
list[i].innerHTML.search('CI|Ryu|Testing|Mine') >
0){list[i].style.color='#66'}else{list[i].style.color='red'}};})()
enjoy :)
Nachi
___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>>
>>> ___
>>> OpenStack-dev mailing list
>>> OpenStack-dev@lists.openstack.org
>>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>>
>>
>>
>> ___
>> OpenStack-dev mailing list
>> OpenStack-dev@lists.openstack.org
>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>
>
>
> ___
> OpenStack-dev mailing list
> OpenStack-dev@lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [Neutron][FYI] Bookmarklet for neutron gerrit review
On Fri, May 9, 2014 at 4:39 AM, mar...@redhat.com wrote:
> On 09/05/14 12:33, mar...@redhat.com wrote:
>> On 08/05/14 21:29, Henry Gessau wrote:
>>> Have any of you javascript gurus respun this for the new gerrit version?
>>> Or can this now be done on the backend somehow?
>>
>> haha, have been thinking this since the gerrit upgrade a couple days
>> ago. It was very useful for reviews... I am NOT a javascript guru but
>> since it's Friday I gave myself 15 minutes to play with it - this works
>> for me:
>>
>>
>> javascript:(function(){
>> list = document.querySelectorAll('table.commentPanelHeader');
>> for(i in list) {
>> title = list[i];
>> if(! title.innerHTML) { continue; }
>> text = title.nextSibling;
>> if (text.innerHTML.search('Build failed') > 0) {
>> title.style.color='red'
>> } else if(title.innerHTML.search('Jenkins|CI|Ryu|Testing|Mine')
>>> = 0) {
>
> just noticed this ^^^ remove the extra newline here as it breaks, thanks
>
>> title.style.color='#66'
>> } else {
>> title.style.color='blue'
>> }
>> }
>> })()
>>
>>
Thanks Marios, this works for me now again!
Kyle
>> marios
>>
>>>
>>> On Tue, Mar 04, at 4:00 pm, Carl Baldwin wrote:
>>>
Nachi,
Great! I'd been meaning to do something like this. I took yours and
tweaked it a bit to highlight failed Jenkins builds in red and grey
other Jenkins messages. Human reviews are left in blue.
javascript:(function(){
list = document.querySelectorAll('td.GJEA35ODGC');
for(i in list) {
title = list[i];
if(! title.innerHTML) { continue; }
text = title.nextSibling;
if (text.innerHTML.search('Build failed') > 0) {
title.style.color='red'
} else if(title.innerHTML.search('Jenkins|CI|Ryu|Testing|Mine') >=
0) {
title.style.color='#66'
} else {
title.style.color='blue'
}
}
})()
Carl
On Wed, Feb 26, 2014 at 12:31 PM, Nachi Ueno wrote:
> Hi folks
>
> I wrote an bookmarklet for neutron gerrit review.
> This bookmarklet make the comment title for 3rd party ci as gray.
>
> javascript:(function(){list =
> document.querySelectorAll('td.GJEA35ODGC'); for(i in
> list){if(!list[i].innerHTML){continue;};if(list[i].innerHTML &&
> list[i].innerHTML.search('CI|Ryu|Testing|Mine') >
> 0){list[i].style.color='#66'}else{list[i].style.color='red'}};})()
>
> enjoy :)
> Nachi
>
> ___
> OpenStack-dev mailing list
> OpenStack-dev@lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>>
>>>
>>> ___
>>> OpenStack-dev mailing list
>>> OpenStack-dev@lists.openstack.org
>>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>>
>>
>>
>> ___
>> OpenStack-dev mailing list
>> OpenStack-dev@lists.openstack.org
>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>
>
>
> ___
> OpenStack-dev mailing list
> OpenStack-dev@lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [Neutron][FYI] Bookmarklet for neutron gerrit review
On 09/05/14 12:33, mar...@redhat.com wrote:
> On 08/05/14 21:29, Henry Gessau wrote:
>> Have any of you javascript gurus respun this for the new gerrit version?
>> Or can this now be done on the backend somehow?
>
> haha, have been thinking this since the gerrit upgrade a couple days
> ago. It was very useful for reviews... I am NOT a javascript guru but
> since it's Friday I gave myself 15 minutes to play with it - this works
> for me:
>
>
> javascript:(function(){
> list = document.querySelectorAll('table.commentPanelHeader');
> for(i in list) {
> title = list[i];
> if(! title.innerHTML) { continue; }
> text = title.nextSibling;
> if (text.innerHTML.search('Build failed') > 0) {
> title.style.color='red'
> } else if(title.innerHTML.search('Jenkins|CI|Ryu|Testing|Mine')
>> = 0) {
just noticed this ^^^ remove the extra newline here as it breaks, thanks
> title.style.color='#66'
> } else {
> title.style.color='blue'
> }
> }
> })()
>
>
> marios
>
>>
>> On Tue, Mar 04, at 4:00 pm, Carl Baldwin wrote:
>>
>>> Nachi,
>>>
>>> Great! I'd been meaning to do something like this. I took yours and
>>> tweaked it a bit to highlight failed Jenkins builds in red and grey
>>> other Jenkins messages. Human reviews are left in blue.
>>>
>>> javascript:(function(){
>>> list = document.querySelectorAll('td.GJEA35ODGC');
>>> for(i in list) {
>>> title = list[i];
>>> if(! title.innerHTML) { continue; }
>>> text = title.nextSibling;
>>> if (text.innerHTML.search('Build failed') > 0) {
>>> title.style.color='red'
>>> } else if(title.innerHTML.search('Jenkins|CI|Ryu|Testing|Mine') >=
>>> 0) {
>>> title.style.color='#66'
>>> } else {
>>> title.style.color='blue'
>>> }
>>> }
>>> })()
>>>
>>> Carl
>>>
>>> On Wed, Feb 26, 2014 at 12:31 PM, Nachi Ueno wrote:
Hi folks
I wrote an bookmarklet for neutron gerrit review.
This bookmarklet make the comment title for 3rd party ci as gray.
javascript:(function(){list =
document.querySelectorAll('td.GJEA35ODGC'); for(i in
list){if(!list[i].innerHTML){continue;};if(list[i].innerHTML &&
list[i].innerHTML.search('CI|Ryu|Testing|Mine') >
0){list[i].style.color='#66'}else{list[i].style.color='red'}};})()
enjoy :)
Nachi
___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>>
>>> ___
>>> OpenStack-dev mailing list
>>> OpenStack-dev@lists.openstack.org
>>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>>
>>
>>
>> ___
>> OpenStack-dev mailing list
>> OpenStack-dev@lists.openstack.org
>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>
>
>
> ___
> OpenStack-dev mailing list
> OpenStack-dev@lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [Neutron][FYI] Bookmarklet for neutron gerrit review
On 08/05/14 21:29, Henry Gessau wrote:
> Have any of you javascript gurus respun this for the new gerrit version?
> Or can this now be done on the backend somehow?
haha, have been thinking this since the gerrit upgrade a couple days
ago. It was very useful for reviews... I am NOT a javascript guru but
since it's Friday I gave myself 15 minutes to play with it - this works
for me:
javascript:(function(){
list = document.querySelectorAll('table.commentPanelHeader');
for(i in list) {
title = list[i];
if(! title.innerHTML) { continue; }
text = title.nextSibling;
if (text.innerHTML.search('Build failed') > 0) {
title.style.color='red'
} else if(title.innerHTML.search('Jenkins|CI|Ryu|Testing|Mine')
>= 0) {
title.style.color='#66'
} else {
title.style.color='blue'
}
}
})()
marios
>
> On Tue, Mar 04, at 4:00 pm, Carl Baldwin wrote:
>
>> Nachi,
>>
>> Great! I'd been meaning to do something like this. I took yours and
>> tweaked it a bit to highlight failed Jenkins builds in red and grey
>> other Jenkins messages. Human reviews are left in blue.
>>
>> javascript:(function(){
>> list = document.querySelectorAll('td.GJEA35ODGC');
>> for(i in list) {
>> title = list[i];
>> if(! title.innerHTML) { continue; }
>> text = title.nextSibling;
>> if (text.innerHTML.search('Build failed') > 0) {
>> title.style.color='red'
>> } else if(title.innerHTML.search('Jenkins|CI|Ryu|Testing|Mine') >=
>> 0) {
>> title.style.color='#66'
>> } else {
>> title.style.color='blue'
>> }
>> }
>> })()
>>
>> Carl
>>
>> On Wed, Feb 26, 2014 at 12:31 PM, Nachi Ueno wrote:
>>> Hi folks
>>>
>>> I wrote an bookmarklet for neutron gerrit review.
>>> This bookmarklet make the comment title for 3rd party ci as gray.
>>>
>>> javascript:(function(){list =
>>> document.querySelectorAll('td.GJEA35ODGC'); for(i in
>>> list){if(!list[i].innerHTML){continue;};if(list[i].innerHTML &&
>>> list[i].innerHTML.search('CI|Ryu|Testing|Mine') >
>>> 0){list[i].style.color='#66'}else{list[i].style.color='red'}};})()
>>>
>>> enjoy :)
>>> Nachi
>>>
>>> ___
>>> OpenStack-dev mailing list
>>> OpenStack-dev@lists.openstack.org
>>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>
>> ___
>> OpenStack-dev mailing list
>> OpenStack-dev@lists.openstack.org
>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>
>
>
> ___
> OpenStack-dev mailing list
> OpenStack-dev@lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [Neutron][FYI] Bookmarklet for neutron gerrit review
Henry,
I haven't gotten further than noticing that mine no longer works.
It'd be great to put this in to gerrit somehow. It was useful.
Carl
On Thu, May 8, 2014 at 12:29 PM, Henry Gessau wrote:
> Have any of you javascript gurus respun this for the new gerrit version?
> Or can this now be done on the backend somehow?
>
> On Tue, Mar 04, at 4:00 pm, Carl Baldwin wrote:
>
>> Nachi,
>>
>> Great! I'd been meaning to do something like this. I took yours and
>> tweaked it a bit to highlight failed Jenkins builds in red and grey
>> other Jenkins messages. Human reviews are left in blue.
>>
>> javascript:(function(){
>> list = document.querySelectorAll('td.GJEA35ODGC');
>> for(i in list) {
>> title = list[i];
>> if(! title.innerHTML) { continue; }
>> text = title.nextSibling;
>> if (text.innerHTML.search('Build failed') > 0) {
>> title.style.color='red'
>> } else if(title.innerHTML.search('Jenkins|CI|Ryu|Testing|Mine') >=
>> 0) {
>> title.style.color='#66'
>> } else {
>> title.style.color='blue'
>> }
>> }
>> })()
>>
>> Carl
>>
>> On Wed, Feb 26, 2014 at 12:31 PM, Nachi Ueno wrote:
>>> Hi folks
>>>
>>> I wrote an bookmarklet for neutron gerrit review.
>>> This bookmarklet make the comment title for 3rd party ci as gray.
>>>
>>> javascript:(function(){list =
>>> document.querySelectorAll('td.GJEA35ODGC'); for(i in
>>> list){if(!list[i].innerHTML){continue;};if(list[i].innerHTML &&
>>> list[i].innerHTML.search('CI|Ryu|Testing|Mine') >
>>> 0){list[i].style.color='#66'}else{list[i].style.color='red'}};})()
>>>
>>> enjoy :)
>>> Nachi
>>>
>>> ___
>>> OpenStack-dev mailing list
>>> OpenStack-dev@lists.openstack.org
>>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>
>> ___
>> OpenStack-dev mailing list
>> OpenStack-dev@lists.openstack.org
>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>
>
>
> ___
> OpenStack-dev mailing list
> OpenStack-dev@lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [Neutron][FYI] Bookmarklet for neutron gerrit review
Have any of you javascript gurus respun this for the new gerrit version?
Or can this now be done on the backend somehow?
On Tue, Mar 04, at 4:00 pm, Carl Baldwin wrote:
> Nachi,
>
> Great! I'd been meaning to do something like this. I took yours and
> tweaked it a bit to highlight failed Jenkins builds in red and grey
> other Jenkins messages. Human reviews are left in blue.
>
> javascript:(function(){
> list = document.querySelectorAll('td.GJEA35ODGC');
> for(i in list) {
> title = list[i];
> if(! title.innerHTML) { continue; }
> text = title.nextSibling;
> if (text.innerHTML.search('Build failed') > 0) {
> title.style.color='red'
> } else if(title.innerHTML.search('Jenkins|CI|Ryu|Testing|Mine') >= 0)
> {
> title.style.color='#66'
> } else {
> title.style.color='blue'
> }
> }
> })()
>
> Carl
>
> On Wed, Feb 26, 2014 at 12:31 PM, Nachi Ueno wrote:
>> Hi folks
>>
>> I wrote an bookmarklet for neutron gerrit review.
>> This bookmarklet make the comment title for 3rd party ci as gray.
>>
>> javascript:(function(){list =
>> document.querySelectorAll('td.GJEA35ODGC'); for(i in
>> list){if(!list[i].innerHTML){continue;};if(list[i].innerHTML &&
>> list[i].innerHTML.search('CI|Ryu|Testing|Mine') >
>> 0){list[i].style.color='#66'}else{list[i].style.color='red'}};})()
>>
>> enjoy :)
>> Nachi
>>
>> ___
>> OpenStack-dev mailing list
>> OpenStack-dev@lists.openstack.org
>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
> ___
> OpenStack-dev mailing list
> OpenStack-dev@lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [Neutron][FYI] Bookmarklet for neutron gerrit review
On 04/03/14 23:00, Carl Baldwin wrote:
> Nachi,
>
> Great! I'd been meaning to do something like this. I took yours and
> tweaked it a bit to highlight failed Jenkins builds in red and grey
> other Jenkins messages. Human reviews are left in blue.
>
> javascript:(function(){
> list = document.querySelectorAll('td.GJEA35ODGC');
> for(i in list) {
> title = list[i];
> if(! title.innerHTML) { continue; }
> text = title.nextSibling;
> if (text.innerHTML.search('Build failed') > 0) {
> title.style.color='red'
> } else if(title.innerHTML.search('Jenkins|CI|Ryu|Testing|Mine') >= 0)
> {
> title.style.color='#66'
> } else {
> title.style.color='blue'
> }
> }
> })()
>
> Carl
>
> On Wed, Feb 26, 2014 at 12:31 PM, Nachi Ueno wrote:
>> Hi folks
>>
>> I wrote an bookmarklet for neutron gerrit review.
>> This bookmarklet make the comment title for 3rd party ci as gray.
>>
>> javascript:(function(){list =
>> document.querySelectorAll('td.GJEA35ODGC'); for(i in
>> list){if(!list[i].innerHTML){continue;};if(list[i].innerHTML &&
>> list[i].innerHTML.search('CI|Ryu|Testing|Mine') >
>> 0){list[i].style.color='#66'}else{list[i].style.color='red'}};})()
>>
>> enjoy :)
>> Nachi
thanks! for some weird reason I've never even tried bookmarklets before.
This is a great help for neutron reviews - its becoming really easy to
miss human comments between all the ci and test reports
marios
>>
>> ___
>> OpenStack-dev mailing list
>> OpenStack-dev@lists.openstack.org
>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
> ___
> OpenStack-dev mailing list
> OpenStack-dev@lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [Neutron][FYI] Bookmarklet for neutron gerrit review
+1
I think there should be naming standard for all reviews (e.g. [test] Jenkins,
[test-external] VMware) so that gerrit css can colorize automatic review
comments no matter the project.
m.
On Mar 7, 2014, at 2:08 AM, Chmouel Boudjnah wrote:
> if peoples like this why don't we have it directly on the reviews?
>
> Chmouel.
>
>
> On Tue, Mar 4, 2014 at 10:00 PM, Carl Baldwin wrote:
> Nachi,
>
> Great! I'd been meaning to do something like this. I took yours and
> tweaked it a bit to highlight failed Jenkins builds in red and grey
> other Jenkins messages. Human reviews are left in blue.
>
> javascript:(function(){
> list = document.querySelectorAll('td.GJEA35ODGC');
> for(i in list) {
> title = list[i];
> if(! title.innerHTML) { continue; }
> text = title.nextSibling;
> if (text.innerHTML.search('Build failed') > 0) {
> title.style.color='red'
> } else if(title.innerHTML.search('Jenkins|CI|Ryu|Testing|Mine') >= 0)
> {
> title.style.color='#66'
> } else {
> title.style.color='blue'
> }
> }
> })()
>
> Carl
>
> On Wed, Feb 26, 2014 at 12:31 PM, Nachi Ueno wrote:
> > Hi folks
> >
> > I wrote an bookmarklet for neutron gerrit review.
> > This bookmarklet make the comment title for 3rd party ci as gray.
> >
> > javascript:(function(){list =
> > document.querySelectorAll('td.GJEA35ODGC'); for(i in
> > list){if(!list[i].innerHTML){continue;};if(list[i].innerHTML &&
> > list[i].innerHTML.search('CI|Ryu|Testing|Mine') >
> > 0){list[i].style.color='#66'}else{list[i].style.color='red'}};})()
> >
> > enjoy :)
> > Nachi
> >
> > ___
> > OpenStack-dev mailing list
> > OpenStack-dev@lists.openstack.org
> > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
> ___
> OpenStack-dev mailing list
> OpenStack-dev@lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
> ___
> OpenStack-dev mailing list
> OpenStack-dev@lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [Neutron][FYI] Bookmarklet for neutron gerrit review
if peoples like this why don't we have it directly on the reviews?
Chmouel.
On Tue, Mar 4, 2014 at 10:00 PM, Carl Baldwin wrote:
> Nachi,
>
> Great! I'd been meaning to do something like this. I took yours and
> tweaked it a bit to highlight failed Jenkins builds in red and grey
> other Jenkins messages. Human reviews are left in blue.
>
> javascript:(function(){
> list = document.querySelectorAll('td.GJEA35ODGC');
> for(i in list) {
> title = list[i];
> if(! title.innerHTML) { continue; }
> text = title.nextSibling;
> if (text.innerHTML.search('Build failed') > 0) {
> title.style.color='red'
> } else if(title.innerHTML.search('Jenkins|CI|Ryu|Testing|Mine') >=
> 0) {
> title.style.color='#66'
> } else {
> title.style.color='blue'
> }
> }
> })()
>
> Carl
>
> On Wed, Feb 26, 2014 at 12:31 PM, Nachi Ueno wrote:
> > Hi folks
> >
> > I wrote an bookmarklet for neutron gerrit review.
> > This bookmarklet make the comment title for 3rd party ci as gray.
> >
> > javascript:(function(){list =
> > document.querySelectorAll('td.GJEA35ODGC'); for(i in
> > list){if(!list[i].innerHTML){continue;};if(list[i].innerHTML &&
> > list[i].innerHTML.search('CI|Ryu|Testing|Mine') >
> > 0){list[i].style.color='#66'}else{list[i].style.color='red'}};})()
> >
> > enjoy :)
> > Nachi
> >
> > ___
> > OpenStack-dev mailing list
> > OpenStack-dev@lists.openstack.org
> > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
> ___
> OpenStack-dev mailing list
> OpenStack-dev@lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [Neutron][FYI] Bookmarklet for neutron gerrit review
Nachi,
Great! I'd been meaning to do something like this. I took yours and
tweaked it a bit to highlight failed Jenkins builds in red and grey
other Jenkins messages. Human reviews are left in blue.
javascript:(function(){
list = document.querySelectorAll('td.GJEA35ODGC');
for(i in list) {
title = list[i];
if(! title.innerHTML) { continue; }
text = title.nextSibling;
if (text.innerHTML.search('Build failed') > 0) {
title.style.color='red'
} else if(title.innerHTML.search('Jenkins|CI|Ryu|Testing|Mine') >= 0) {
title.style.color='#66'
} else {
title.style.color='blue'
}
}
})()
Carl
On Wed, Feb 26, 2014 at 12:31 PM, Nachi Ueno wrote:
> Hi folks
>
> I wrote an bookmarklet for neutron gerrit review.
> This bookmarklet make the comment title for 3rd party ci as gray.
>
> javascript:(function(){list =
> document.querySelectorAll('td.GJEA35ODGC'); for(i in
> list){if(!list[i].innerHTML){continue;};if(list[i].innerHTML &&
> list[i].innerHTML.search('CI|Ryu|Testing|Mine') >
> 0){list[i].style.color='#66'}else{list[i].style.color='red'}};})()
>
> enjoy :)
> Nachi
>
> ___
> OpenStack-dev mailing list
> OpenStack-dev@lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
[openstack-dev] [Neutron][FYI] Bookmarklet for neutron gerrit review
Hi folks
I wrote an bookmarklet for neutron gerrit review.
This bookmarklet make the comment title for 3rd party ci as gray.
javascript:(function(){list =
document.querySelectorAll('td.GJEA35ODGC'); for(i in
list){if(!list[i].innerHTML){continue;};if(list[i].innerHTML &&
list[i].innerHTML.search('CI|Ryu|Testing|Mine') >
0){list[i].style.color='#66'}else{list[i].style.color='red'}};})()
enjoy :)
Nachi
___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
