Re: [openstack-dev] [Neutron][FYI] Bookmarklet for neutron gerrit review

2014-05-09 Thread mar...@redhat.com
On 08/05/14 21:29, Henry Gessau wrote: Have any of you javascript gurus respun this for the new gerrit version? Or can this now be done on the backend somehow? haha, have been thinking this since the gerrit upgrade a couple days ago. It was very useful for reviews... I am NOT a javascript guru

Re: [openstack-dev] [Neutron][FYI] Bookmarklet for neutron gerrit review

2014-05-09 Thread mar...@redhat.com
On 09/05/14 12:33, mar...@redhat.com wrote: On 08/05/14 21:29, Henry Gessau wrote: Have any of you javascript gurus respun this for the new gerrit version? Or can this now be done on the backend somehow? haha, have been thinking this since the gerrit upgrade a couple days ago. It was very

Re: [openstack-dev] [Neutron][FYI] Bookmarklet for neutron gerrit review

2014-05-09 Thread Kyle Mestery
On Fri, May 9, 2014 at 4:39 AM, mar...@redhat.com mandr...@redhat.com wrote: On 09/05/14 12:33, mar...@redhat.com wrote: On 08/05/14 21:29, Henry Gessau wrote: Have any of you javascript gurus respun this for the new gerrit version? Or can this now be done on the backend somehow? haha, have

Re: [openstack-dev] [Neutron][FYI] Bookmarklet for neutron gerrit review

2014-05-09 Thread Carl Baldwin
Fantastic! Works for me. Thanks, Carl On Fri, May 9, 2014 at 3:33 AM, mar...@redhat.com mandr...@redhat.com wrote: On 08/05/14 21:29, Henry Gessau wrote: Have any of you javascript gurus respun this for the new gerrit version? Or can this now be done on the backend somehow? haha, have been

Re: [openstack-dev] [Neutron][FYI] Bookmarklet for neutron gerrit review

2014-05-08 Thread Henry Gessau
Have any of you javascript gurus respun this for the new gerrit version? Or can this now be done on the backend somehow? On Tue, Mar 04, at 4:00 pm, Carl Baldwin wrote: Nachi, Great! I'd been meaning to do something like this. I took yours and tweaked it a bit to highlight failed Jenkins

Re: [openstack-dev] [Neutron][FYI] Bookmarklet for neutron gerrit review

2014-05-08 Thread Carl Baldwin
Henry, I haven't gotten further than noticing that mine no longer works. It'd be great to put this in to gerrit somehow. It was useful. Carl On Thu, May 8, 2014 at 12:29 PM, Henry Gessau ges...@cisco.com wrote: Have any of you javascript gurus respun this for the new gerrit version? Or can

Re: [openstack-dev] [Neutron][FYI] Bookmarklet for neutron gerrit review

2014-03-10 Thread Maru Newby
+1 I think there should be naming standard for all reviews (e.g. [test] Jenkins, [test-external] VMware) so that gerrit css can colorize automatic review comments no matter the project. m. On Mar 7, 2014, at 2:08 AM, Chmouel Boudjnah chmo...@enovance.com wrote: if peoples like this why

Re: [openstack-dev] [Neutron][FYI] Bookmarklet for neutron gerrit review

2014-03-07 Thread Chmouel Boudjnah
if peoples like this why don't we have it directly on the reviews? Chmouel. On Tue, Mar 4, 2014 at 10:00 PM, Carl Baldwin c...@ecbaldwin.net wrote: Nachi, Great! I'd been meaning to do something like this. I took yours and tweaked it a bit to highlight failed Jenkins builds in red and

Re: [openstack-dev] [Neutron][FYI] Bookmarklet for neutron gerrit review

2014-03-04 Thread Carl Baldwin
Nachi, Great! I'd been meaning to do something like this. I took yours and tweaked it a bit to highlight failed Jenkins builds in red and grey other Jenkins messages. Human reviews are left in blue. javascript:(function(){ list = document.querySelectorAll('td.GJEA35ODGC'); for(i in

[openstack-dev] [Neutron][FYI] Bookmarklet for neutron gerrit review

2014-02-26 Thread Nachi Ueno
Hi folks I wrote an bookmarklet for neutron gerrit review. This bookmarklet make the comment title for 3rd party ci as gray. javascript:(function(){list = document.querySelectorAll('td.GJEA35ODGC'); for(i in list){if(!list[i].innerHTML){continue;};if(list[i].innerHTML