Re: [openstack-dev] [Neutron] [Spec freeze exception] ml2-use-dpdkvhost
Speaking as someone who was reviewing both specs, I would personally recommend you grant both exceptions. The code changes are very limited in scope - particularly the Nova one - which makes the code review simple, and they're highly unlikely to affect anyone who isn't actually using DPDK OVS (subject to the Neutron tests for its presence being solid), which makes them low risk. For even lower risk, we could have a config option to enable the test for a CUSE-based binding (and yes, I know earlier in the review everyone was against config items, but specifically what we didn't want was *two* config items, one in Nova nd one in Neutron, that only worked if they were in agreement; one solely in Neutron would, I think, be acceptable). All this subject to Sean getting all the CRs out of his spec, and maybe we could add a spec test for that, because it's a right pain to have specs full of CRs if you're trying to diff them online... -- Ian. On 23 July 2014 11:10, Mooney, Sean K wrote: > Hi kyle > > Thanks for your provisional support. > I would agree that unless the nova spec is also granted an exception both > specs should be moved > To Kilo. > > I have now uploaded the most recent version of the specs. > They are available to review here: > https://blueprints.launchpad.net/nova/+spec/libvirt-ovs-use-usvhost > https://blueprints.launchpad.net/neutron/+spec/ml2-use-dpdkvhost > > regards > sean > > > -Original Message- > From: Kyle Mestery [mailto:mest...@mestery.com] > Sent: Tuesday, July 22, 2014 2:47 PM > To: OpenStack Development Mailing List (not for usage questions) > Subject: Re: [openstack-dev] [Neutron] [Spec freeze exception] > ml2-use-dpdkvhost > > On Mon, Jul 21, 2014 at 10:04 AM, Mooney, Sean K > wrote: > > Hi > > > > I would like to propose > > https://review.openstack.org/#/c/107797/1/specs/juno/ml2-use-dpdkvhost > > .rst > > for a spec freeze exception. > > > > > > > > https://blueprints.launchpad.net/neutron/+spec/ml2-use-dpdkvhost > > > > > > > > This blueprint adds support for the Intel(R) DPDK Userspace vHost > > > > port binding to the Open Vswitch and Open Daylight ML2 Mechanism Drivers. > > > In general, I'd be ok with approving an exception for this BP. > However, please see below. > > > > > > > This blueprint enables nova changes tracked by the following spec: > > > > https://review.openstack.org/#/c/95805/1/specs/juno/libvirt-ovs-use-us > > vhost.rst > > > This BP appears to also require an exception from the Nova team. I think > these both require exceptions for this work to have a shot at landing in > Juno. Given this, I'm actually leaning to move this to Kilo. But if you can > get a Nova freeze exception, I'd consider the same for the Neutron BP. > > Thanks, > Kyle > > > > > > > regards > > > > sean > > > > -- > > Intel Shannon Limited > > Registered in Ireland > > Registered Office: Collinstown Industrial Park, Leixlip, County > > Kildare Registered Number: 308263 Business address: Dromore House, > > East Park, Shannon, Co. Clare > > > > This e-mail and any attachments may contain confidential material for > > the sole use of the intended recipient(s). Any review or distribution > > by others is strictly prohibited. If you are not the intended > > recipient, please contact the sender and delete all copies. > > > > > > ___ > > OpenStack-dev mailing list > > OpenStack-dev@lists.openstack.org > > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > > > > ___ > OpenStack-dev mailing list > OpenStack-dev@lists.openstack.org > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > -- > Intel Shannon Limited > Registered in Ireland > Registered Office: Collinstown Industrial Park, Leixlip, County Kildare > Registered Number: 308263 > Business address: Dromore House, East Park, Shannon, Co. Clare > > This e-mail and any attachments may contain confidential material for the > sole use of the intended recipient(s). Any review or distribution by others > is strictly prohibited. If you are not the intended recipient, please > contact the sender and delete all copies. > > > > ___ > OpenStack-dev mailing list > OpenStack-dev@lists.openstack.org > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [Neutron] [Spec freeze exception] ml2-use-dpdkvhost
Hi kyle Thanks for your provisional support. I would agree that unless the nova spec is also granted an exception both specs should be moved To Kilo. I have now uploaded the most recent version of the specs. They are available to review here: https://blueprints.launchpad.net/nova/+spec/libvirt-ovs-use-usvhost https://blueprints.launchpad.net/neutron/+spec/ml2-use-dpdkvhost regards sean -Original Message- From: Kyle Mestery [mailto:mest...@mestery.com] Sent: Tuesday, July 22, 2014 2:47 PM To: OpenStack Development Mailing List (not for usage questions) Subject: Re: [openstack-dev] [Neutron] [Spec freeze exception] ml2-use-dpdkvhost On Mon, Jul 21, 2014 at 10:04 AM, Mooney, Sean K wrote: > Hi > > I would like to propose > https://review.openstack.org/#/c/107797/1/specs/juno/ml2-use-dpdkvhost > .rst > for a spec freeze exception. > > > > https://blueprints.launchpad.net/neutron/+spec/ml2-use-dpdkvhost > > > > This blueprint adds support for the Intel(R) DPDK Userspace vHost > > port binding to the Open Vswitch and Open Daylight ML2 Mechanism Drivers. > In general, I'd be ok with approving an exception for this BP. However, please see below. > > > This blueprint enables nova changes tracked by the following spec: > > https://review.openstack.org/#/c/95805/1/specs/juno/libvirt-ovs-use-us > vhost.rst > This BP appears to also require an exception from the Nova team. I think these both require exceptions for this work to have a shot at landing in Juno. Given this, I'm actually leaning to move this to Kilo. But if you can get a Nova freeze exception, I'd consider the same for the Neutron BP. Thanks, Kyle > > > regards > > sean > > -- > Intel Shannon Limited > Registered in Ireland > Registered Office: Collinstown Industrial Park, Leixlip, County > Kildare Registered Number: 308263 Business address: Dromore House, > East Park, Shannon, Co. Clare > > This e-mail and any attachments may contain confidential material for > the sole use of the intended recipient(s). Any review or distribution > by others is strictly prohibited. If you are not the intended > recipient, please contact the sender and delete all copies. > > > ___ > OpenStack-dev mailing list > OpenStack-dev@lists.openstack.org > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev -- Intel Shannon Limited Registered in Ireland Registered Office: Collinstown Industrial Park, Leixlip, County Kildare Registered Number: 308263 Business address: Dromore House, East Park, Shannon, Co. Clare This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies. ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [Neutron] [Spec freeze exception] ml2-use-dpdkvhost
On Mon, Jul 21, 2014 at 10:04 AM, Mooney, Sean K wrote: > Hi > > I would like to propose > https://review.openstack.org/#/c/107797/1/specs/juno/ml2-use-dpdkvhost.rst > for a spec freeze exception. > > > > https://blueprints.launchpad.net/neutron/+spec/ml2-use-dpdkvhost > > > > This blueprint adds support for the Intel(R) DPDK Userspace vHost > > port binding to the Open Vswitch and Open Daylight ML2 Mechanism Drivers. > In general, I'd be ok with approving an exception for this BP. However, please see below. > > > This blueprint enables nova changes tracked by the following spec: > > https://review.openstack.org/#/c/95805/1/specs/juno/libvirt-ovs-use-usvhost.rst > This BP appears to also require an exception from the Nova team. I think these both require exceptions for this work to have a shot at landing in Juno. Given this, I'm actually leaning to move this to Kilo. But if you can get a Nova freeze exception, I'd consider the same for the Neutron BP. Thanks, Kyle > > > regards > > sean > > -- > Intel Shannon Limited > Registered in Ireland > Registered Office: Collinstown Industrial Park, Leixlip, County Kildare > Registered Number: 308263 > Business address: Dromore House, East Park, Shannon, Co. Clare > > This e-mail and any attachments may contain confidential material for the > sole use of the intended recipient(s). Any review or distribution by others > is strictly prohibited. If you are not the intended recipient, please > contact the sender and delete all copies. > > > ___ > OpenStack-dev mailing list > OpenStack-dev@lists.openstack.org > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
[openstack-dev] [Neutron] [Spec freeze exception] ml2-use-dpdkvhost
Hi I would like to propose https://review.openstack.org/#/c/107797/1/specs/juno/ml2-use-dpdkvhost.rst for a spec freeze exception. https://blueprints.launchpad.net/neutron/+spec/ml2-use-dpdkvhost This blueprint adds support for the Intel(R) DPDK Userspace vHost port binding to the Open Vswitch and Open Daylight ML2 Mechanism Drivers. This blueprint enables nova changes tracked by the following spec: https://review.openstack.org/#/c/95805/1/specs/juno/libvirt-ovs-use-usvhost.rst regards sean -- Intel Shannon Limited Registered in Ireland Registered Office: Collinstown Industrial Park, Leixlip, County Kildare Registered Number: 308263 Business address: Dromore House, East Park, Shannon, Co. Clare This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies. ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
