Re: [openstack-dev] [Neutron] - breaking changes for plugins/drivers

2015-07-02 Thread Assaf Muller
- Original Message - I think we need to revisit the test infrastructure requirement. We have a lot of logic to setup and test plugins/drivers and making each repo duplicate all of that is a pretty big waste of effort. Maybe some base stuff should go in neutron lib? Absolutely.

Re: [openstack-dev] [Neutron] - breaking changes for plugins/drivers

2015-07-02 Thread Ihar Hrachyshka
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 07/01/2015 04:09 PM, Kyle Mestery wrote: On Wed, Jul 1, 2015 at 5:49 AM, Kevin Benton blak...@gmail.com mailto:blak...@gmail.com wrote: For the second one, I think we made it clear before that no plugins must rely on neutron.openstack.*

Re: [openstack-dev] [Neutron] - breaking changes for plugins/drivers

2015-07-01 Thread Kyle Mestery
On Wed, Jul 1, 2015 at 5:49 AM, Kevin Benton blak...@gmail.com wrote: For the second one, I think we made it clear before that no plugins must rely on neutron.openstack.* contents. Where was this made clear? I didn't know about this until it broke and I'm a very frequent contributor and

Re: [openstack-dev] [Neutron] - breaking changes for plugins/drivers

2015-07-01 Thread Gary Kotton
@lists.openstack.orgmailto:openstack-dev@lists.openstack.org Date: Wednesday, July 1, 2015 at 1:49 PM To: OpenStack List openstack-dev@lists.openstack.orgmailto:openstack-dev@lists.openstack.org Subject: Re: [openstack-dev] [Neutron] - breaking changes for plugins/drivers For the second one, I think we made it clear

Re: [openstack-dev] [Neutron] - breaking changes for plugins/drivers

2015-07-01 Thread Kevin Benton
For the second one, I think we made it clear before that no plugins must rely on neutron.openstack.* contents. Where was this made clear? I didn't know about this until it broke and I'm a very frequent contributor and reviewer, which is the core of my complaint. The updated wiki is helpful, but

Re: [openstack-dev] [Neutron] - breaking changes for plugins/drivers

2015-07-01 Thread Doug Wiegley
On Jun 30, 2015, at 11:22 PM, Kevin Benton blak...@gmail.com wrote: Hi, We have had at least two breaking changes merge this week for out-of-tree drivers/plugins. These are just the two I noticed that broke the Big Switch CI (the one I keep an eye on since I had set it up): 1.

Re: [openstack-dev] [Neutron] - breaking changes for plugins/drivers

2015-07-01 Thread Kevin Benton
I think we need to revisit the test infrastructure requirement. We have a lot of logic to setup and test plugins/drivers and making each repo duplicate all of that is a pretty big waste of effort. Maybe some base stuff should go in neutron lib? On Jul 1, 2015 12:32 PM, Doug Wiegley

Re: [openstack-dev] [Neutron] - breaking changes for plugins/drivers

2015-07-01 Thread Ihar Hrachyshka
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 07/01/2015 08:22 AM, Kevin Benton wrote: Hi, We have had at least two breaking changes merge this week for out-of-tree drivers/plugins. These are just the two I noticed that broke the Big Switch CI (the one I keep an eye on since I had set

Re: [openstack-dev] [Neutron] - breaking changes for plugins/drivers

2015-07-01 Thread Joshua Harlow
Doug Wiegley wrote: On Jun 30, 2015, at 11:22 PM, Kevin Benton blak...@gmail.com mailto:blak...@gmail.com wrote: Hi, We have had at least two breaking changes merge this week for out-of-tree drivers/plugins. These are just the two I noticed that broke the Big Switch CI (the one I keep an eye

[openstack-dev] [Neutron] - breaking changes for plugins/drivers

2015-06-30 Thread Kevin Benton
Hi, We have had at least two breaking changes merge this week for out-of-tree drivers/plugins. These are just the two I noticed that broke the Big Switch CI (the one I keep an eye on since I had set it up): 1. Removed test_lib that changes config files. https://review.openstack.org/#/c/196583/