Re: [openstack-dev] [OpenStack-Infra] Gerrit Upgrade to ver 2.11, completed.
On Wed, Dec 23, 2015 at 5:54 PM, Clark Boylan wrote: > I got curious and this is an odd situation. I can't find where 212669 > has a patchset with a parent of the commit for 192032,37 (b7151e4). Git > represents the tree as a DAG with each child commit pointing at its > parent(s). Parents do not know who their children are. When 212669 has a > patchset with a parent that maps to a valid 192032 patchset everything > works (see 212669,30 and 192032,36 for example) but when 192032 has a > patchset with no children in 212669 it gets confused. This all makes sense. > This makes some sense given Git's internal DAG. Gerrit knows 212669 is > related to 192032 via the other patchsets, but it can't associate to a > specific patchset. I am not sure yet if the selection of patchset 4 is > intentional design and does something that would make sense if I > understood it better or if it is a bug in a best effort approach. The > most correct thing to do would be for 192032,37 to not show any > association to 212669 since there doesn't exist a Git DAG with that > relationship. I can't imagine any use case where linking me to PS4 here would be helpful. :) If it did what you suggest (not show any association) then all dependencies would disappear from view each time a parent change is updated until the children got rebased. It might be the most correct thing to do if you limit your thinking to the patch set level dependency dag. But, isn't what I'd call the most correct thing to do from a user's perspective. I'd like gerrit to first use a change set level dag that looks like the below. (A "change" has a number like C where a patch has a number like C/PP. A change is a collection of patches.) for child_change in all open changes latest_patch = most recent patch set of child_change for git_parent in latest_patch's git_parents parent_change = get_change_from_git_commit(git_parent) if parent_change is open add child_change -> parent_change to dag This dag is derived from the patch set level dag but is more often than not what I'm really interested in as a user. I want to know whether another open change's most recent patch set depends on this change. That's the most important thing. It is much less often that I'm actually interested in the patch set level dependencies. Once gerrit does that correctly, then it could look at the patch set level dag to give me a little more detail. "Has that change been rebased to the latest patch in this change (or is it "out of date")?" Or, if I'm looking at a specific patch set within a change, it can show me a little more detail. "C/PP depends on this patch set." "C/PP depends on this patch set but the latest version of C no longer depends on this change." Stuff like that. Carl __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [OpenStack-Infra] Gerrit Upgrade to ver 2.11, completed.
On Wed, Dec 23, 2015, at 03:00 PM, Carl Baldwin wrote: > On Wed, Dec 23, 2015 at 3:40 PM, Zaro wrote: > > On Tue, Dec 22, 2015 at 4:51 PM, Carl Baldwin wrote: > >> I noticed another thing. I'm working with a chain of three patches. > >> I just updated the patch in the middle [1] to patch set 37. I noticed > >> that the list of "Related Changes" (in the upper right of the page) > >> didn't look right. The change above it in the list (the one that > >> depends it) looked strange. Looking closer, I realized that the > >> dependent patch was linking to patch set 4 [2] which is really old. > >> Go here [1] and take a look. > >> > >> The latest patch set in 212669 (24) depends on a slightly out of date > >> version of 192032 (36 of 37). So, gerrit decides to navigate me to > >> version 4 of 212669? Seems arbitrary to me. Why doesn't it navigate > >> me to the latest version of 212669? That would be much more useful. > > > > I believe what Gerrit is doing is linking to the PS that was based off > > of the one you are currently on. You can see this by checking the > > parent and next commit SHA. So it looks like 212669/4 is based on > > 192032/10 therefore I'm guessing that you were actually looking at > > 192032/10 when you clicked on the link. I'm not sure that Gerrit took > > you to the wrong PS I'm guessing that you were on a newer 212669 PS > > than you thought? I find this disorienting as well and always have > > to remind myself to look at the "Patch Sets" indicator to get on the > > right page. > > No, I was looking at PS37 of 192032. Exactly the patch set that I > linked to. I just checked again by click on the link [1] and looking > at the related changes in the upper right corner. Do it. What patch > set of change 212669 do you see linked from here [1]? If you are not > seeing 212669/4 , then you are seeing something different than I am. > It isn't only disorienting. IMO, it is wrong. > > >> [1] https://review.openstack.org/#/c/192032/37 > >> [2] https://review.openstack.org/#/c/212669/4 > I got curious and this is an odd situation. I can't find where 212669 has a patchset with a parent of the commit for 192032,37 (b7151e4). Git represents the tree as a DAG with each child commit pointing at its parent(s). Parents do not know who their children are. When 212669 has a patchset with a parent that maps to a valid 192032 patchset everything works (see 212669,30 and 192032,36 for example) but when 192032 has a patchset with no children in 212669 it gets confused. This makes some sense given Git's internal DAG. Gerrit knows 212669 is related to 192032 via the other patchsets, but it can't associate to a specific patchset. I am not sure yet if the selection of patchset 4 is intentional design and does something that would make sense if I understood it better or if it is a bug in a best effort approach. The most correct thing to do would be for 192032,37 to not show any association to 212669 since there doesn't exist a Git DAG with that relationship. Clark __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [OpenStack-Infra] Gerrit Upgrade to ver 2.11, completed.
On Wed, Dec 23, 2015 at 1:16 AM, Michał Dulko wrote: > n goes to next occurrence and N (shift+n) to a previous one. These are > same keybindings as in Vim. Actually a lot of Vim-like movements are > functional in new Gerrit and I really like that fact. I'll admit that I started to get excited about the vim-like movements. My fingers know them pretty well. But, now this new interface is driving me even more crazy! Here's why: Things like 'v' works to highlight parts of the code. I found the following all worked: 'b', 'w', 'h', 'l', '400G', and some more. But, then my fingers started doing things that ended up sending me all over the place. For example, after discovering that 'b' and 'w' work, you'd expect 'e' to work similarly. Nope, that throws you in the editor (which I'm not nearly as excited about as everyone else seems to be). Then, I tried 'fM' to put the cursor on the next occurrence of 'M'. I have no idea why but I ended up in a different file altogether. There were a couple others that I didn't take careful note of but this afternoon trying out vim keys has been a disaster. The problem here is that I've been a vi(m) user since high school. I don't think about the navigation commands, they are all in muscle memory. So, to start using vim muscle memory at all in gerrit is dangerous. Who knows what is going to happen because they only partially (and apparently arbitrarily) implemented the movement commands and didn't document which ones work and which ones to watch out for because they have a different meaning in gerrit. So, the end result is that I'm learning a whole new way of navigating without the proper documentation to help. Carl __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [OpenStack-Infra] Gerrit Upgrade to ver 2.11, completed.
On Wed, Dec 23, 2015 at 3:40 PM, Zaro wrote: > On Tue, Dec 22, 2015 at 4:51 PM, Carl Baldwin wrote: >> I noticed another thing. I'm working with a chain of three patches. >> I just updated the patch in the middle [1] to patch set 37. I noticed >> that the list of "Related Changes" (in the upper right of the page) >> didn't look right. The change above it in the list (the one that >> depends it) looked strange. Looking closer, I realized that the >> dependent patch was linking to patch set 4 [2] which is really old. >> Go here [1] and take a look. >> >> The latest patch set in 212669 (24) depends on a slightly out of date >> version of 192032 (36 of 37). So, gerrit decides to navigate me to >> version 4 of 212669? Seems arbitrary to me. Why doesn't it navigate >> me to the latest version of 212669? That would be much more useful. > > I believe what Gerrit is doing is linking to the PS that was based off > of the one you are currently on. You can see this by checking the > parent and next commit SHA. So it looks like 212669/4 is based on > 192032/10 therefore I'm guessing that you were actually looking at > 192032/10 when you clicked on the link. I'm not sure that Gerrit took > you to the wrong PS I'm guessing that you were on a newer 212669 PS > than you thought? I find this disorienting as well and always have > to remind myself to look at the "Patch Sets" indicator to get on the > right page. No, I was looking at PS37 of 192032. Exactly the patch set that I linked to. I just checked again by click on the link [1] and looking at the related changes in the upper right corner. Do it. What patch set of change 212669 do you see linked from here [1]? If you are not seeing 212669/4 , then you are seeing something different than I am. It isn't only disorienting. IMO, it is wrong. >> [1] https://review.openstack.org/#/c/192032/37 >> [2] https://review.openstack.org/#/c/212669/4 __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [OpenStack-Infra] Gerrit Upgrade to ver 2.11, completed.
On Tue, Dec 22, 2015 at 4:51 PM, Carl Baldwin wrote: > I noticed another thing. I'm working with a chain of three patches. > I just updated the patch in the middle [1] to patch set 37. I noticed > that the list of "Related Changes" (in the upper right of the page) > didn't look right. The change above it in the list (the one that > depends it) looked strange. Looking closer, I realized that the > dependent patch was linking to patch set 4 [2] which is really old. > Go here [1] and take a look. > > The latest patch set in 212669 (24) depends on a slightly out of date > version of 192032 (36 of 37). So, gerrit decides to navigate me to > version 4 of 212669? Seems arbitrary to me. Why doesn't it navigate > me to the latest version of 212669? That would be much more useful. I believe what Gerrit is doing is linking to the PS that was based off of the one you are currently on. You can see this by checking the parent and next commit SHA. So it looks like 212669/4 is based on 192032/10 therefore I'm guessing that you were actually looking at 192032/10 when you clicked on the link. I'm not sure that Gerrit took you to the wrong PS I'm guessing that you were on a newer 212669 PS than you thought? I find this disorienting as well and always have to remind myself to look at the "Patch Sets" indicator to get on the right page. > > Over the last few days, this "Related Changes" table has confused me. > This is the first time I took the time to pinpoint why it is confusing > me. > > Carl > > PS I'm trying to document these issues in this thread so that they > don't get lost. I suppose at some point we need to be feeding this > stuff up to gerrit. I was hoping to get other stuff done before > vacation and so I'm hesitant to stop what I'm doing and shift my > thinking toward filling out bug reports against gerrit. What should > we do? Should we individually go file bugs against gerrit? Or, > should we funnel it through someone working on gerrit in openstack? Thanks for keeping the openstack infra team updated about issues you're having with Gerrit, it's good feedback and will help improve Gerrit going forward. Unless it's something that requires immediate attention I would recommend entering a bug/feature request yourself on upstream Gerrit issue tracker. You can CC me on the issues and I will try to determine whether it's openstack specific or a general upstream issue. > > [1] https://review.openstack.org/#/c/192032/37 > [2] https://review.openstack.org/#/c/212669/4 > __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [OpenStack-Infra] Gerrit Upgrade to ver 2.11, completed.
On Wed, Dec 23, 2015 at 1:57 PM, Elizabeth K. Joseph wrote: > On Wed, Dec 23, 2015 at 10:11 AM, Carl Baldwin wrote: >> I do see that a lot of vim movement does work. I was hoping that >> holding down a movement command like 'j' would rapidly move down but >> it doesn't. :( > > Earlier in the thread zaro mentioned this in passing, but to be more > specific: hitting '?' will bring up a menu of keyboard shortcuts that > can be used. This works in various screens throughout the Gerrit web > UI. No guessing required as to what shortcuts exist or how they work. I'm aware of the '?' help and have found it lacking. I've still had to guess at how they work (or don't work) in some cases. For example, where are many of the vim movement commands documented (besides j/k which I knew about by reading the help)? I missed the navigation to the next/previous search result because it isn't documented with shift + n but is with n. I missed it. And it doesn't excuse the awful overloading of n and shift + n which breaks navigation by chunks once you start using the search feature. I really haven't been impressed by many of the new features because they all seem to come with awkward baggage. Carl I __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [OpenStack-Infra] Gerrit Upgrade to ver 2.11, completed.
These look like upstream issues. Best thing to do is report these bugs upstream: https://code.google.com/p/gerrit/issues/list On Tue, Dec 22, 2015 at 11:25 AM, Aishwarya Thangappa wrote: > Hi there, > > I noticed a couple of things which I would like to see fixed. > 1. When you try to reply to a review comment, it jumps to the previous or > next comment and you have to scroll again to get back to it. > 2. When you scroll down through a file, the Patch Set bar gets hidden. You > have to scroll all the way up to see it again. > I saw this behavior with both chrome and firefox. > > Aish. > __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [OpenStack-Infra] Gerrit Upgrade to ver 2.11, completed.
On Wed, Dec 23, 2015 at 10:11 AM, Carl Baldwin wrote: > I do see that a lot of vim movement does work. I was hoping that > holding down a movement command like 'j' would rapidly move down but > it doesn't. :( Earlier in the thread zaro mentioned this in passing, but to be more specific: hitting '?' will bring up a menu of keyboard shortcuts that can be used. This works in various screens throughout the Gerrit web UI. No guessing required as to what shortcuts exist or how they work. -- Elizabeth Krumbach Joseph || Lyz || pleia2 __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [OpenStack-Infra] Gerrit Upgrade to ver 2.11, completed.
On Wed, Dec 23, 2015 at 1:16 AM, Michał Dulko wrote: > n goes to next occurrence and N (shift+n) to a previous one. These are > same keybindings as in Vim. Actually a lot of Vim-like movements are > functional in new Gerrit and I really like that fact. Thanks. Looking again, I see that the help for 'n' does hint at that. It is a strange overloading of the key binding because then navigating comments no longer seems to work after I start searching. How could I go back to navigating comments? I tried hitting '/' again and the ESC to cancel searching but the comment navigation doesn't always come back. I do see that a lot of vim movement does work. I was hoping that holding down a movement command like 'j' would rapidly move down but it doesn't. :( Carl __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [OpenStack-Infra] Gerrit Upgrade to ver 2.11, completed.
On 12/22/2015 10:52 PM, Carl Baldwin wrote: > On Mon, Dec 21, 2015 at 6:21 PM, Zaro wrote: >> Hit '?' and it says '/' is find, give that a try. > '/' isn't really much better. It seems to highlight all of the > occurrences but I can't find a way to navigate to the next/previous > occurence with the keyboard. I see that the scroll bar shows a small > indication that there are many matches within the file and so I could > scroll to them if I want to move my fingers to the trackpad to scroll. n goes to next occurrence and N (shift+n) to a previous one. These are same keybindings as in Vim. Actually a lot of Vim-like movements are functional in new Gerrit and I really like that fact. __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [OpenStack-Infra] Gerrit Upgrade to ver 2.11, completed.
I noticed another thing. I'm working with a chain of three patches.
I just updated the patch in the middle [1] to patch set 37. I noticed
that the list of "Related Changes" (in the upper right of the page)
didn't look right. The change above it in the list (the one that
depends it) looked strange. Looking closer, I realized that the
dependent patch was linking to patch set 4 [2] which is really old.
Go here [1] and take a look.
The latest patch set in 212669 (24) depends on a slightly out of date
version of 192032 (36 of 37). So, gerrit decides to navigate me to
version 4 of 212669? Seems arbitrary to me. Why doesn't it navigate
me to the latest version of 212669? That would be much more useful.
Over the last few days, this "Related Changes" table has confused me.
This is the first time I took the time to pinpoint why it is confusing
me.
Carl
PS I'm trying to document these issues in this thread so that they
don't get lost. I suppose at some point we need to be feeding this
stuff up to gerrit. I was hoping to get other stuff done before
vacation and so I'm hesitant to stop what I'm doing and shift my
thinking toward filling out bug reports against gerrit. What should
we do? Should we individually go file bugs against gerrit? Or,
should we funnel it through someone working on gerrit in openstack?
[1] https://review.openstack.org/#/c/192032/37
[2] https://review.openstack.org/#/c/212669/4
On Mon, Dec 21, 2015 at 4:07 PM, Carl Baldwin wrote:
> I noticed a couple of things today while reviewing a largish page [1].
> First, when I search for something using the browser's builtin search
> (Chrome, Mac OSX Yosemite), it doesn't seem to find occurrences that
> are not in the visible portion of the page. For example, when I
> search for DNSDOMAIN, I get 1 hit from the top of the file. The file
> actually has almost 30 hits for this string. For example, scroll down
> to about L310 in the file. You'll see them all over the place (and
> now Chrome's search finds these hits if you try again). I use to use
> search within a file with the old gerrit and never noticed this
> problem.
>
> The other thing that I found annoying is when I scroll the page with
> my trackpad, it now jumps around sometimes to a different part of the
> page. For example, I'll scroll up to find a spot in the file and when
> I think I've arrived, it will jump back down the file a bit. It is
> disorienting. Of course, now it isn't doing it anymore so it doesn't
> seem to be all the time. It was behaving this way for a good 20
> minutes trying to get through this file.
>
> Carl
>
> Carl
>
> [1] https://review.openstack.org/#/c/212213/36/neutron/db/dns_db.py
>
> On Thu, Dec 17, 2015 at 8:17 PM, Brian Haley wrote:
>> On 2015-12-16 16:24, openstack-dev-requ...@lists.openstack.org wrote:
>>>
>>> Thanks to everyone for their patience while we upgraded to Gerrit
>>> 2.11. I'm happy to announce that we were able to successfully
>>> completed this task at around 21:00 UTC. You may hack away once more.
>>>
>>> If you encounter any problems, please let us know here or in
>>> #openstack-infra on Freenode.
>>
>>
>> I'm still undecided on 2.11, have to give it more time, but I have noticed
>> one thing that's annoying...
>>
>> Trying to copy text from a review no longer works easily. When I highlight
>> text there's a little "bubble" pop-up of {press c to comment}, which seems
>> to interfere with both my three-button mouse copy buffer, as well as Ctrl-C.
>> Call me a nitpicker, but having to highlight text, right-button click, Copy,
>> right-button click, Paste, is a pain.
>>
>> Maybe someone has a simple work-around for that.
>>
>> -Brian
>>
>> __
>> OpenStack Development Mailing List (not for usage questions)
>> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [OpenStack-Infra] Gerrit Upgrade to ver 2.11, completed.
On Mon, Dec 21, 2015 at 6:21 PM, Zaro wrote: > Hit '?' and it says '/' is find, give that a try. '/' isn't really much better. It seems to highlight all of the occurrences but I can't find a way to navigate to the next/previous occurence with the keyboard. I see that the scroll bar shows a small indication that there are many matches within the file and so I could scroll to them if I want to move my fingers to the trackpad to scroll. Also, it only searches for text in the file. Today, I wanted to search for comments from a particular author by searching for that person's name on the page. It only found the first two (of four) because the others were down the page. To me, this is a pretty annoying regression from 2.8. > Looks like in Gerrit 2.11 the 'f' to get a popup of the list of files > is only available in unified diff view. I don't remember if it was > available in side-by-side view on Gerrit 2.8. Yes, it was available in 2.8 in side-by-side view, I used it often. It is unfortunate that it only works in unified diff view. I tried switching to unified diff view in a file. It worked but then when I used it to navigate to another file, it switched back to side-by-side diff mode and the file list was sort of stuck to the page in an odd way where the file list was visible but was behind the side-by-side diff. It made the whole page unreadable. Essentially, I'll have to switch my default to unified view for it to be useful. Carl __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [OpenStack-Infra] Gerrit Upgrade to ver 2.11, completed.
I had the same issue with Android. I eventually had to give up and leave comments on the patch instead of specific line numbers. On Tue, Dec 22, 2015 at 8:13 AM, Jay Bryant wrote: > All, > > Has anyone found a way to do code reviews on an iPad. In the old Gerrit > you could. With the new interface attempts to enter comments don't work. It > looks like you should be able to enter text but when you type the page just > jumps around. Very frustrating. > > I have tried Safari and Chrome with no luck. > > Jay > > On Tue, Dec 22, 2015 at 5:31 AM Steve Gordon wrote: > >> - Original Message - >> > From: "Lenny Verkhovsky" >> > To: "OpenStack Development Mailing List (not for usage questions)" < >> openstack-dev@lists.openstack.org> >> > >> > Hi, >> > After Upgrading to 2.11 seems that >> > lastcomment ( >> > >> https://github.com/openstack/third-party-ci-tools/tree/master/monitoring/lastcomment-scoreboard >> > ) >> > monitoring tool stopped working >> > >> > I've posted a small patch https://review.openstack.org/#/c/259083/ to >> fix the >> > issue, >> > But I wander if there is a proper rest query to for CI name? >> > Currently there is only account_id field in Gerrit response and it's not >> > really human readable. >> >> I ran into this with a custom script as well, you can use the account_id >> in a request of the form: >> >> review.openstack.org/accounts//name >> >> ...to get a human readable account name. >> >> -Steve >> >> > Lennyb. >> > >> > >> > -Original Message- >> > From: Zaro [mailto:zaro0...@gmail.com] >> > Sent: Tuesday, December 22, 2015 3:21 AM >> > To: OpenStack Development Mailing List (not for usage questions) >> > >> > Subject: Re: [openstack-dev] [OpenStack-Infra] Gerrit Upgrade to ver >> 2.11, >> > completed. >> > >> > Hit '?' and it says '/' is find, give that a try. >> > >> > Looks like in Gerrit 2.11 the 'f' to get a popup of the list of files >> is only >> > available in unified diff view. I don't remember if it was available in >> > side-by-side view on Gerrit 2.8. >> > >> > -Khai >> > >> > >> > On Mon, Dec 21, 2015 at 5:04 PM, Carl Baldwin >> wrote: >> > > I also really miss being able to pull up the list of files in diff >> > > view with the 'f' key. Any equivalent? >> > > >> > > Carl >> > > >> > > On Mon, Dec 21, 2015 at 4:07 PM, Carl Baldwin >> wrote: >> > >> I noticed a couple of things today while reviewing a largish page >> [1]. >> > >> First, when I search for something using the browser's builtin search >> > >> (Chrome, Mac OSX Yosemite), it doesn't seem to find occurrences that >> > >> are not in the visible portion of the page. For example, when I >> > >> search for DNSDOMAIN, I get 1 hit from the top of the file. The file >> > >> actually has almost 30 hits for this string. For example, scroll >> > >> down to about L310 in the file. You'll see them all over the place >> > >> (and now Chrome's search finds these hits if you try again). I use >> > >> to use search within a file with the old gerrit and never noticed >> > >> this problem. >> > >> >> > >> The other thing that I found annoying is when I scroll the page with >> > >> my trackpad, it now jumps around sometimes to a different part of the >> > >> page. For example, I'll scroll up to find a spot in the file and >> > >> when I think I've arrived, it will jump back down the file a bit. It >> > >> is disorienting. Of course, now it isn't doing it anymore so it >> > >> doesn't seem to be all the time. It was behaving this way for a good >> > >> 20 minutes trying to get through this file. >> > >> >> > >> Carl >> > >> >> > >> Carl >> > >> >> > >> [1] https://review.openstack.org/#/c/212213/36/neutron/db/dns_db.py >> > >> >> > >> On Thu, Dec 17, 2015 at 8:17 PM, Brian Haley >> wrote: >> > >>> On 2015-12-16 16:24, openstack-dev-requ...@lists.openstack.org >> wrote: >> > >>>> >> > &g
Re: [openstack-dev] [OpenStack-Infra] Gerrit Upgrade to ver 2.11, completed.
Hi there, I noticed a couple of things which I would like to see fixed. 1. When you try to reply to a review comment, it jumps to the previous or next comment and you have to scroll again to get back to it. 2. When you scroll down through a file, the Patch Set bar gets hidden. You have to scroll all the way up to see it again. I saw this behavior with both chrome and firefox. Aish. > On Dec 22, 2015, at 7:13 AM, Jay Bryant wrote: > > All, > > Has anyone found a way to do code reviews on an iPad. In the old Gerrit you > could. With the new interface attempts to enter comments don't work. It > looks like you should be able to enter text but when you type the page just > jumps around. Very frustrating. > > I have tried Safari and Chrome with no luck. > > Jay > > On Tue, Dec 22, 2015 at 5:31 AM Steve Gordon <mailto:sgor...@redhat.com>> wrote: > - Original Message - > > From: "Lenny Verkhovsky" mailto:len...@mellanox.com>> > > To: "OpenStack Development Mailing List (not for usage questions)" > > > <mailto:openstack-dev@lists.openstack.org>> > > > > Hi, > > After Upgrading to 2.11 seems that > > lastcomment ( > > https://github.com/openstack/third-party-ci-tools/tree/master/monitoring/lastcomment-scoreboard > > > > <https://github.com/openstack/third-party-ci-tools/tree/master/monitoring/lastcomment-scoreboard> > > ) > > monitoring tool stopped working > > > > I've posted a small patch https://review.openstack.org/#/c/259083/ > > <https://review.openstack.org/#/c/259083/> to fix the > > issue, > > But I wander if there is a proper rest query to for CI name? > > Currently there is only account_id field in Gerrit response and it's not > > really human readable. > > I ran into this with a custom script as well, you can use the account_id in a > request of the form: > > review.openstack.org/accounts/ > <http://review.openstack.org/accounts/>/name > > ...to get a human readable account name. > > -Steve > > > Lennyb. > > > > > > -Original Message----- > > From: Zaro [mailto:zaro0...@gmail.com <mailto:zaro0...@gmail.com>] > > Sent: Tuesday, December 22, 2015 3:21 AM > > To: OpenStack Development Mailing List (not for usage questions) > > > <mailto:openstack-dev@lists.openstack.org>> > > Subject: Re: [openstack-dev] [OpenStack-Infra] Gerrit Upgrade to ver 2.11, > > completed. > > > > Hit '?' and it says '/' is find, give that a try. > > > > Looks like in Gerrit 2.11 the 'f' to get a popup of the list of files is > > only > > available in unified diff view. I don't remember if it was available in > > side-by-side view on Gerrit 2.8. > > > > -Khai > > > > > > On Mon, Dec 21, 2015 at 5:04 PM, Carl Baldwin > <mailto:c...@ecbaldwin.net>> wrote: > > > I also really miss being able to pull up the list of files in diff > > > view with the 'f' key. Any equivalent? > > > > > > Carl > > > > > > On Mon, Dec 21, 2015 at 4:07 PM, Carl Baldwin > > <mailto:c...@ecbaldwin.net>> wrote: > > >> I noticed a couple of things today while reviewing a largish page [1]. > > >> First, when I search for something using the browser's builtin search > > >> (Chrome, Mac OSX Yosemite), it doesn't seem to find occurrences that > > >> are not in the visible portion of the page. For example, when I > > >> search for DNSDOMAIN, I get 1 hit from the top of the file. The file > > >> actually has almost 30 hits for this string. For example, scroll > > >> down to about L310 in the file. You'll see them all over the place > > >> (and now Chrome's search finds these hits if you try again). I use > > >> to use search within a file with the old gerrit and never noticed > > >> this problem. > > >> > > >> The other thing that I found annoying is when I scroll the page with > > >> my trackpad, it now jumps around sometimes to a different part of the > > >> page. For example, I'll scroll up to find a spot in the file and > > >> when I think I've arrived, it will jump back down the file a bit. It > > >> is disorienting. Of course, now it isn't doing it anymore so it > > >> doesn't seem to be all the time. It was behaving this way for a good > > >> 20 minutes trying to get through this file. > > >>
Re: [openstack-dev] [OpenStack-Infra] Gerrit Upgrade to ver 2.11, completed.
All, Has anyone found a way to do code reviews on an iPad. In the old Gerrit you could. With the new interface attempts to enter comments don't work. It looks like you should be able to enter text but when you type the page just jumps around. Very frustrating. I have tried Safari and Chrome with no luck. Jay On Tue, Dec 22, 2015 at 5:31 AM Steve Gordon wrote: > - Original Message - > > From: "Lenny Verkhovsky" > > To: "OpenStack Development Mailing List (not for usage questions)" < > openstack-dev@lists.openstack.org> > > > > Hi, > > After Upgrading to 2.11 seems that > > lastcomment ( > > > https://github.com/openstack/third-party-ci-tools/tree/master/monitoring/lastcomment-scoreboard > > ) > > monitoring tool stopped working > > > > I've posted a small patch https://review.openstack.org/#/c/259083/ to > fix the > > issue, > > But I wander if there is a proper rest query to for CI name? > > Currently there is only account_id field in Gerrit response and it's not > > really human readable. > > I ran into this with a custom script as well, you can use the account_id > in a request of the form: > > review.openstack.org/accounts//name > > ...to get a human readable account name. > > -Steve > > > Lennyb. > > > > > > -Original Message----- > > From: Zaro [mailto:zaro0...@gmail.com] > > Sent: Tuesday, December 22, 2015 3:21 AM > > To: OpenStack Development Mailing List (not for usage questions) > > > > Subject: Re: [openstack-dev] [OpenStack-Infra] Gerrit Upgrade to ver > 2.11, > > completed. > > > > Hit '?' and it says '/' is find, give that a try. > > > > Looks like in Gerrit 2.11 the 'f' to get a popup of the list of files is > only > > available in unified diff view. I don't remember if it was available in > > side-by-side view on Gerrit 2.8. > > > > -Khai > > > > > > On Mon, Dec 21, 2015 at 5:04 PM, Carl Baldwin > wrote: > > > I also really miss being able to pull up the list of files in diff > > > view with the 'f' key. Any equivalent? > > > > > > Carl > > > > > > On Mon, Dec 21, 2015 at 4:07 PM, Carl Baldwin > wrote: > > >> I noticed a couple of things today while reviewing a largish page [1]. > > >> First, when I search for something using the browser's builtin search > > >> (Chrome, Mac OSX Yosemite), it doesn't seem to find occurrences that > > >> are not in the visible portion of the page. For example, when I > > >> search for DNSDOMAIN, I get 1 hit from the top of the file. The file > > >> actually has almost 30 hits for this string. For example, scroll > > >> down to about L310 in the file. You'll see them all over the place > > >> (and now Chrome's search finds these hits if you try again). I use > > >> to use search within a file with the old gerrit and never noticed > > >> this problem. > > >> > > >> The other thing that I found annoying is when I scroll the page with > > >> my trackpad, it now jumps around sometimes to a different part of the > > >> page. For example, I'll scroll up to find a spot in the file and > > >> when I think I've arrived, it will jump back down the file a bit. It > > >> is disorienting. Of course, now it isn't doing it anymore so it > > >> doesn't seem to be all the time. It was behaving this way for a good > > >> 20 minutes trying to get through this file. > > >> > > >> Carl > > >> > > >> Carl > > >> > > >> [1] https://review.openstack.org/#/c/212213/36/neutron/db/dns_db.py > > >> > > >> On Thu, Dec 17, 2015 at 8:17 PM, Brian Haley > wrote: > > >>> On 2015-12-16 16:24, openstack-dev-requ...@lists.openstack.org > wrote: > > >>>> > > >>>> Thanks to everyone for their patience while we upgraded to Gerrit > > >>>> 2.11. I'm happy to announce that we were able to successfully > > >>>> completed this task at around 21:00 UTC. You may hack away once > more. > > >>>> > > >>>> If you encounter any problems, please let us know here or in > > >>>> #openstack-infra on Freenode. > > >>> > > >>> > > >>> I'm still undecided on 2.11, have to give it more time, but I have > > >>> not
Re: [openstack-dev] [OpenStack-Infra] Gerrit Upgrade to ver 2.11, completed.
- Original Message -
> From: "Lenny Verkhovsky"
> To: "OpenStack Development Mailing List (not for usage questions)"
>
>
> Hi,
> After Upgrading to 2.11 seems that
> lastcomment (
> https://github.com/openstack/third-party-ci-tools/tree/master/monitoring/lastcomment-scoreboard
> )
> monitoring tool stopped working
>
> I've posted a small patch https://review.openstack.org/#/c/259083/ to fix the
> issue,
> But I wander if there is a proper rest query to for CI name?
> Currently there is only account_id field in Gerrit response and it's not
> really human readable.
I ran into this with a custom script as well, you can use the account_id in a
request of the form:
review.openstack.org/accounts//name
...to get a human readable account name.
-Steve
> Lennyb.
>
>
> -Original Message-
> From: Zaro [mailto:zaro0...@gmail.com]
> Sent: Tuesday, December 22, 2015 3:21 AM
> To: OpenStack Development Mailing List (not for usage questions)
>
> Subject: Re: [openstack-dev] [OpenStack-Infra] Gerrit Upgrade to ver 2.11,
> completed.
>
> Hit '?' and it says '/' is find, give that a try.
>
> Looks like in Gerrit 2.11 the 'f' to get a popup of the list of files is only
> available in unified diff view. I don't remember if it was available in
> side-by-side view on Gerrit 2.8.
>
> -Khai
>
>
> On Mon, Dec 21, 2015 at 5:04 PM, Carl Baldwin wrote:
> > I also really miss being able to pull up the list of files in diff
> > view with the 'f' key. Any equivalent?
> >
> > Carl
> >
> > On Mon, Dec 21, 2015 at 4:07 PM, Carl Baldwin wrote:
> >> I noticed a couple of things today while reviewing a largish page [1].
> >> First, when I search for something using the browser's builtin search
> >> (Chrome, Mac OSX Yosemite), it doesn't seem to find occurrences that
> >> are not in the visible portion of the page. For example, when I
> >> search for DNSDOMAIN, I get 1 hit from the top of the file. The file
> >> actually has almost 30 hits for this string. For example, scroll
> >> down to about L310 in the file. You'll see them all over the place
> >> (and now Chrome's search finds these hits if you try again). I use
> >> to use search within a file with the old gerrit and never noticed
> >> this problem.
> >>
> >> The other thing that I found annoying is when I scroll the page with
> >> my trackpad, it now jumps around sometimes to a different part of the
> >> page. For example, I'll scroll up to find a spot in the file and
> >> when I think I've arrived, it will jump back down the file a bit. It
> >> is disorienting. Of course, now it isn't doing it anymore so it
> >> doesn't seem to be all the time. It was behaving this way for a good
> >> 20 minutes trying to get through this file.
> >>
> >> Carl
> >>
> >> Carl
> >>
> >> [1] https://review.openstack.org/#/c/212213/36/neutron/db/dns_db.py
> >>
> >> On Thu, Dec 17, 2015 at 8:17 PM, Brian Haley wrote:
> >>> On 2015-12-16 16:24, openstack-dev-requ...@lists.openstack.org wrote:
> >>>>
> >>>> Thanks to everyone for their patience while we upgraded to Gerrit
> >>>> 2.11. I'm happy to announce that we were able to successfully
> >>>> completed this task at around 21:00 UTC. You may hack away once more.
> >>>>
> >>>> If you encounter any problems, please let us know here or in
> >>>> #openstack-infra on Freenode.
> >>>
> >>>
> >>> I'm still undecided on 2.11, have to give it more time, but I have
> >>> noticed one thing that's annoying...
> >>>
> >>> Trying to copy text from a review no longer works easily. When I
> >>> highlight text there's a little "bubble" pop-up of {press c to
> >>> comment}, which seems to interfere with both my three-button mouse copy
> >>> buffer, as well as Ctrl-C.
> >>> Call me a nitpicker, but having to highlight text, right-button
> >>> click, Copy, right-button click, Paste, is a pain.
> >>>
> >>> Maybe someone has a simple work-around for that.
> >>>
> >>> -Brian
> >>>
> >>>
> >>> __ OpenStack Development Mailing List (not for usage questions)
> >>> Unsubscribe:
> >>> openstac
Re: [openstack-dev] [OpenStack-Infra] Gerrit Upgrade to ver 2.11, completed.
Hi,
After Upgrading to 2.11 seems that
lastcomment (
https://github.com/openstack/third-party-ci-tools/tree/master/monitoring/lastcomment-scoreboard
)
monitoring tool stopped working
I've posted a small patch https://review.openstack.org/#/c/259083/ to fix the
issue,
But I wander if there is a proper rest query to for CI name?
Currently there is only account_id field in Gerrit response and it's not really
human readable.
Lennyb.
-Original Message-
From: Zaro [mailto:zaro0...@gmail.com]
Sent: Tuesday, December 22, 2015 3:21 AM
To: OpenStack Development Mailing List (not for usage questions)
Subject: Re: [openstack-dev] [OpenStack-Infra] Gerrit Upgrade to ver 2.11,
completed.
Hit '?' and it says '/' is find, give that a try.
Looks like in Gerrit 2.11 the 'f' to get a popup of the list of files is only
available in unified diff view. I don't remember if it was available in
side-by-side view on Gerrit 2.8.
-Khai
On Mon, Dec 21, 2015 at 5:04 PM, Carl Baldwin wrote:
> I also really miss being able to pull up the list of files in diff
> view with the 'f' key. Any equivalent?
>
> Carl
>
> On Mon, Dec 21, 2015 at 4:07 PM, Carl Baldwin wrote:
>> I noticed a couple of things today while reviewing a largish page [1].
>> First, when I search for something using the browser's builtin search
>> (Chrome, Mac OSX Yosemite), it doesn't seem to find occurrences that
>> are not in the visible portion of the page. For example, when I
>> search for DNSDOMAIN, I get 1 hit from the top of the file. The file
>> actually has almost 30 hits for this string. For example, scroll
>> down to about L310 in the file. You'll see them all over the place
>> (and now Chrome's search finds these hits if you try again). I use
>> to use search within a file with the old gerrit and never noticed
>> this problem.
>>
>> The other thing that I found annoying is when I scroll the page with
>> my trackpad, it now jumps around sometimes to a different part of the
>> page. For example, I'll scroll up to find a spot in the file and
>> when I think I've arrived, it will jump back down the file a bit. It
>> is disorienting. Of course, now it isn't doing it anymore so it
>> doesn't seem to be all the time. It was behaving this way for a good
>> 20 minutes trying to get through this file.
>>
>> Carl
>>
>> Carl
>>
>> [1] https://review.openstack.org/#/c/212213/36/neutron/db/dns_db.py
>>
>> On Thu, Dec 17, 2015 at 8:17 PM, Brian Haley wrote:
>>> On 2015-12-16 16:24, openstack-dev-requ...@lists.openstack.org wrote:
>>>>
>>>> Thanks to everyone for their patience while we upgraded to Gerrit
>>>> 2.11. I'm happy to announce that we were able to successfully
>>>> completed this task at around 21:00 UTC. You may hack away once more.
>>>>
>>>> If you encounter any problems, please let us know here or in
>>>> #openstack-infra on Freenode.
>>>
>>>
>>> I'm still undecided on 2.11, have to give it more time, but I have
>>> noticed one thing that's annoying...
>>>
>>> Trying to copy text from a review no longer works easily. When I
>>> highlight text there's a little "bubble" pop-up of {press c to
>>> comment}, which seems to interfere with both my three-button mouse copy
>>> buffer, as well as Ctrl-C.
>>> Call me a nitpicker, but having to highlight text, right-button
>>> click, Copy, right-button click, Paste, is a pain.
>>>
>>> Maybe someone has a simple work-around for that.
>>>
>>> -Brian
>>>
>>>
>>> __ OpenStack Development Mailing List (not for usage questions)
>>> Unsubscribe:
>>> openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
>>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe:
> openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [OpenStack-Infra] Gerrit Upgrade to ver 2.11, completed.
Hit '?' and it says '/' is find, give that a try.
Looks like in Gerrit 2.11 the 'f' to get a popup of the list of files
is only available in unified diff view. I don't remember if it was
available in side-by-side view on Gerrit 2.8.
-Khai
On Mon, Dec 21, 2015 at 5:04 PM, Carl Baldwin wrote:
> I also really miss being able to pull up the list of files in diff
> view with the 'f' key. Any equivalent?
>
> Carl
>
> On Mon, Dec 21, 2015 at 4:07 PM, Carl Baldwin wrote:
>> I noticed a couple of things today while reviewing a largish page [1].
>> First, when I search for something using the browser's builtin search
>> (Chrome, Mac OSX Yosemite), it doesn't seem to find occurrences that
>> are not in the visible portion of the page. For example, when I
>> search for DNSDOMAIN, I get 1 hit from the top of the file. The file
>> actually has almost 30 hits for this string. For example, scroll down
>> to about L310 in the file. You'll see them all over the place (and
>> now Chrome's search finds these hits if you try again). I use to use
>> search within a file with the old gerrit and never noticed this
>> problem.
>>
>> The other thing that I found annoying is when I scroll the page with
>> my trackpad, it now jumps around sometimes to a different part of the
>> page. For example, I'll scroll up to find a spot in the file and when
>> I think I've arrived, it will jump back down the file a bit. It is
>> disorienting. Of course, now it isn't doing it anymore so it doesn't
>> seem to be all the time. It was behaving this way for a good 20
>> minutes trying to get through this file.
>>
>> Carl
>>
>> Carl
>>
>> [1] https://review.openstack.org/#/c/212213/36/neutron/db/dns_db.py
>>
>> On Thu, Dec 17, 2015 at 8:17 PM, Brian Haley wrote:
>>> On 2015-12-16 16:24, openstack-dev-requ...@lists.openstack.org wrote:
Thanks to everyone for their patience while we upgraded to Gerrit
2.11. I'm happy to announce that we were able to successfully
completed this task at around 21:00 UTC. You may hack away once more.
If you encounter any problems, please let us know here or in
#openstack-infra on Freenode.
>>>
>>>
>>> I'm still undecided on 2.11, have to give it more time, but I have noticed
>>> one thing that's annoying...
>>>
>>> Trying to copy text from a review no longer works easily. When I highlight
>>> text there's a little "bubble" pop-up of {press c to comment}, which seems
>>> to interfere with both my three-button mouse copy buffer, as well as Ctrl-C.
>>> Call me a nitpicker, but having to highlight text, right-button click, Copy,
>>> right-button click, Paste, is a pain.
>>>
>>> Maybe someone has a simple work-around for that.
>>>
>>> -Brian
>>>
>>> __
>>> OpenStack Development Mailing List (not for usage questions)
>>> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
>>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [OpenStack-Infra] Gerrit Upgrade to ver 2.11, completed.
I also really miss being able to pull up the list of files in diff
view with the 'f' key. Any equivalent?
Carl
On Mon, Dec 21, 2015 at 4:07 PM, Carl Baldwin wrote:
> I noticed a couple of things today while reviewing a largish page [1].
> First, when I search for something using the browser's builtin search
> (Chrome, Mac OSX Yosemite), it doesn't seem to find occurrences that
> are not in the visible portion of the page. For example, when I
> search for DNSDOMAIN, I get 1 hit from the top of the file. The file
> actually has almost 30 hits for this string. For example, scroll down
> to about L310 in the file. You'll see them all over the place (and
> now Chrome's search finds these hits if you try again). I use to use
> search within a file with the old gerrit and never noticed this
> problem.
>
> The other thing that I found annoying is when I scroll the page with
> my trackpad, it now jumps around sometimes to a different part of the
> page. For example, I'll scroll up to find a spot in the file and when
> I think I've arrived, it will jump back down the file a bit. It is
> disorienting. Of course, now it isn't doing it anymore so it doesn't
> seem to be all the time. It was behaving this way for a good 20
> minutes trying to get through this file.
>
> Carl
>
> Carl
>
> [1] https://review.openstack.org/#/c/212213/36/neutron/db/dns_db.py
>
> On Thu, Dec 17, 2015 at 8:17 PM, Brian Haley wrote:
>> On 2015-12-16 16:24, openstack-dev-requ...@lists.openstack.org wrote:
>>>
>>> Thanks to everyone for their patience while we upgraded to Gerrit
>>> 2.11. I'm happy to announce that we were able to successfully
>>> completed this task at around 21:00 UTC. You may hack away once more.
>>>
>>> If you encounter any problems, please let us know here or in
>>> #openstack-infra on Freenode.
>>
>>
>> I'm still undecided on 2.11, have to give it more time, but I have noticed
>> one thing that's annoying...
>>
>> Trying to copy text from a review no longer works easily. When I highlight
>> text there's a little "bubble" pop-up of {press c to comment}, which seems
>> to interfere with both my three-button mouse copy buffer, as well as Ctrl-C.
>> Call me a nitpicker, but having to highlight text, right-button click, Copy,
>> right-button click, Paste, is a pain.
>>
>> Maybe someone has a simple work-around for that.
>>
>> -Brian
>>
>> __
>> OpenStack Development Mailing List (not for usage questions)
>> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [OpenStack-Infra] Gerrit Upgrade to ver 2.11, completed.
I noticed a couple of things today while reviewing a largish page [1].
First, when I search for something using the browser's builtin search
(Chrome, Mac OSX Yosemite), it doesn't seem to find occurrences that
are not in the visible portion of the page. For example, when I
search for DNSDOMAIN, I get 1 hit from the top of the file. The file
actually has almost 30 hits for this string. For example, scroll down
to about L310 in the file. You'll see them all over the place (and
now Chrome's search finds these hits if you try again). I use to use
search within a file with the old gerrit and never noticed this
problem.
The other thing that I found annoying is when I scroll the page with
my trackpad, it now jumps around sometimes to a different part of the
page. For example, I'll scroll up to find a spot in the file and when
I think I've arrived, it will jump back down the file a bit. It is
disorienting. Of course, now it isn't doing it anymore so it doesn't
seem to be all the time. It was behaving this way for a good 20
minutes trying to get through this file.
Carl
Carl
[1] https://review.openstack.org/#/c/212213/36/neutron/db/dns_db.py
On Thu, Dec 17, 2015 at 8:17 PM, Brian Haley wrote:
> On 2015-12-16 16:24, openstack-dev-requ...@lists.openstack.org wrote:
>>
>> Thanks to everyone for their patience while we upgraded to Gerrit
>> 2.11. I'm happy to announce that we were able to successfully
>> completed this task at around 21:00 UTC. You may hack away once more.
>>
>> If you encounter any problems, please let us know here or in
>> #openstack-infra on Freenode.
>
>
> I'm still undecided on 2.11, have to give it more time, but I have noticed
> one thing that's annoying...
>
> Trying to copy text from a review no longer works easily. When I highlight
> text there's a little "bubble" pop-up of {press c to comment}, which seems
> to interfere with both my three-button mouse copy buffer, as well as Ctrl-C.
> Call me a nitpicker, but having to highlight text, right-button click, Copy,
> right-button click, Paste, is a pain.
>
> Maybe someone has a simple work-around for that.
>
> -Brian
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [OpenStack-Infra] Gerrit Upgrade to ver 2.11, completed.
On 2015-12-18 16:56:46 -0500 (-0500), Sean Dague wrote: [...] > Works fine. Is it firefox specific? Given that the behavior works in > Chromium I suspect not working is not a design point but a bug to be > reported. Must be. Installing another browser to test this was on my to do list, but I observed the unwanted behavior using Iceweasel 38.1.0 (basically un/rebranded FF 38.0). -- Jeremy Stanley __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [OpenStack-Infra] Gerrit Upgrade to ver 2.11, completed.
On 12/17/2015 10:17 PM, Brian Haley wrote:
> On 2015-12-16 16:24, openstack-dev-requ...@lists.openstack.org wrote:
>> Thanks to everyone for their patience while we upgraded to Gerrit
>> 2.11. I'm happy to announce that we were able to successfully
>> completed this task at around 21:00 UTC. You may hack away once more.
>>
>> If you encounter any problems, please let us know here or in
>> #openstack-infra on Freenode.
>
> I'm still undecided on 2.11, have to give it more time, but I have
> noticed one thing that's annoying...
>
> Trying to copy text from a review no longer works easily. When I
> highlight text there's a little "bubble" pop-up of {press c to comment},
> which seems to interfere with both my three-button mouse copy buffer, as
> well as Ctrl-C. Call me a nitpicker, but having to highlight text,
> right-button click, Copy, right-button click, Paste, is a pain.
>
> Maybe someone has a simple work-around for that.
Odd. I'm using chromium browser and
* highlight
* middle click elsewhere
Works fine. Is it firefox specific? Given that the behavior works in
Chromium I suspect not working is not a design point but a bug to be
reported.
-Sean
--
Sean Dague
http://dague.net
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [OpenStack-Infra] Gerrit Upgrade to ver 2.11, completed.
On 2015-12-18 12:12:26 -0500 (-0500), Jay Pipes wrote:
> On 12/17/2015 10:17 PM, Brian Haley wrote:
[...]
> >Trying to copy text from a review no longer works easily. When I
> >highlight text there's a little "bubble" pop-up of {press c to comment},
> >which seems to interfere with both my three-button mouse copy buffer, as
> >well as Ctrl-C.
[...]
That was one of the first things I noticed too. Maybe those of us
who rely on the old-style X11 paste buffers are becoming fewer and
fewer as the years go on. Might want to report it at
https://code.google.com/p/gerrit/issues/list if it's not already
there, and maybe it'll get fixed in the next upgrade we do.
> My suggestion is to use Gertty instead.
Yep, the above-mentioned X11 text clipboard breakage basically
convinced me to spend even more time in Gertty. Not only does the
latest release have it's own kill ring (copy/paste), but I can also
use tmux's copy and paste features as well. Less time touching the
mouse means more efficient reviewing for me!
--
Jeremy Stanley
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [OpenStack-Infra] Gerrit Upgrade to ver 2.11, completed.
On 12/17/2015 10:17 PM, Brian Haley wrote:
On 2015-12-16 16:24, openstack-dev-requ...@lists.openstack.org wrote:
Thanks to everyone for their patience while we upgraded to Gerrit
2.11. I'm happy to announce that we were able to successfully
completed this task at around 21:00 UTC. You may hack away once more.
If you encounter any problems, please let us know here or in
#openstack-infra on Freenode.
I'm still undecided on 2.11, have to give it more time, but I have
noticed one thing that's annoying...
Trying to copy text from a review no longer works easily. When I
highlight text there's a little "bubble" pop-up of {press c to comment},
which seems to interfere with both my three-button mouse copy buffer, as
well as Ctrl-C. Call me a nitpicker, but having to highlight text,
right-button click, Copy, right-button click, Paste, is a pain.
Maybe someone has a simple work-around for that.
I, also, hate the new UI for Gerrit (not that the old one was very good,
but was at least tolerable with the Toggle CI hiding of non-human
participants on the review screen).
My suggestion is to use Gertty instead.
Best,
-jay
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [OpenStack-Infra] Gerrit Upgrade to ver 2.11 completed.
On 12/18/2015 06:48 AM, Dmitry Tantsur wrote: > On 12/16/2015 10:22 PM, Zaro wrote: >> On Tue, Dec 1, 2015 at 6:38 PM, Spencer Krum >> wrote: >>> Hi All, >>> >>> The infra team will be taking gerrit offline for an upgrade on December >>> 16th. We >>> will start the operation at 17:00 UTC and will continue until about >>> 21:00 UTC. >>> >>> This outage is to upgrade Gerrit to version 2.11. The IP address of >>> Gerrit will not be changing. >>> >>> There is a thread beginning here: >>> http://lists.openstack.org/pipermail/openstack-dev/2015-October/076962.html >>> >>> which covers what to expect from the new software. >>> >>> If you have questions about the Gerrit outage you are welcome to post a >>> reply to this thread or find the infra team in the #openstack-infra irc >>> channel on freenode. If you have questions about the version of Gerrit >>> we are upgrading to please post a reply to the email thread linked >>> above, or again you are welcome to ask in the #openstack-infra channel. >>> >> >> >> Thanks to everyone for their patience while we upgraded to Gerrit >> 2.11. I'm happy to announce that we were able to successfully >> completed this task at around 21:00 UTC. You may hack away once more. >> >> If you encounter any problems, please let us know here or in >> #openstack-infra on Freenode. > > Thanks! One small feature request: is it possible to highlight V-1 from > Jenkins in red, just like review -1? It used to be handy to quickly > check the status of the patch. This patch would make that happen - https://review.openstack.org/#/c/259417/ -Sean -- Sean Dague http://dague.net __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [OpenStack-Infra] Gerrit Upgrade to ver 2.11 completed.
On 12/16/2015 10:22 PM, Zaro wrote: On Tue, Dec 1, 2015 at 6:38 PM, Spencer Krum wrote: Hi All, The infra team will be taking gerrit offline for an upgrade on December 16th. We will start the operation at 17:00 UTC and will continue until about 21:00 UTC. This outage is to upgrade Gerrit to version 2.11. The IP address of Gerrit will not be changing. There is a thread beginning here: http://lists.openstack.org/pipermail/openstack-dev/2015-October/076962.html which covers what to expect from the new software. If you have questions about the Gerrit outage you are welcome to post a reply to this thread or find the infra team in the #openstack-infra irc channel on freenode. If you have questions about the version of Gerrit we are upgrading to please post a reply to the email thread linked above, or again you are welcome to ask in the #openstack-infra channel. Thanks to everyone for their patience while we upgraded to Gerrit 2.11. I'm happy to announce that we were able to successfully completed this task at around 21:00 UTC. You may hack away once more. If you encounter any problems, please let us know here or in #openstack-infra on Freenode. Thanks! One small feature request: is it possible to highlight V-1 from Jenkins in red, just like review -1? It used to be handy to quickly check the status of the patch. Enjoy, -Khai __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [OpenStack-Infra] Gerrit Upgrade to ver 2.11 completed.
On 12/16/2015 11:40 PM, Zaro wrote: > We have identified this and will look into it soon. Thanks for > reporting the issue. > > On Wed, Dec 16, 2015 at 2:02 PM, Michał Dulko wrote: >> On 12/16/2015 10:22 PM, Zaro wrote: >>> Thanks to everyone for their patience while we upgraded to Gerrit >>> 2.11. I'm happy to announce that we were able to successfully >>> completed this task at around 21:00 UTC. You may hack away once more. >>> >>> If you encounter any problems, please let us know here or in >>> #openstack-infra on Freenode. >>> >>> Enjoy, >>> -Khai >>> >> Good job! :) >> >> In Cinder we have an impressive number of Third-Party CIs. Even with >> "Toggle CI" option set to not-showing CIs comments, the comment frame is >> displayed. E.g. [1]. This makes reading reviewers comments harder. Is >> there any way of disabling that? Or any chances of fixing it up in >> Gerrit deployment itself? >> >> [1] https://review.openstack.org/#/c/248768/ >> >> ___ >> OpenStack-Infra mailing list >> openstack-in...@lists.openstack.org >> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-infra I see this is already fixed. Thank you very much for such a fast reaction! :) __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [OpenStack-Infra] Gerrit Upgrade to ver 2.11, completed.
On 2015-12-16 16:24, openstack-dev-requ...@lists.openstack.org wrote:
Thanks to everyone for their patience while we upgraded to Gerrit
2.11. I'm happy to announce that we were able to successfully
completed this task at around 21:00 UTC. You may hack away once more.
If you encounter any problems, please let us know here or in
#openstack-infra on Freenode.
I'm still undecided on 2.11, have to give it more time, but I have noticed one
thing that's annoying...
Trying to copy text from a review no longer works easily. When I highlight text
there's a little "bubble" pop-up of {press c to comment}, which seems to
interfere with both my three-button mouse copy buffer, as well as Ctrl-C. Call
me a nitpicker, but having to highlight text, right-button click, Copy,
right-button click, Paste, is a pain.
Maybe someone has a simple work-around for that.
-Brian
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [OpenStack-Infra] Gerrit Upgrade to ver 2.11, completed.
On 2015-12-16 16:24, openstack-dev-requ...@lists.openstack.org wrote: Thanks to everyone for their patience while we upgraded to Gerrit 2.11. I'm happy to announce that we were able to successfully completed this task at around 21:00 UTC. You may hack away once more. If you encounter any problems, please let us know here or in #openstack-infra on Freenode. I have encountered severe user interface problems. Arrow keys and pageup/pagedown don't scroll correctly. Instead, it's stuck in a hack version of caret browsing mode (even when my browser is not set to caret mode). The scroll bar is very difficult to use, because it uses a reimplemented quarter-width semitransparent scroll bar widget instead of the operating system's correct scroll bar widget. Fortunately, the mouse wheel scroll still works correctly, aside from leaving a lingering header at the top of the page that never scrolls away. The "review" button used to open its own page to post a review. This has been replaced by a "reply" button, which only opens a modal div in the same page. The modal div pretends to be a popup window, without the ability to be moved or resized, as a popup window can be. The old list of reviewers was better, because it was a table that showed each reviewer, and their status. Now, reviewers are shown for each status in a horizontal list. Also, given a person's name, it's more difficult to tell where they stand in the review (before, a reviewer's statuses were all in a single row of the table). Now, it is necessary to search each list, which is hard because each list is horizontal. I can see this being more useful for reviews where there are a hundred reviewers, and it is more important to quickly see who is -1 or -2, to address their comments. However, I've never seen a review that big on this site. Regards, Drew Varner __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [OpenStack-Infra] Gerrit Upgrade to ver 2.11 completed.
On Thu, Dec 17, 2015 at 12:31 AM, Andrea Frittoli wrote: > Thanks for the upgrade, and for all the effort you folks put into keeping > our gerrit close to upstream! > > One thing that I find inconvenient in the new UI is the size of the middle > (test results) column: it's too narrow, no matter how large my browser > window is, or what browser I use - which causes the name of some of the jobs > to wrap to a second line, making it really hard to read test results. At > least that's my experience on tempest reviews, where we have a lot of jobs, > and rather long names - see [0] for instance. > > Is there any chance via configuration to make that column slightly wider? > There are a few proposals already: https://review.openstack.org/258751 https://review.openstack.org/258744 > thank you! > > andrea > [0] https://review.openstack.org/#/c/254274/ > __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [OpenStack-Infra] Gerrit Upgrade to ver 2.11 completed.
Thanks for the upgrade, and for all the effort you folks put into keeping our gerrit close to upstream! One thing that I find inconvenient in the new UI is the size of the middle (test results) column: it's too narrow, no matter how large my browser window is, or what browser I use - which causes the name of some of the jobs to wrap to a second line, making it really hard to read test results. At least that's my experience on tempest reviews, where we have a lot of jobs, and rather long names - see [0] for instance. Is there any chance via configuration to make that column slightly wider? thank you! andrea [0] https://review.openstack.org/#/c/254274/ On Thu, Dec 17, 2015 at 2:52 AM David Pursehouse wrote: > The "Copy to clipboard" icons are not working on Chrome/Ubuntu. > > This was already fixed upstream. I've cherry-picked it here: > > https://review.openstack.org/#/c/258753/ > > > On Thu, Dec 17, 2015 at 6:22 AM Zaro wrote: > >> On Tue, Dec 1, 2015 at 6:38 PM, Spencer Krum >> wrote: >> > Hi All, >> > >> > The infra team will be taking gerrit offline for an upgrade on December >> > 16th. We >> > will start the operation at 17:00 UTC and will continue until about >> > 21:00 UTC. >> > >> > This outage is to upgrade Gerrit to version 2.11. The IP address of >> > Gerrit will not be changing. >> > >> > There is a thread beginning here: >> > >> http://lists.openstack.org/pipermail/openstack-dev/2015-October/076962.html >> > which covers what to expect from the new software. >> > >> > If you have questions about the Gerrit outage you are welcome to post a >> > reply to this thread or find the infra team in the #openstack-infra irc >> > channel on freenode. If you have questions about the version of Gerrit >> > we are upgrading to please post a reply to the email thread linked >> > above, or again you are welcome to ask in the #openstack-infra channel. >> > >> >> >> Thanks to everyone for their patience while we upgraded to Gerrit >> 2.11. I'm happy to announce that we were able to successfully >> completed this task at around 21:00 UTC. You may hack away once more. >> >> If you encounter any problems, please let us know here or in >> #openstack-infra on Freenode. >> >> Enjoy, >> -Khai >> >> ___ >> OpenStack-Infra mailing list >> openstack-in...@lists.openstack.org >> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-infra >> > __ > OpenStack Development Mailing List (not for usage questions) > Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [OpenStack-Infra] Gerrit Upgrade to ver 2.11 completed.
The "Copy to clipboard" icons are not working on Chrome/Ubuntu. This was already fixed upstream. I've cherry-picked it here: https://review.openstack.org/#/c/258753/ On Thu, Dec 17, 2015 at 6:22 AM Zaro wrote: > On Tue, Dec 1, 2015 at 6:38 PM, Spencer Krum wrote: > > Hi All, > > > > The infra team will be taking gerrit offline for an upgrade on December > > 16th. We > > will start the operation at 17:00 UTC and will continue until about > > 21:00 UTC. > > > > This outage is to upgrade Gerrit to version 2.11. The IP address of > > Gerrit will not be changing. > > > > There is a thread beginning here: > > > http://lists.openstack.org/pipermail/openstack-dev/2015-October/076962.html > > which covers what to expect from the new software. > > > > If you have questions about the Gerrit outage you are welcome to post a > > reply to this thread or find the infra team in the #openstack-infra irc > > channel on freenode. If you have questions about the version of Gerrit > > we are upgrading to please post a reply to the email thread linked > > above, or again you are welcome to ask in the #openstack-infra channel. > > > > > Thanks to everyone for their patience while we upgraded to Gerrit > 2.11. I'm happy to announce that we were able to successfully > completed this task at around 21:00 UTC. You may hack away once more. > > If you encounter any problems, please let us know here or in > #openstack-infra on Freenode. > > Enjoy, > -Khai > > ___ > OpenStack-Infra mailing list > openstack-in...@lists.openstack.org > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-infra > __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [OpenStack-Infra] Gerrit Upgrade to ver 2.11 completed.
We have identified this and will look into it soon. Thanks for reporting the issue. On Wed, Dec 16, 2015 at 2:02 PM, Michał Dulko wrote: > On 12/16/2015 10:22 PM, Zaro wrote: >> Thanks to everyone for their patience while we upgraded to Gerrit >> 2.11. I'm happy to announce that we were able to successfully >> completed this task at around 21:00 UTC. You may hack away once more. >> >> If you encounter any problems, please let us know here or in >> #openstack-infra on Freenode. >> >> Enjoy, >> -Khai >> > > Good job! :) > > In Cinder we have an impressive number of Third-Party CIs. Even with > "Toggle CI" option set to not-showing CIs comments, the comment frame is > displayed. E.g. [1]. This makes reading reviewers comments harder. Is > there any way of disabling that? Or any chances of fixing it up in > Gerrit deployment itself? > > [1] https://review.openstack.org/#/c/248768/ > > ___ > OpenStack-Infra mailing list > openstack-in...@lists.openstack.org > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-infra __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [OpenStack-Infra] Gerrit Upgrade to ver 2.11 completed.
On 12/16/2015 10:22 PM, Zaro wrote: > Thanks to everyone for their patience while we upgraded to Gerrit > 2.11. I'm happy to announce that we were able to successfully > completed this task at around 21:00 UTC. You may hack away once more. > > If you encounter any problems, please let us know here or in > #openstack-infra on Freenode. > > Enjoy, > -Khai > Good job! :) In Cinder we have an impressive number of Third-Party CIs. Even with "Toggle CI" option set to not-showing CIs comments, the comment frame is displayed. E.g. [1]. This makes reading reviewers comments harder. Is there any way of disabling that? Or any chances of fixing it up in Gerrit deployment itself? [1] https://review.openstack.org/#/c/248768/ __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
[openstack-dev] [OpenStack-Infra] Gerrit Upgrade to ver 2.11 completed.
On Tue, Dec 1, 2015 at 6:38 PM, Spencer Krum wrote: > Hi All, > > The infra team will be taking gerrit offline for an upgrade on December > 16th. We > will start the operation at 17:00 UTC and will continue until about > 21:00 UTC. > > This outage is to upgrade Gerrit to version 2.11. The IP address of > Gerrit will not be changing. > > There is a thread beginning here: > http://lists.openstack.org/pipermail/openstack-dev/2015-October/076962.html > which covers what to expect from the new software. > > If you have questions about the Gerrit outage you are welcome to post a > reply to this thread or find the infra team in the #openstack-infra irc > channel on freenode. If you have questions about the version of Gerrit > we are upgrading to please post a reply to the email thread linked > above, or again you are welcome to ask in the #openstack-infra channel. > Thanks to everyone for their patience while we upgraded to Gerrit 2.11. I'm happy to announce that we were able to successfully completed this task at around 21:00 UTC. You may hack away once more. If you encounter any problems, please let us know here or in #openstack-infra on Freenode. Enjoy, -Khai __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
