Re: [openstack-dev] [Oslo] Improving oslo-incubator update.py

2014-03-17 Thread Ben Nemec
(not for usage questions) openstack-dev@lists.openstack.org Cc: Solly Ross sr...@redhat.com Sent: Friday, March 14, 2014 4:36:03 PM Subject: Re: [openstack-dev] [Oslo] Improving oslo-incubator update.py On 2014-03-14 14:49, Solly Ross wrote: It would also be great if there was a way to only sync

Re: [openstack-dev] [Oslo] Improving oslo-incubator update.py

2014-03-15 Thread Solly Ross
sr...@redhat.com Sent: Friday, March 14, 2014 4:36:03 PM Subject: Re: [openstack-dev] [Oslo] Improving oslo-incubator update.py On 2014-03-14 14:49, Solly Ross wrote: It would also be great if there was a way to only sync one package. There is. :-) --nodeps will only sync the modules specified

Re: [openstack-dev] [Oslo] Improving oslo-incubator update.py

2014-03-14 Thread Brant Knudson
On Wed, Mar 12, 2014 at 11:03 AM, Duncan Thomas duncan.tho...@gmail.comwrote: On 15 January 2014 18:53, Brant Knudson b...@acm.org wrote: At no point do I care what are the different commits that are being brought in from oslo-incubator. If the commits are listed in the commit message

Re: [openstack-dev] [Oslo] Improving oslo-incubator update.py

2014-03-14 Thread Jay S Bryant
From: Brant Knudson b...@acm.org To: OpenStack Development Mailing List (not for usage questions) openstack-dev@lists.openstack.org, Date: 03/14/2014 10:26 AM Subject:Re: [openstack-dev] [Oslo] Improving oslo-incubator update.py On Wed, Mar 12, 2014 at 11:03 AM, Duncan

Re: [openstack-dev] [Oslo] Improving oslo-incubator update.py

2014-03-14 Thread Duncan Thomas
On 14 March 2014 16:10, Jay S Bryant jsbry...@us.ibm.com wrote: -- Duncan, It is important to know what commits are being brought over to help provide a pointer to -- the possible cause of subsequent bugs that arise. I.E. if we sync up the DB, there is a commit for fixing -- db connection

Re: [openstack-dev] [Oslo] Improving oslo-incubator update.py

2014-03-14 Thread Jay S Bryant
From: Duncan Thomas duncan.tho...@gmail.com To: OpenStack Development Mailing List (not for usage questions) openstack-dev@lists.openstack.org, Date: 03/14/2014 11:49 AM Subject:Re: [openstack-dev] [Oslo] Improving oslo-incubator update.py On 14 March 2014 16:10, Jay S Bryant

Re: [openstack-dev] [Oslo] Improving oslo-incubator update.py

2014-03-14 Thread Jay S Bryant
From: Brant Knudson b...@acm.org To: OpenStack Development Mailing List (not for usage questions) openstack-dev@lists.openstack.org, Date: 03/14/2014 02:21 PM Subject:Re: [openstack-dev] [Oslo] Improving oslo-incubator update.py On Fri, Mar 14, 2014 at 2:05 PM, Jay S

Re: [openstack-dev] [Oslo] Improving oslo-incubator update.py

2014-03-14 Thread Solly Ross
questions) openstack-dev@lists.openstack.org Sent: Friday, March 14, 2014 3:36:49 PM Subject: Re: [openstack-dev] [Oslo] Improving oslo-incubator update.py From: Brant Knudson b...@acm.org To: OpenStack Development Mailing List (not for usage questions) openstack-dev@lists.openstack.org, Date

Re: [openstack-dev] [Oslo] Improving oslo-incubator update.py

2014-03-14 Thread Ben Nemec
Regards, Solly Ross - Original Message - From: Jay S Bryant jsbry...@us.ibm.com To: OpenStack Development Mailing List (not for usage questions) openstack-dev@lists.openstack.org Sent: Friday, March 14, 2014 3:36:49 PM Subject: Re: [openstack-dev] [Oslo] Improving oslo-incubator update.py

Re: [openstack-dev] [Oslo] Improving oslo-incubator update.py

2014-03-12 Thread Duncan Thomas
On 15 January 2014 18:53, Brant Knudson b...@acm.org wrote: At no point do I care what are the different commits that are being brought in from oslo-incubator. If the commits are listed in the commit message then I feel an obligation to verify that they got the right commits in the message

Re: [openstack-dev] [Oslo] Improving oslo-incubator update.py

2014-01-15 Thread Flavio Percoco
On 14/01/14 16:33 -0600, Ben Nemec wrote: On 2014-01-14 15:26, Doug Hellmann wrote: In the release meeting today, Russell proposed that we at least include the hash of the HEAD when the merge is done, to indicate how far along the oslo changes are. More detail is obviously better.

Re: [openstack-dev] [Oslo] Improving oslo-incubator update.py

2014-01-15 Thread Doug Hellmann
On Wed, Jan 15, 2014 at 4:40 AM, Flavio Percoco fla...@redhat.com wrote: On 14/01/14 16:33 -0600, Ben Nemec wrote: On 2014-01-14 15:26, Doug Hellmann wrote: In the release meeting today, Russell proposed that we at least include the hash of the HEAD when the merge is done, to

Re: [openstack-dev] [Oslo] Improving oslo-incubator update.py

2014-01-15 Thread Flavio Percoco
On 15/01/14 07:44 -0500, Doug Hellmann wrote: [...] I don't see a problem with doing that, but I'm not clear on where we're including the hash. In the file itself, in a separate file, and/or in the commit message? Even if we do no more automation, having the

Re: [openstack-dev] [Oslo] Improving oslo-incubator update.py

2014-01-15 Thread Ben Nemec
On 2014-01-15 07:05, Flavio Percoco wrote: On 15/01/14 07:44 -0500, Doug Hellmann wrote: [...] I don't see a problem with doing that, but I'm not clear on where we're including the hash. In the file itself, in a separate file, and/or in the commit message?

Re: [openstack-dev] [Oslo] Improving oslo-incubator update.py

2014-01-15 Thread Brant Knudson
Here's the process I use to review a oslo-incubator merge... since I'm mostly reviewing keystone I'm going to use that as the project. 1) Make sure keystone master is at the latest, and that oslo-incubator is at the right level (the commit hash if they mentioned it or latest) 2) run update.py in

Re: [openstack-dev] [Oslo] Improving oslo-incubator update.py

2014-01-15 Thread Doug Hellmann
On Wed, Jan 15, 2014 at 1:53 PM, Brant Knudson b...@acm.org wrote: Here's the process I use to review a oslo-incubator merge... since I'm mostly reviewing keystone I'm going to use that as the project. 1) Make sure keystone master is at the latest, and that oslo-incubator is at the right

Re: [openstack-dev] [Oslo] Improving oslo-incubator update.py

2014-01-14 Thread Flavio Percoco
On 13/01/14 12:07 -0500, Doug Hellmann wrote: [.] I spent some time trying to think through how we could improve the update script for [1], and I'm stumped on how to figure out *accurately* what state the project repositories are in today. We can't just compute the hash of the

Re: [openstack-dev] [Oslo] Improving oslo-incubator update.py

2014-01-14 Thread Doug Hellmann
In the release meeting today, Russell proposed that we at least include the hash of the HEAD when the merge is done, to indicate how far along the oslo changes are. More detail is obviously better. So, let's consider this as a new policy. Does anyone foresee issues with making this work? Doug

Re: [openstack-dev] [Oslo] Improving oslo-incubator update.py

2014-01-14 Thread Ben Nemec
On 2014-01-14 15:26, Doug Hellmann wrote: In the release meeting today, Russell proposed that we at least include the hash of the HEAD when the merge is done, to indicate how far along the oslo changes are. More detail is obviously better. So, let's consider this as a new policy.

Re: [openstack-dev] [Oslo] Improving oslo-incubator update.py

2014-01-13 Thread Doug Hellmann
[resurrecting an old thread] On Wed, Nov 27, 2013 at 6:26 AM, Flavio Percoco fla...@redhat.com wrote: On 27/11/13 10:59 +, Mark McLoughlin wrote: On Wed, 2013-11-27 at 11:50 +0100, Flavio Percoco wrote: On 26/11/13 22:54 +, Mark McLoughlin wrote: On Fri, 2013-11-22 at 12:39 -0500,

Re: [openstack-dev] [Oslo] Improving oslo-incubator update.py

2014-01-13 Thread Robert Myers
We could always use relative imports in oslo :) Then you could put it where ever you wanted to without needing to rewrite the import statements. On Mon, Jan 13, 2014 at 11:07 AM, Doug Hellmann doug.hellm...@dreamhost.com wrote: [resurrecting an old thread] On Wed, Nov 27, 2013 at 6:26 AM,

Re: [openstack-dev] [Oslo] Improving oslo-incubator update.py

2014-01-13 Thread Doug Hellmann
On Mon, Jan 13, 2014 at 1:16 PM, Robert Myers myer0...@gmail.com wrote: We could always use relative imports in oslo :) Then you could put it where ever you wanted to without needing to rewrite the import statements. That may be a good idea, but doesn't really solve the problem at hand. Doug

Re: [openstack-dev] [Oslo] Improving oslo-incubator update.py

2014-01-13 Thread Kevin L. Mitchell
On Mon, 2014-01-13 at 12:07 -0500, Doug Hellmann wrote: We can't just compute the hash of the modules in the project receiving copies, and then look for them in the oslo-incubator repo, because we modify the files as we copy them out (to update the import statements and replace oslo with the

Re: [openstack-dev] [Oslo] Improving oslo-incubator update.py

2014-01-13 Thread Doug Hellmann
On Mon, Jan 13, 2014 at 3:41 PM, Kevin L. Mitchell kevin.mitch...@rackspace.com wrote: On Mon, 2014-01-13 at 12:07 -0500, Doug Hellmann wrote: We can't just compute the hash of the modules in the project receiving copies, and then look for them in the oslo-incubator repo, because we

Re: [openstack-dev] [Oslo] Improving oslo-incubator update.py

2013-11-27 Thread Flavio Percoco
On 26/11/13 22:54 +, Mark McLoughlin wrote: On Fri, 2013-11-22 at 12:39 -0500, Doug Hellmann wrote: On Fri, Nov 22, 2013 at 4:11 AM, Flavio Percoco fla...@redhat.com wrote: 1) Store the commit sha from which the module was copied from. Every project using oslo, currently keeps the

Re: [openstack-dev] [Oslo] Improving oslo-incubator update.py

2013-11-27 Thread Mark McLoughlin
On Wed, 2013-11-27 at 11:50 +0100, Flavio Percoco wrote: On 26/11/13 22:54 +, Mark McLoughlin wrote: On Fri, 2013-11-22 at 12:39 -0500, Doug Hellmann wrote: On Fri, Nov 22, 2013 at 4:11 AM, Flavio Percoco fla...@redhat.com wrote: 1) Store the commit sha from which the module was

Re: [openstack-dev] [Oslo] Improving oslo-incubator update.py

2013-11-27 Thread Flavio Percoco
On 27/11/13 10:59 +, Mark McLoughlin wrote: On Wed, 2013-11-27 at 11:50 +0100, Flavio Percoco wrote: On 26/11/13 22:54 +, Mark McLoughlin wrote: On Fri, 2013-11-22 at 12:39 -0500, Doug Hellmann wrote: On Fri, Nov 22, 2013 at 4:11 AM, Flavio Percoco fla...@redhat.com wrote: 1)

Re: [openstack-dev] [Oslo] Improving oslo-incubator update.py

2013-11-26 Thread Yuriy Taraday
Hello. On Fri, Nov 22, 2013 at 1:11 PM, Flavio Percoco fla...@redhat.com wrote: 1) Store the commit sha from which the module was copied from. I would suggest we don't duplicate this in every project's repo. It is possible to find using the contents of the modules currently in project's

Re: [openstack-dev] [Oslo] Improving oslo-incubator update.py

2013-11-26 Thread Mark McLoughlin
On Fri, 2013-11-22 at 12:39 -0500, Doug Hellmann wrote: On Fri, Nov 22, 2013 at 4:11 AM, Flavio Percoco fla...@redhat.com wrote: Greetings, Based on the recent discussion that came out about not having enough information in the commit message when syncing oslo-incubator modules, I was

Re: [openstack-dev] [Oslo] Improving oslo-incubator update.py

2013-11-26 Thread Mark McLoughlin
On Fri, 2013-11-22 at 16:24 +, Duncan Thomas wrote: On 22 November 2013 14:59, Ben Nemec openst...@nemebean.com wrote: One other thought I had was to add the ability to split one Oslo sync up into multiple commits, either one per module, or even one per Oslo commit for some really

Re: [openstack-dev] [Oslo] Improving oslo-incubator update.py

2013-11-25 Thread Flavio Percoco
On 25/11/13 09:34 +0800, Zhongyue Luo wrote: Just a thought but couldn't the changes of a module update be calculated by comparing the last commit dates of the source and target module? For instance, if module A's update patch for Nova was uploaded on date XX then we can filter out the changes

Re: [openstack-dev] [Oslo] Improving oslo-incubator update.py

2013-11-25 Thread Flavio Percoco
On 23/11/13 11:54 -0500, Doug Hellmann wrote: Thanks for the reminder, Sandy. https://bugs.launchpad.net/oslo/+bug/1254300 On Sat, Nov 23, 2013 at 9:39 AM, Sandy Walsh sandy.wa...@rackspace.com wrote: Seeing this thread reminded me: We need support in the update script for entry

Re: [openstack-dev] [Oslo] Improving oslo-incubator update.py

2013-11-24 Thread Zhongyue Luo
Just a thought but couldn't the changes of a module update be calculated by comparing the last commit dates of the source and target module? For instance, if module A's update patch for Nova was uploaded on date XX then we can filter out the changes from XX~present and print it out for the author

Re: [openstack-dev] [Oslo] Improving oslo-incubator update.py

2013-11-23 Thread Sandy Walsh
Seeing this thread reminded me: We need support in the update script for entry points in olso setup.cfg to make their way into the target project. So, if update is getting some love, please keep that in mind. ___ OpenStack-dev mailing list

Re: [openstack-dev] [Oslo] Improving oslo-incubator update.py

2013-11-23 Thread Doug Hellmann
Thanks for the reminder, Sandy. https://bugs.launchpad.net/oslo/+bug/1254300 On Sat, Nov 23, 2013 at 9:39 AM, Sandy Walsh sandy.wa...@rackspace.comwrote: Seeing this thread reminded me: We need support in the update script for entry points in olso setup.cfg to make their way into the

[openstack-dev] [Oslo] Improving oslo-incubator update.py

2013-11-22 Thread Flavio Percoco
Greetings, Based on the recent discussion that came out about not having enough information in the commit message when syncing oslo-incubator modules, I was thinking that besides encouraging people to write better commit messages, we could also improve the script we use to sync those modules.

Re: [openstack-dev] [Oslo] Improving oslo-incubator update.py

2013-11-22 Thread Ben Nemec
On 2013-11-22 03:11, Flavio Percoco wrote: Greetings, Based on the recent discussion that came out about not having enough information in the commit message when syncing oslo-incubator modules, I was thinking that besides encouraging people to write better commit messages, we could also improve

Re: [openstack-dev] [Oslo] Improving oslo-incubator update.py

2013-11-22 Thread Duncan Thomas
On 22 November 2013 14:59, Ben Nemec openst...@nemebean.com wrote: One other thought I had was to add the ability to split one Oslo sync up into multiple commits, either one per module, or even one per Oslo commit for some really large module changes (I'm thinking of the 1000 line db sync

Re: [openstack-dev] [Oslo] Improving oslo-incubator update.py

2013-11-22 Thread Doug Hellmann
On Fri, Nov 22, 2013 at 4:11 AM, Flavio Percoco fla...@redhat.com wrote: Greetings, Based on the recent discussion that came out about not having enough information in the commit message when syncing oslo-incubator modules, I was thinking that besides encouraging people to write better

Re: [openstack-dev] [Oslo] Improving oslo-incubator update.py

2013-11-22 Thread Doug Hellmann
On Fri, Nov 22, 2013 at 11:24 AM, Duncan Thomas duncan.tho...@gmail.comwrote: On 22 November 2013 14:59, Ben Nemec openst...@nemebean.com wrote: One other thought I had was to add the ability to split one Oslo sync up into multiple commits, either one per module, or even one per Oslo commit