Re: [openstack-dev] [QA][Tempest] Drop javelin off tempest

[Daniel Mellado]

Do you think that then we should mark it as 'deprecate'? so it throws a
warning when called until we finally decide to drop it off in a future
cycle?

El 11/12/15 a las 03:52, GHANSHYAM MANN escribió:
> Hi,
>
> Yes, That's very valid point about there might be some real users or in 
> future.
>
> So Instead of deleting it, how about maintaining it. Only issue here
> was gate did not
> capture the issues when introduced in his tool.
> But we can cover that using Unit tests and if really necessary we can
> add experimental job for that.
>
> 2 thing we need
> - Modify current unit tests to mock clients methods at deeper level
> instead of complete service clients class.
> - If really needed add experimental job for testing on gate.
>
> Same issue we have for cleanup tool also, I need to check where we can
> cover their testing(UT or gate job etc)
>
> I vote it to keep that (which can be useful for some users (may be
> future) who want to quickly tests their Cloud's resource
> creation/deletion etc )
>
> On Fri, Dec 11, 2015 at 1:17 AM, Matthew Treinish  
> wrote:
>> On Thu, Dec 10, 2015 at 11:15:06AM +0100, Daniel Mellado wrote:
>>> Hi All,
>>>
>>> In today's QA meeting we were discussing about dropping Javelin off
>>> tempest if it's not being used anymore in grenade, as sdague pointed
>>> out. We were thinking about this as a part of the work for [1], where we
>>> hit issue on Javelin script testing where gate did not detect the
>>> service clients changes in this script.
>> So the reason we didn't remove this from tempest when we stopped using it as
>> part of grenade is at the time there were external users. They still wanted 
>> to
>> keep the tooling around. This is why the unit tests were grown in an effort 
>> to
>> maintain some semblance of testing after the grenade removal. (for a long 
>> time
>> it was mostly self testing through the grenade job)
>>
>>> Our intention it's to drop the following files off tempest:
>>>
>>>   * tempest/cmd/javelin.py
>>> 
>>>   * tempest/cmd/resources.yaml
>>> 
>>>   * tempest/tests/cmd/test_javelin.py
>>> 
>>> 
>>>
>>> Before doing so, we'd like to get some feedback about out planned move,
>>> so if you have any questions, comments or feedback, please reply to this
>>> thread.
>> You should not just delete these files, there were real users of it in the 
>> past
>> and there might still be. If you're saying that javelin isn't something we 
>> can
>> realistically maintain anymore (which I'm not sure I buy, but whatever) we
>> should first mark it for deprecation and have a warning print saying it will 
>> be
>> removed in the future. This gives people a chance to stop using it and 
>> migrate
>> to something else. (using ansible would be a good alternative)
>>
>>
>> -Matt Treinish
>>
>>> ---
>>> [1]
>>> https://review.openstack.org/#/q/status:open+project:openstack/tempest+branch:master+topic:bp/consistent-service-method-names,n,z
>>>
>> __
>> OpenStack Development Mailing List (not for usage questions)
>> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>
>
>


__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [QA][Tempest] Drop javelin off tempest

[Chris Dent]

On Thu, 10 Dec 2015, Daniel Mellado wrote:


Before doing so, we'd like to get some feedback about out planned move,
so if you have any questions, comments or feedback, please reply to this
thread.


+1

I think this is the right way to go. I put a lot of work into
javelin related stuff a bit more than a year ago and it seemed
pretty useful. It didn't, however, catch on. Probably in part
because it didn't provide sufficient flexibility.

The new resources.sh functionality provided in the grenade plugin
interface is more likely to catch on because as long as you follow the
gross outlines of the interface you can do whatever you like in the
guts.

--
Chris Dent   (╯°□°)╯︵┻━┻http://anticdent.org/
freenode: cdent tw: @anticdent__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

[openstack-dev] [QA][Tempest] Drop javelin off tempest

[Daniel Mellado]

Hi All,

In today's QA meeting we were discussing about dropping Javelin off
tempest if it's not being used anymore in grenade, as sdague pointed
out. We were thinking about this as a part of the work for [1], where we
hit issue on Javelin script testing where gate did not detect the
service clients changes in this script.

Our intention it's to drop the following files off tempest:

  * tempest/cmd/javelin.py

  * tempest/cmd/resources.yaml

  * tempest/tests/cmd/test_javelin.py



Before doing so, we'd like to get some feedback about out planned move,
so if you have any questions, comments or feedback, please reply to this
thread.

Thanks!

Daniel Mellado

---
[1]
https://review.openstack.org/#/q/status:open+project:openstack/tempest+branch:master+topic:bp/consistent-service-method-names,n,z



__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [QA][Tempest] Drop javelin off tempest

[Daniel Mellado]

Hi All,

comments inline

El 10/12/15 a las 17:17, Matthew Treinish escribió:
> On Thu, Dec 10, 2015 at 11:15:06AM +0100, Daniel Mellado wrote:
>> Hi All,
>>
>> In today's QA meeting we were discussing about dropping Javelin off
>> tempest if it's not being used anymore in grenade, as sdague pointed
>> out. We were thinking about this as a part of the work for [1], where we
>> hit issue on Javelin script testing where gate did not detect the
>> service clients changes in this script.
> So the reason we didn't remove this from tempest when we stopped using it as
> part of grenade is at the time there were external users. They still wanted to
> keep the tooling around. This is why the unit tests were grown in an effort to
> maintain some semblance of testing after the grenade removal. (for a long time
> it was mostly self testing through the grenade job)
About the unit tests, then the option would be for them to use real
clients instead of the Mock ones. Would that work for you?
>
>> Our intention it's to drop the following files off tempest:
>>
>>   * tempest/cmd/javelin.py
>> 
>>   * tempest/cmd/resources.yaml
>> 
>>   * tempest/tests/cmd/test_javelin.py
>> 
>> 
>>
>> Before doing so, we'd like to get some feedback about out planned move,
>> so if you have any questions, comments or feedback, please reply to this
>> thread.
> You should not just delete these files, there were real users of it in the 
> past
> and there might still be. If you're saying that javelin isn't something we can
> realistically maintain anymore (which I'm not sure I buy, but whatever) we 
> should first mark it for deprecation and have a warning print saying it will 
> be
> removed in the future. This gives people a chance to stop using it and migrate
> to something else. (using ansible would be a good alternative)
Then should we just mark it as deprecate, and if so, how? I'll put a new
commit marking it as deprecate with a different commit message

Thanks
>
>
> -Matt Treinish
>
>> ---
>> [1]
>> https://review.openstack.org/#/q/status:open+project:openstack/tempest+branch:master+topic:bp/consistent-service-method-names,n,z
>>
>>
>>
>> __
>> OpenStack Development Mailing List (not for usage questions)
>> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [QA][Tempest] Drop javelin off tempest

[GHANSHYAM MANN]

Hi,

Yes, That's very valid point about there might be some real users or in future.

So Instead of deleting it, how about maintaining it. Only issue here
was gate did not
capture the issues when introduced in his tool.
But we can cover that using Unit tests and if really necessary we can
add experimental job for that.

2 thing we need
- Modify current unit tests to mock clients methods at deeper level
instead of complete service clients class.
- If really needed add experimental job for testing on gate.

Same issue we have for cleanup tool also, I need to check where we can
cover their testing(UT or gate job etc)

I vote it to keep that (which can be useful for some users (may be
future) who want to quickly tests their Cloud's resource
creation/deletion etc )

On Fri, Dec 11, 2015 at 1:17 AM, Matthew Treinish  wrote:
> On Thu, Dec 10, 2015 at 11:15:06AM +0100, Daniel Mellado wrote:
>> Hi All,
>>
>> In today's QA meeting we were discussing about dropping Javelin off
>> tempest if it's not being used anymore in grenade, as sdague pointed
>> out. We were thinking about this as a part of the work for [1], where we
>> hit issue on Javelin script testing where gate did not detect the
>> service clients changes in this script.
>
> So the reason we didn't remove this from tempest when we stopped using it as
> part of grenade is at the time there were external users. They still wanted to
> keep the tooling around. This is why the unit tests were grown in an effort to
> maintain some semblance of testing after the grenade removal. (for a long time
> it was mostly self testing through the grenade job)
>
>>
>> Our intention it's to drop the following files off tempest:
>>
>>   * tempest/cmd/javelin.py
>> 
>>   * tempest/cmd/resources.yaml
>> 
>>   * tempest/tests/cmd/test_javelin.py
>> 
>> 
>>
>> Before doing so, we'd like to get some feedback about out planned move,
>> so if you have any questions, comments or feedback, please reply to this
>> thread.
>
> You should not just delete these files, there were real users of it in the 
> past
> and there might still be. If you're saying that javelin isn't something we can
> realistically maintain anymore (which I'm not sure I buy, but whatever) we
> should first mark it for deprecation and have a warning print saying it will 
> be
> removed in the future. This gives people a chance to stop using it and migrate
> to something else. (using ansible would be a good alternative)
>
>
> -Matt Treinish
>
>>
>> ---
>> [1]
>> https://review.openstack.org/#/q/status:open+project:openstack/tempest+branch:master+topic:bp/consistent-service-method-names,n,z
>>
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>



-- 
Regards
Ghanshyam Mann
+81-8084200646

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [QA][Tempest] Drop javelin off tempest

[Matthew Treinish]

On Thu, Dec 10, 2015 at 11:15:06AM +0100, Daniel Mellado wrote:
> Hi All,
> 
> In today's QA meeting we were discussing about dropping Javelin off
> tempest if it's not being used anymore in grenade, as sdague pointed
> out. We were thinking about this as a part of the work for [1], where we
> hit issue on Javelin script testing where gate did not detect the
> service clients changes in this script.

So the reason we didn't remove this from tempest when we stopped using it as
part of grenade is at the time there were external users. They still wanted to
keep the tooling around. This is why the unit tests were grown in an effort to
maintain some semblance of testing after the grenade removal. (for a long time
it was mostly self testing through the grenade job)

> 
> Our intention it's to drop the following files off tempest:
> 
>   * tempest/cmd/javelin.py
> 
>   * tempest/cmd/resources.yaml
> 
>   * tempest/tests/cmd/test_javelin.py
> 
> 
> 
> Before doing so, we'd like to get some feedback about out planned move,
> so if you have any questions, comments or feedback, please reply to this
> thread.

You should not just delete these files, there were real users of it in the past
and there might still be. If you're saying that javelin isn't something we can
realistically maintain anymore (which I'm not sure I buy, but whatever) we 
should first mark it for deprecation and have a warning print saying it will be
removed in the future. This gives people a chance to stop using it and migrate
to something else. (using ansible would be a good alternative)


-Matt Treinish

> 
> ---
> [1]
> https://review.openstack.org/#/q/status:open+project:openstack/tempest+branch:master+topic:bp/consistent-service-method-names,n,z
> 


signature.asc
Description: PGP signature
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev