Re: [openstack-dev] [QA]Refactoring Scenarios manager.py

2017-03-01 Thread Sean Dague
On 03/01/2017 08:03 AM, Andrea Frittoli wrote: > > > On Wed, Mar 1, 2017 at 12:54 PM Sean Dague > wrote: > > On 03/01/2017 07:35 AM, Jordan Pittier wrote: > > > > > > On Wed, Mar 1, 2017 at 3:57 AM, Ghanshyam Mann >

Re: [openstack-dev] [QA]Refactoring Scenarios manager.py

2017-03-01 Thread Luigi Toscano
On Wednesday, 1 March 2017 13:35:26 CET Jordan Pittier wrote: > On Wed, Mar 1, 2017 at 3:57 AM, Ghanshyam Mann > > > 2. Start refactoring the scenario framework by adding more and more helper > > function under /common or lib. > > Starting a "framework" (each time I see

Re: [openstack-dev] [QA]Refactoring Scenarios manager.py

2017-03-01 Thread Andrea Frittoli
On Wed, Mar 1, 2017 at 12:54 PM Sean Dague wrote: > On 03/01/2017 07:35 AM, Jordan Pittier wrote: > > > > > > On Wed, Mar 1, 2017 at 3:57 AM, Ghanshyam Mann > > wrote: > > > > Doing gradual refactoring and fixing

Re: [openstack-dev] [QA]Refactoring Scenarios manager.py

2017-03-01 Thread Andrea Frittoli
On Wed, Mar 1, 2017 at 12:39 PM Jordan Pittier wrote: > On Wed, Mar 1, 2017 at 3:57 AM, Ghanshyam Mann > wrote: > > Doing gradual refactoring and fixing plugins time to time needs lot of > wait and sync. > > That needs: > 1. Plugins to switch

Re: [openstack-dev] [QA]Refactoring Scenarios manager.py

2017-03-01 Thread Sean Dague
On 03/01/2017 07:35 AM, Jordan Pittier wrote: > > > On Wed, Mar 1, 2017 at 3:57 AM, Ghanshyam Mann > wrote: > > Doing gradual refactoring and fixing plugins time to time needs lot > of wait and sync. > > That needs: >

Re: [openstack-dev] [QA]Refactoring Scenarios manager.py

2017-03-01 Thread Jordan Pittier
On Wed, Mar 1, 2017 at 4:18 AM, wrote: > I think it a good solution, I already put +1 :) > > > And, as to the scenario testcases, shall we: > > 1) remove test steps/checks already coverd in API test > Duplicate test steps/checks is not good and should be removed. It's not

Re: [openstack-dev] [QA]Refactoring Scenarios manager.py

2017-03-01 Thread Jordan Pittier
On Wed, Mar 1, 2017 at 3:57 AM, Ghanshyam Mann wrote: > Doing gradual refactoring and fixing plugins time to time needs lot of > wait and sync. > > That needs: > 1. Plugins to switch from current method usage. Plugins to have some other > function or same copy paste code

Re: [openstack-dev] [QA]Refactoring Scenarios manager.py

2017-02-28 Thread zhu.fanglei
Sender: <ghanshyamm...@gmail.com> To: <openstack-dev@lists.openstack.org> Date: 2017/03/01 11:03 Subject: Re: [openstack-dev] [QA]Refactoring Scenarios manager.py Doing gradual refactoring and fixing plugins time to time needs lot of wait and sync. That needs: 1. Plugins to switch

Re: [openstack-dev] [QA]Refactoring Scenarios manager.py

2017-02-28 Thread Ghanshyam Mann
Doing gradual refactoring and fixing plugins time to time needs lot of wait and sync. That needs: 1. Plugins to switch from current method usage. Plugins to have some other function or same copy paste code what current scenario base class has. 2. Tempest patch to wait for plugin fix. 3. Plugins

Re: [openstack-dev] [QA]Refactoring Scenarios manager.py

2017-02-27 Thread Ken'ichi Ohmichi
I see Jordan's opinion here and I also faced this situation before. I proposed a hacking patch [1] to notify wrong usage of Tempest methods to projects and I saw some users of these methods didn't know the definition of stable interfaces of Tempest. We always face this issue on developments which

Re: [openstack-dev] [QA]Refactoring Scenarios manager.py

2017-02-26 Thread Andrea Frittoli
On Mon, 27 Feb 2017, 12:32 a.m. Ghanshyam Mann, wrote: > Yea, there is no doubt we should refactor scenario tests but even those > are internal interface it breaks plugins. We can argue that plugins should > not be using those but before that tempest should have all

Re: [openstack-dev] [QA]Refactoring Scenarios manager.py

2017-02-26 Thread zhu.fanglei
nstack-dev@lists.openstack.org> Date: 2017/02/27 08:32 Subject: Re: [openstack-dev] [QA]Refactoring Scenarios manager.py Yea, there is no doubt we should refactor scenario tests but even those are internal interface it breaks plugins. We can argue that plugins should not be using those

Re: [openstack-dev] [QA]Refactoring Scenarios manager.py

2017-02-26 Thread Ghanshyam Mann
Yea, there is no doubt we should refactor scenario tests but even those are internal interface it breaks plugins. We can argue that plugins should not be using those but before that tempest should have all required interface/class/helper as stable interface for plugins. which is what scenario

Re: [openstack-dev] [QA]Refactoring Scenarios manager.py

2017-02-26 Thread Andrea Frittoli
On Sun, Feb 26, 2017 at 12:49 AM Masayuki Igawa wrote: > Hi, > > Thank you for bringing this up. > > Yeah, I understand your frustration. We already have the document about > our stable interface[1]. It says > -- > Stability > Any code that lives in tempest/lib will be

Re: [openstack-dev] [QA]Refactoring Scenarios manager.py

2017-02-25 Thread Masayuki Igawa
Hi, Thank you for bringing this up. Yeah, I understand your frustration. We already have the document about our stable interface[1]. It says -- Stability Any code that lives in tempest/lib will be treated as a stable interface. This means that any public interface under the tempest/lib

[openstack-dev] [QA]Refactoring Scenarios manager.py

2017-02-25 Thread Jordan Pittier
Hi guys, So I have a problem with these 2 patches here [1] and here [2]. You basically are blocking any attempt of refactoring manager.py. Refactoring that file has been our number one priority for 2 cycles, and so far hardly no one stepped up really to do the work, except me with these 2 patches.