Re: [openstack-dev] [all] Hide CI comments in Gerrit

2014-07-24 Thread Mike Kolesnik
Great script! I have a fork that I made and improved it a bit: https://gist.github.com/mkolesni/92076378d45c7b5e692b This fork supports: 1. Button/link is integrated nicely to the gerrit UI (appears in the comments title, just like the other ones). 2. Auto hide will hide comments by default (can

Re: [openstack-dev] [all] Hide CI comments in Gerrit

2014-05-29 Thread Yuriy Taraday
On Tue, May 27, 2014 at 6:07 PM, James E. Blair jebl...@openstack.orgwrote: I wonder if it would be possible to detect them based on the presence of a Verified vote? Not all CIs always add a vote. Only 3 or so of over 9000 Neutron's CIs put their +/-1s on the change. -- Kind regards,

Re: [openstack-dev] [all] Hide CI comments in Gerrit

2014-05-28 Thread Qiu Yu
Hi Rado, Thanks for this cool userscript! It works great, and the only problem I found is TamperMonkey has some issue with hash in @include pattern matching[1]. So I end up using https://review.openstack.org/* instead of https://review.openstack.org/#/c/* [1]

Re: [openstack-dev] [all] Hide CI comments in Gerrit

2014-05-27 Thread Radoslav Gerganov
Hi Monty, As a next step - why not take the Javascript you've got there and submit it as a patch to the file above? We can probably figure out a way to template the third party CI names ... but starting one step at a time is a great idea. Thanks for the pointer, I have submitted

Re: [openstack-dev] [all] Hide CI comments in Gerrit

2014-05-27 Thread James E. Blair
Radoslav Gerganov rgerga...@vmware.com writes: Hi Monty, As a next step - why not take the Javascript you've got there and submit it as a patch to the file above? We can probably figure out a way to template the third party CI names ... but starting one step at a time is a great idea.

Re: [openstack-dev] [all] Hide CI comments in Gerrit

2014-05-27 Thread Kyle Mestery
On Mon, May 26, 2014 at 7:52 PM, Henry Gessau ges...@cisco.com wrote: On 5/26/2014 8:31 PM, Monty Taylor wrote: On 05/25/2014 05:23 AM, Radoslav Gerganov wrote: Hi, I created a small userscript that allows you to hide CI comments in Gerrit. That way you can read only comments written by

Re: [openstack-dev] [all] Hide CI comments in Gerrit

2014-05-27 Thread Daniel P. Berrange
On Tue, May 27, 2014 at 07:07:54AM -0700, James E. Blair wrote: Radoslav Gerganov rgerga...@vmware.com writes: Hi Monty, As a next step - why not take the Javascript you've got there and submit it as a patch to the file above? We can probably figure out a way to template the third

Re: [openstack-dev] [all] Hide CI comments in Gerrit

2014-05-27 Thread Anita Kuno
On 05/27/2014 10:16 AM, Daniel P. Berrange wrote: On Tue, May 27, 2014 at 07:07:54AM -0700, James E. Blair wrote: Radoslav Gerganov rgerga...@vmware.com writes: Hi Monty, As a next step - why not take the Javascript you've got there and submit it as a patch to the file above? We can

Re: [openstack-dev] [all] Hide CI comments in Gerrit

2014-05-27 Thread Daniel P. Berrange
On Tue, May 27, 2014 at 10:32:58AM -0400, Anita Kuno wrote: On 05/27/2014 10:16 AM, Daniel P. Berrange wrote: On Tue, May 27, 2014 at 07:07:54AM -0700, James E. Blair wrote: Radoslav Gerganov rgerga...@vmware.com writes: Hi Monty, As a next step - why not take the Javascript you've

Re: [openstack-dev] [all] Hide CI comments in Gerrit

2014-05-26 Thread Monty Taylor
On 05/25/2014 05:23 AM, Radoslav Gerganov wrote: Hi, I created a small userscript that allows you to hide CI comments in Gerrit. That way you can read only comments written by humans and hide everything else. I’ve been struggling for a long time to follow discussions on changes with many

Re: [openstack-dev] [all] Hide CI comments in Gerrit

2014-05-26 Thread Henry Gessau
On 5/26/2014 8:31 PM, Monty Taylor wrote: On 05/25/2014 05:23 AM, Radoslav Gerganov wrote: Hi, I created a small userscript that allows you to hide CI comments in Gerrit. That way you can read only comments written by humans and hide everything else. I’ve been struggling for a long time to

[openstack-dev] [all] Hide CI comments in Gerrit

2014-05-25 Thread Radoslav Gerganov
Hi, I created a small userscript that allows you to hide CI comments in Gerrit. That way you can read only comments written by humans and hide everything else. I’ve been struggling for a long time to follow discussions on changes with many patch sets because of the CI noise. So I came up with