Re: [openstack-dev] [bashate] towards "inbox zero" on bashate changes, release?
On 10/28/2014 10:03 PM, Ian Wienand wrote: > On 10/14/2014 04:03 PM, Ian Wienand wrote: >> Maybe it is time for a release? One thing; does the pre-release check >> run over TOT devstack and ensure there are no errors? We don't want >> to release and then 10 minutes later gate jobs start failing. > > Just to loop back on this ... > > Our main goal here should be to get [1] merged so we don't further > regress on any checks. > > TOT bashate currently passes against devstack; so we can release as > is. Two extra changes we might consider as useful in a release: > > - https://review.openstack.org/131611 (Remove automagic file finder) >I think we've agreed to just let test-frameworks find their own >files, so get rid of this > > - https://review.openstack.org/131616 (Add man page) >Doesn't say much, but it can't hurt > > As future work, we can do things like add warning-level checks, > automatically generate the documentation on errors being checked, etc. > > -i > > [1] https://review.openstack.org/128809 (Fix up file-matching in bashate tox > test) Looks great, I approved the 2 bashate checks. -Sean -- Sean Dague http://dague.net ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [bashate] towards "inbox zero" on bashate changes, release?
On 10/14/2014 04:03 PM, Ian Wienand wrote: > Maybe it is time for a release? One thing; does the pre-release check > run over TOT devstack and ensure there are no errors? We don't want > to release and then 10 minutes later gate jobs start failing. Just to loop back on this ... Our main goal here should be to get [1] merged so we don't further regress on any checks. TOT bashate currently passes against devstack; so we can release as is. Two extra changes we might consider as useful in a release: - https://review.openstack.org/131611 (Remove automagic file finder) I think we've agreed to just let test-frameworks find their own files, so get rid of this - https://review.openstack.org/131616 (Add man page) Doesn't say much, but it can't hurt As future work, we can do things like add warning-level checks, automatically generate the documentation on errors being checked, etc. -i [1] https://review.openstack.org/128809 (Fix up file-matching in bashate tox test) ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [bashate] towards "inbox zero" on bashate changes, release?
On 10/14/2014 07:03 AM, Ian Wienand wrote: > 1) changes for auto-detection. IMO, we should drop all these and just >leave bashate as taking a list of files to check, and let >test-harnesses fix it. Everyone using it at the moment seems fine >without them I am fine with this and abandoned the "Introduce directories as possible arguements" review request. This way we can use already exisiting tools like find and do not have to re-implement this. Christian. -- Christian Berendt Cloud Solution Architect Mail: bere...@b1-systems.de B1 Systems GmbH Osterfeldstraße 7 / 85088 Vohburg / http://www.b1-systems.de GF: Ralph Dehner / Unternehmenssitz: Vohburg / AG: Ingolstadt,HRB 3537 ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
[openstack-dev] [bashate] towards "inbox zero" on bashate changes, release?
Hi, I took the liberty of rebasing and approving the fairly obvious and already +1'd bashate changes today that had been sitting for quite a while. What's left is minimal and fall into three categories 1) changes for auto-detection. IMO, we should drop all these and just leave bashate as taking a list of files to check, and let test-harnesses fix it. Everyone using it at the moment seems fine without them https://review.openstack.org/110966 (Introduce directories as possible arguements) https://review.openstack.org/126842 (Add possibility to load checks automatically) https://review.openstack.org/117772 (Implement .bashateignore handling) https://review.openstack.org/113892 (Remove hidden directories from discover) 2) status-quo changes requiring IMO greater justification https://review.openstack.org/126853 (Small clean-up) https://review.openstack.org/126842 (Add possibility to load checks automatically) https://review.openstack.org/127473 (Put all messages into separate package) 3) if/then checking; IMO change is a minor regression https://review.openstack.org/127052 (Fixed "if-then" check when "then" is not in the end of line) Maybe it is time for a release? One thing; does the pre-release check run over TOT devstack and ensure there are no errors? We don't want to release and then 10 minutes later gate jobs start failing. -i ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
