Re: [openstack-dev] [devstack] Bug in is_*_enabled functions?

2014-02-28 Thread Dean Troyer
On Fri, Feb 28, 2014 at 10:21 AM, Brian Haley wrote: > Of course now boot_from_volume.sh fails because it doesn't include > lib/neutron, > I've just pushed a patch for that, https://review.openstack.org/#/c/77212/ > Thanks. It's absence from the gate left it the poor stepchild many times. dt

Re: [openstack-dev] [devstack] Bug in is_*_enabled functions?

2014-02-28 Thread Brian Haley
On 02/27/2014 11:55 AM, Dean Troyer wrote: > There is a problem in two of DevStack's exercises, floating_ips.sh and > volume.sh, where lib/neutron is not set up properly to handle the ping_check() > function calls. That is what leads to what you see. > https://review.openstack.org/#/c/76867/ fixe

Re: [openstack-dev] [devstack] Bug in is_*_enabled functions?

2014-02-27 Thread Brian Haley
On 02/27/2014 11:55 AM, Dean Troyer wrote: > On Thu, Feb 27, 2014 at 10:34 AM, Brian Haley > wrote: > > Ok, part of this is my kernel background, where true=1 like it should be > :) > So there's a -EUSERERROR there. > > > Right. This is Bourne/POSIX shell, f

Re: [openstack-dev] [devstack] Bug in is_*_enabled functions?

2014-02-27 Thread Dean Troyer
On Thu, Feb 27, 2014 at 10:34 AM, Brian Haley wrote: > Ok, part of this is my kernel background, where true=1 like it should be :) > So there's a -EUSERERROR there. > Right. This is Bourne/POSIX shell, forget everything logical. ;) > That call to 'ip netns exec...' should be: > > sudo /usr/lo

Re: [openstack-dev] [devstack] Bug in is_*_enabled functions?

2014-02-27 Thread Brian Haley
On 02/26/2014 04:23 PM, Brian Haley wrote: > On 02/26/2014 01:36 PM, Dean Troyer wrote: >> On Wed, Feb 26, 2014 at 11:51 AM, Brian Haley > > wrote: >> >> While trying to track down why Jenkins was handing out -1's in a >> Neutron patch, >> I was seeing errors

Re: [openstack-dev] [devstack] Bug in is_*_enabled functions?

2014-02-27 Thread Brian Haley
On 02/26/2014 05:18 PM, Carl Baldwin wrote: > Brian, > > In shell it is correct to return 0 for success and non-zero for failure. But, at least in lib/neutron, there is a check like this: if is_service_enabled neutron; then ... fi Which will fail with a 0 return code and miss some config. It s

Re: [openstack-dev] [devstack] Bug in is_*_enabled functions?

2014-02-26 Thread Carl Baldwin
Brian, In shell it is correct to return 0 for success and non-zero for failure. Carl On Feb 26, 2014 10:54 AM, "Brian Haley" wrote: > While trying to track down why Jenkins was handing out -1's in a Neutron > patch, > I was seeing errors in the devstack tests it runs. When I dug deeper it > lo

Re: [openstack-dev] [devstack] Bug in is_*_enabled functions?

2014-02-26 Thread Brian Haley
On 02/26/2014 01:36 PM, Dean Troyer wrote: On Wed, Feb 26, 2014 at 11:51 AM, Brian Haley mailto:brian.ha...@hp.com>> wrote: While trying to track down why Jenkins was handing out -1's in a Neutron patch, I was seeing errors in the devstack tests it runs. When I dug deeper it loo

Re: [openstack-dev] [devstack] Bug in is_*_enabled functions?

2014-02-26 Thread Dean Troyer
On Wed, Feb 26, 2014 at 11:51 AM, Brian Haley wrote: > While trying to track down why Jenkins was handing out -1's in a Neutron > patch, > I was seeing errors in the devstack tests it runs. When I dug deeper it > looked > like it wasn't properly determining that Neutron was enabled - > ENABLED_S

[openstack-dev] [devstack] Bug in is_*_enabled functions?

2014-02-26 Thread Brian Haley
While trying to track down why Jenkins was handing out -1's in a Neutron patch, I was seeing errors in the devstack tests it runs. When I dug deeper it looked like it wasn't properly determining that Neutron was enabled - ENABLED_SERVICES had multiple "q-*" entries, but 'is_service_enabled neutron