Dmitry, just a quick note to say I'm very pleased to see the progress
from the Fuel team in collaborating with the Puppet OpenStack upstream
team. Great to see puppet-librarian-simple starting to reduce the
duplication and forking of Puppet modules in Fuel.
Kudos.
Best,
-jay
On 08/03/2015 10:19 PM, Dmitry Borodaenko wrote:
Two weeks ago we had a discussion of where things stand in the
collaboration
between Fuel and Puppet OpenStack projects [0].
[0]
http://lists.openstack.org/pipermail/openstack-dev/2015-July/069925.html
Things that were good at that point:
- number of proposed patch sets
Things that needed further improvement:
- proposed patch sets to merged commits ratio
- stuck commits
- quality of code reviews
- participation in weekly IRC meetings
The patch sets metric has continued to improve, the share of patch
sets pushed by Fuel developers has increased from 11.5% to 17.4%.
The patch sets to commits ratio doesn't look that good: only two
commits were merged last week. This number is too small to be
statistically significant, but it does increase the ratio from 13.5
to 19, which is a large change in the wrong direction. Average for
Puppet OpenStack last week was 7.6, that's what we should be aiming
at.
The stuck commits problem was addressed by introducing the
Disagreement section into the review inbox [1] and bringing up the
problematic commits in the weekly meetings. Since last week, there
were no commits from Fuel team that were held back by disagreements
in review for more than a few days.
[1]
http://lists.openstack.org/pipermail/openstack-dev/2015-July/070072.html
This means that it's now up to Fuel team to push higher quality
patch sets that can be merged faster.
The number of reviews done for commits in Puppet OpenStack by Fuel team has
jumped from 6.4% to 21.8% over the past two weeks. Comparing the +/- and
disagrements ratios of top Mirantis reviewers over 90 and 30 days also
shows
consistent improvement:
Bogdan Dobrelia: 64.5% - 67.2% (disagreements 9.2% - 4.9%)
Denis Egorenko: 97.7% - 97% (disagreements 16.3% - 12.1%)
Alex Schultz: 81.2% - 80% (disagreements 25% - 20%)
Sergey Kolekonov: 95.5% - 91.7% (disagreements 13.6% - 8.3%)
Sergii Golovatiuk: 100% - 100% (disagreements 36.4% - 33.3%)
Ivan Berezovskiy: 100% - 100% (disagreements 15.8% - 0%)
Vasyl Saienko: 100% - 100% (disagreements 20% - 16.7%)
Bogdan is setting an excellent example with his #6 position at 61
reviews in last 30 days. It will take some time for others to catch
up, but at least they're all moving in the right direction (more -1's
with less disagreements).
As I already mentioned, participation in weekly IRC meetings has also
improved:
Jul-14: 1 of 16 participants, 10 of 295 lines
Jul-21: 5 of 17 participants, 89 of 291 lines
Jul-28: 7 of 18 participants, 26 of 193 lines
Finally, this weeek we've also made huge progress on getting rid of forked
copies of upstream modules [2]. We've landed the initial support for
puppet-librarian-simple and dropped in-place forks of 3 modules (stdlib,
concat, inifile), with 7 more modules lined up [3].
[2]
http://lists.openstack.org/pipermail/openstack-dev/2015-July/069906.html
[3]
http://lists.openstack.org/pipermail/openstack-dev/2015-July/071106.html
Kudos to Alex for preparing this patch series and writing an
excellent guide on how to work with modules managed by
puppet-librarian-simple [4].
[4] https://wiki.openstack.org/wiki/Fuel/Library_and_Upstream_Modules
To sum up, Fuel team has made a lot of progress over the past two
weeks in most areas, however patch sets to commits ratio remains the
most important problem and has seen no improvement so far.
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
